From: Harman Kalra <hkalra@marvell.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Jerin Jacob <jerinj@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
<david.marchand@redhat.com>, <olivier.matz@6wind.com>,
<dev@dpdk.org>
Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] net/octeontx2: fix dynamic registration for timestamp
Date: Tue, 3 Nov 2020 21:20:50 +0530 [thread overview]
Message-ID: <20201103155049.GA21056@outlook.office365.com> (raw)
In-Reply-To: <89135471.sFktW74q6F@thomas>
On Tue, Nov 03, 2020 at 04:41:14PM +0100, Thomas Monjalon wrote:
> External Email
>
> ----------------------------------------------------------------------
> 03/11/2020 16:20, Harman Kalra:
> > Registration of timestamp field should be done once and
>
> Why?
> Next registrations does nothing, it is not a problem.
>
> > only when ptp kernel changes are successful.
>
> Rx timestamp can be useful without PTP.
Ack, you are correct, VF change is also required.
>
> > --- a/drivers/net/octeontx2/otx2_ethdev.c
> > +++ b/drivers/net/octeontx2/otx2_ethdev.c
> > @@ -2225,16 +2225,6 @@ otx2_nix_dev_start(struct rte_eth_dev *eth_dev)
> > if (otx2_ethdev_is_ptp_en(dev) && otx2_dev_is_vf(dev))
> > otx2_nix_ptp_enable_vf(eth_dev);
>
> NIX_RX_OFFLOAD_TSTAMP_F is set in above function.
> Is it useless? Or should we register timestamp below?
>
> > - if (dev->rx_offload_flags & NIX_RX_OFFLOAD_TSTAMP_F) {
> > - rc = rte_mbuf_dyn_rx_timestamp_register(
> > - &dev->tstamp.tstamp_dynfield_offset,
> > - &dev->tstamp.rx_tstamp_dynflag);
> > - if (rc != 0) {
> > - otx2_err("Failed to register Rx timestamp field/flag");
> > - return -rte_errno;
> > - }
> > - }
>
>
>
prev parent reply other threads:[~2020-11-03 15:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 15:20 [dpdk-dev] " Harman Kalra
2020-11-03 15:41 ` Thomas Monjalon
2020-11-03 15:50 ` Harman Kalra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103155049.GA21056@outlook.office365.com \
--to=hkalra@marvell.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=olivier.matz@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).