From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EAF12A0521; Tue, 3 Nov 2020 16:51:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5EFF8CBF0; Tue, 3 Nov 2020 16:51:29 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id D10E6CB96 for ; Tue, 3 Nov 2020 16:51:27 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0A3Fo1Vg015168; Tue, 3 Nov 2020 07:51:25 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=pfpt0220; bh=Oh03FHPMEvn6nqhH5/zT4d8ItSh0AOm+5nd7ktRcBIY=; b=gfYCi9gmtYl3/qtat2Vyeq6V71afOusCim+381xdfQeADFkFX8riXidAez++DrcpNvHs 4aLbeUUzLjrHDDvPMPlsmwSypeq55JKxzjL8Idjw2eQy26Ob4EpeyaU5LDhHOHDTPMH7 C7oE7QtebNbWJ/6rIdaeeUYdD72i23R3cGoiptxM6edUDCT6ESKrrYBSHHS2XeMHgECf H1CZwB1ZCcGf3RpG3qJTL0qGDY0zM3KBStDqaODSDRPWt70wvYzN7LO5WvadFI0LkGhq xcqAw6YcKIF25m5qzvafS9/ojMCQdcsHveCBNbWICa5ZXp2ScHfyfVSAn2XXzoKqzzsl pA== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 34h7enwmh8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 03 Nov 2020 07:51:25 -0800 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 3 Nov 2020 07:51:23 -0800 Received: from SC-EXCH01.marvell.com (10.93.176.81) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 3 Nov 2020 07:51:23 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Tue, 3 Nov 2020 07:51:22 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rbi0pc5ob0EU0ztZjMirIzoIyBjzuw0krJQz83Ba32Nx0yhok9JXYJTVbHwM1ZmhycZIT0OM8ErJe9/no4wMylYkjiEd1fZt8lnq7ifopZTENzwI3eNQUGDYbMYTenrZRT5JrSdwXHjgY87hyTkkfkyb2cIEj9wxrmTX+QDWkzc1o/eRBAmAVGqW+Bi4ru8n3mCbsVLeQ9tTdOMtVlvHMVmcesOKrxDmv83O4syGpBShHQ6EppBz+CkUUlix0y7dvYcaPOvTMG/dJhvGhS8I4VRYU/GHj3fFOWQ99la0jbvjL80F7MEdAER6SlWJYCEPGCrDXJlmibzYh6jFmjyPdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Oh03FHPMEvn6nqhH5/zT4d8ItSh0AOm+5nd7ktRcBIY=; b=DYfMCLqRer0xr5B5H04LIDh3gBHcHB6G6tswY4QDV7Q/CmO7aR1FA5d7pMo3M9dVpHYqJiEz6INM3ddu1cs5aIqNohUqUhlC2U8d4lYvRpjbJjKmLgKA+9xKNaCo9bIZg3TVOYTQ0hq6WmeVpOhlDQG5Wt0Mpjq9ttbaj4qF/krfQiDj0VGpOGaj8b5SUvjB0PCx5XdAOUO0BOfAVbge8f0wHYpJfj87acCU7RUe1MntikMArDypZCsZYEzmb1clRYX9DG0iGavX9zlJ3wHTQQxELCtXomlVrxcPJjVvyHl9jKT0XkwL0zQw5h5DweoJJadmFBY5tWJrTMMzCFRKLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Oh03FHPMEvn6nqhH5/zT4d8ItSh0AOm+5nd7ktRcBIY=; b=lWQzf5+a/SrD5+scDE4jLSxRafzeyfvwYCs5JZ5n0qqLH/e6jXJlYY8g2LxXLK5DFvZgSoZYYb0jnZyTfqMVhEl/PwIDmgYBW43pB11JJSiW23nuvjO6g6za6XFV/hHAtmJC5U/sK0OE6qqeu/CLdQIiAzVfTYUrMryOd9xOnxo= Authentication-Results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=marvell.com; Received: from CO6PR18MB3842.namprd18.prod.outlook.com (2603:10b6:5:341::16) by MWHPR1801MB1840.namprd18.prod.outlook.com (2603:10b6:301:68::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.30; Tue, 3 Nov 2020 15:51:21 +0000 Received: from CO6PR18MB3842.namprd18.prod.outlook.com ([fe80::b960:6770:a1:2a19]) by CO6PR18MB3842.namprd18.prod.outlook.com ([fe80::b960:6770:a1:2a19%7]) with mapi id 15.20.3499.032; Tue, 3 Nov 2020 15:51:21 +0000 Date: Tue, 3 Nov 2020 21:20:50 +0530 From: Harman Kalra To: Thomas Monjalon CC: Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , , , Message-ID: <20201103155049.GA21056@outlook.office365.com> References: <20201103152040.17654-1-hkalra@marvell.com> <89135471.sFktW74q6F@thomas> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <89135471.sFktW74q6F@thomas> User-Agent: Mutt/1.10.0 (2018-05-17) X-Originating-IP: [1.6.215.26] X-ClientProxiedBy: BM1PR01CA0110.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00::26) To CO6PR18MB3842.namprd18.prod.outlook.com (2603:10b6:5:341::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from outlook.office365.com (1.6.215.26) by BM1PR01CA0110.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18 via Frontend Transport; Tue, 3 Nov 2020 15:51:18 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e0025cc3-e224-4d2f-306c-08d880104f42 X-MS-TrafficTypeDiagnostic: MWHPR1801MB1840: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: h7Pcx/UVpRKmcosWbywOJw2KLOb8Ww2ijZkeFBRXVZwqyMrLJPVTTeA5ZxDsAzv3aLH5/qZm3qLB/cabPd/FARHidhHOx69ev8jawM6Qn5s8EQdRPlUWY8R0jCqADztGkYG3Kytt51/yWl/Q2KrTdR9bxFCmS5fwGoN9FrlbEKATvh9DN9vzNaLk0lyVh7aWjLNAIJy0B3oVCS/Avq7D6fwD/sFalV7ioZAR2Fip/Uuz//Dcwh3BI2L0gGcpJLpu0VmBfVHKYuCSlJ44i96xn93hXNaew0ydehkSVYl5HNDmMOCGl9jHUqQ4t0szcOR6peDX961DkxBviGO/ioQYGexvhY4qf05Vy91zlcsboaIBOkcqbWudUMfSgYKwexUeCqf451u0wlGFBBPiVXu1zA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB3842.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(956004)(66476007)(66556008)(66946007)(55016002)(6916009)(1076003)(33656002)(5660300002)(498600001)(4326008)(86362001)(52116002)(7696005)(186003)(16526019)(8936002)(54906003)(6666004)(26005)(1006002)(2906002)(9686003)(8676002)(6506007)(36456003)(42976004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: RySLj4Tssm8cgkxdFKozh5wW551tvYWD3jfYEuYkSu7k+pFfnuzcrp6Ihc7zhCat/pRQlNa9eGEagMjVBBN+woejPLPhoNJWEeevob59UyYHBvum0olifI2KdvUZHGRl1rzg1b6r9V80WhJdEA7xYLWMBWxXp51GBHBfI+xEBOZ9TA/oeajQ4F/lW1OyN3P9Btdal/cIjTvzemgFOXqaPTa/zBjmdqxiQf8xQAqPSanuAmO0BywmRZSgBGD4hwWX1kZMRoYxYNGq1WZ7A+CTOwS+dw86z3M706VzIXJQCIVrinLKq0tm9dYSyWeqKV816qHwqpmyVioHmbSUHUrVDCUONwZNUkMTSkYEno7ILpij6wdnemG+X4Q83c3FTsdJZyqMveQiSPIZ1MxRL3UTntb8sFFpcD28t1tS+HDiKrWcVYfoYZSfmdQCkPw2h4uXgpHqZOwqmhTtVEPPq2xXUODET7rwfagm5CUdyVxSFRoPHA5bP/lxUo9PRJZdFmxs8gqWm/dNeyXx7ZqnjKzNgZT28G6DYR7130bqmDFJjaQYvYWFvGNEsxCcdBrHx+pX+2wEPM3x6T2DLDEHNspgsI3mNj0AGA52bcFPhkIxNkNaIMAPGdd26sVFy/sb9saE9hx2ETw3JJuC09A+S2HepQ== X-MS-Exchange-CrossTenant-Network-Message-Id: e0025cc3-e224-4d2f-306c-08d880104f42 X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB3842.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2020 15:51:21.1869 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: axwInnOOlqMzavzjQpRI7IjTwcHxJXtzwEXQttXTZEUCbqSr7jVESfqiTYLOdYuNl0p7WlC0TnJXbOKa+F/MKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1801MB1840 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312, 18.0.737 definitions=2020-11-03_08:2020-11-03, 2020-11-03 signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] net/octeontx2: fix dynamic registration for timestamp X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 03, 2020 at 04:41:14PM +0100, Thomas Monjalon wrote: > External Email > > ---------------------------------------------------------------------- > 03/11/2020 16:20, Harman Kalra: > > Registration of timestamp field should be done once and > > Why? > Next registrations does nothing, it is not a problem. > > > only when ptp kernel changes are successful. > > Rx timestamp can be useful without PTP. Ack, you are correct, VF change is also required. > > > --- a/drivers/net/octeontx2/otx2_ethdev.c > > +++ b/drivers/net/octeontx2/otx2_ethdev.c > > @@ -2225,16 +2225,6 @@ otx2_nix_dev_start(struct rte_eth_dev *eth_dev) > > if (otx2_ethdev_is_ptp_en(dev) && otx2_dev_is_vf(dev)) > > otx2_nix_ptp_enable_vf(eth_dev); > > NIX_RX_OFFLOAD_TSTAMP_F is set in above function. > Is it useless? Or should we register timestamp below? > > > - if (dev->rx_offload_flags & NIX_RX_OFFLOAD_TSTAMP_F) { > > - rc = rte_mbuf_dyn_rx_timestamp_register( > > - &dev->tstamp.tstamp_dynfield_offset, > > - &dev->tstamp.rx_tstamp_dynflag); > > - if (rc != 0) { > > - otx2_err("Failed to register Rx timestamp field/flag"); > > - return -rte_errno; > > - } > > - } > > >