From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB6A2A04E7; Tue, 3 Nov 2020 20:27:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5978E592C; Tue, 3 Nov 2020 20:27:56 +0100 (CET) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id 669AB54AE for ; Tue, 3 Nov 2020 20:27:53 +0100 (CET) Received: by mail-wr1-f68.google.com with SMTP id x7so19719050wrl.3 for ; Tue, 03 Nov 2020 11:27:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=CCENZFrtgAY+wzBQcaLi0pjUFaLNtO0Fuy4I8AwlLpw=; b=iR56+3+Bg7KcF4sbsf2Dq+RronQLYx5cYg2xg1eCnjB5thgCcUM1JVvFfHpm4MQXsv 0UMxWKeAZG/7afxFA313XmlmeAri4ZDG70m0tiT/kpIMkNKLv9T64EsxrM3fzr48lVff 88xkY5y+K4cYuNGflqpMBpE3Fl0vysvlRwOlQjN7oJndUwO4TuuyFPxUHo/onJd/PVe1 CXRjZ8iYIvtSJ7SKDajnlDe6vqrIHZRoDCzADGKKVf5kNAf7cq/JzTMiZ57/ABghv8Dl B3OP4gEOCc6OxgPgiC6u/rJ7DZOKsVB3gcOqxk4PSg11rgfxFOeInUYI21U0TJ7yYHFs hlXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=CCENZFrtgAY+wzBQcaLi0pjUFaLNtO0Fuy4I8AwlLpw=; b=q5tW0kkxkRY9f7uQ8YtusYoE73DJRqjOZFsxgQ1V9rjJiEE6YY6ErXCzwlF43IPuc5 bCGFtzGukrySg6VV56CUGmkcM3GWVnTFuo1/RkPp1pIHFXuEuuFWyrlQXIWyE1Y3458i Z7aZTy0C0fmTjizgRX+1KtLt9bK55EG6XR1dNlqvtDzC8UIE47C0ux2B66Jm7+i9bSzv EkbF58icUbQSv5a1AoM3+nOCAvwZuW4y1BVTquFit08tkRI3O/l4uHMh47MrPC8KbKL0 s3h16wTh509W0OuiZlEQgGRTbSsjYqtvKEWCcpBnIj1qFOxKRxs+2rw8Q6dAXL/EZIaW xofg== X-Gm-Message-State: AOAM530l6jwLmpGLAzapAzhvwTMwqIH/wFuBrC5jgMQfKxbb1EG2J9Aw qYoVMR+DCfePLp4MkjwEq2AfEQ== X-Google-Smtp-Source: ABdhPJyb58gvVwzKfjbf8uo54SSM6xp62niLlf47UD5S70WQc+6mGBE2mJVsk+C6ksTYj95b6N2tcg== X-Received: by 2002:adf:f546:: with SMTP id j6mr28771433wrp.220.1604431672168; Tue, 03 Nov 2020 11:27:52 -0800 (PST) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id k81sm4303419wma.2.2020.11.03.11.27.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2020 11:27:51 -0800 (PST) Date: Tue, 3 Nov 2020 20:27:50 +0100 From: Robin Jarry To: David Marchand Cc: dev@dpdk.org, bruce.richardson@intel.com, Neil Horman , Rosen Xu , Andrew Rybchenko , Luca Boccassi Message-ID: <20201103192750.zr6gh3oz3wjnbeys@6wind.com> References: <20201103183906.8088-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201103183906.8088-1-david.marchand@redhat.com> User-Agent: NeoMutt/20180716 Subject: Re: [dpdk-dev] [PATCH] usertools: fix pmdinfo parsing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2020-11-03, David Marchand: > This script was using the librte_pmd prefix has a filter to follow > DT_NEEDED entries. > Now that we changed the driver names, update this heuristic with an > explicit list of device classes. > > Fixes: a20b2c01a7a1 ("build: standardize component names and defines") > > Signed-off-by: David Marchand > --- > usertools/dpdk-pmdinfo.py | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/usertools/dpdk-pmdinfo.py b/usertools/dpdk-pmdinfo.py > index 1661982791..687a9fd032 100755 > --- a/usertools/dpdk-pmdinfo.py > +++ b/usertools/dpdk-pmdinfo.py > @@ -450,7 +450,10 @@ def process_dt_needed_entries(self): > for tag in dynsec.iter_tags(): > # pyelftools may return byte-strings, force decode them > if force_unicode(tag.entry.d_tag) == 'DT_NEEDED': > - if 'librte_pmd' in force_unicode(tag.needed): > + words = force_unicode(tag.needed).split('_') > + if words and len(words) >= 3 and words[0] == 'librte' and \ > + words[1] in ['baseband', 'compress', 'crypto', 'event', > + 'net', 'raw', 'regex', 'vdpa']: This code is already ugly and I don't have much better to suggest... Acked-by: Robin Jarry