DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Hunt <david.hunt@intel.com>
To: dev@dpdk.org
Cc: david.hunt@intel.com, stable@dpdk.org
Subject: [dpdk-dev] [PATCH v5] lib/power: remove set env deprecation notice
Date: Wed,  4 Nov 2020 09:28:10 +0000
Message-ID: <20201104092810.29135-1-david.hunt@intel.com> (raw)
In-Reply-To: <20201027132413.23116-1-david.hunt@intel.com>

Remove notice announcing an already-implemented change.

In 19.05, rte_power_set_env was changed to return -1 in cases where
the envorinment was already set up, and for the same release, a
deprecation notice was added for the following commit:
'commit 5a5f3178d4a8 ("power: return error when environment already set")'
This patch removes that notice.

The API change was tested by calling rte_power_set_env twice. The first
call succeeded, and the second call failed, as expected.

Signed-off-by: David Hunt <david.hunt@intel.com>
Fixes: 5a5f3178d4a8 ("power: return error when environment already set")
CC: stable@dpdk.org

---
v1 initial version (with typo in the title)
v2 fix typo but forgot --in-reply-to
v3 add -in-reply-to
v4 add in version info, and cc stable in case it needs to be backported
v5 add in Fixes line.

Note: CC'ing stable in case the deprecation notice should also be removed
from 19.11. It looks to me like the patch making the change and the patch
adding the notice were both added in 19.11, so the notice is no longer
needed in that version.
---
---
 doc/guides/rel_notes/deprecation.rst | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 43e0e09be..7e40f2d72 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -141,11 +141,6 @@ Deprecation Notices
 * metrics: The function ``rte_metrics_init`` will have a non-void return
   in order to notify errors instead of calling ``rte_exit``.
 
-* power: ``rte_power_set_env`` function will no longer return 0 on attempt
-  to set new power environment if power environment was already initialized.
-  In this case the function will return -1 unless the environment is unset first
-  (using ``rte_power_unset_env``). Other function usage scenarios will not change.
-
 * cmdline: ``cmdline`` structure will be made opaque to hide platform-specific
   content. On Linux and FreeBSD, supported prior to DPDK 20.11,
   original structure will be kept until DPDK 21.11.
-- 
2.17.1


  parent reply	other threads:[~2020-11-04  9:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-27 12:49 [dpdk-dev] [PATCH v2] " David Hunt
2020-10-27 12:52 ` [dpdk-dev] [PATCH v3] " David Hunt
2020-10-27 13:24   ` [dpdk-dev] [PATCH v4] " David Hunt
2020-11-03 20:46     ` Thomas Monjalon
2020-11-04  9:28     ` David Hunt [this message]
2020-11-04 20:10       ` [dpdk-dev] [dpdk-stable] [PATCH v5] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201104092810.29135-1-david.hunt@intel.com \
    --to=david.hunt@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git