DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, kevin.laatz@intel.com, david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH] raw/ioat: fix queue index calculation
Date: Wed, 4 Nov 2020 09:43:04 +0000
Message-ID: <20201104094304.GC58@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <3222901.gxSNrrN49U@thomas>

On Tue, Nov 03, 2020 at 10:51:17PM +0100, Thomas Monjalon wrote:
> 03/11/2020 21:21, Thomas Monjalon:
> > 03/11/2020 15:48, Bruce Richardson:
> > > Coverity flags a possible problem where the 8-bit wq_idx value may have
> > > errors when shifted and sign-extended to 64-bits. Since this can only occur
> > > if the shift index is larger than any expected value from hardware, it's
> > > unlikely to cause any real problems, but we can eliminate any
> > > possible errors, and the coverity issue, by explicitly typecasting
> > > the uint8_t value to 64-bits before any shift operations occur.
> > > 
> > > Coverity issue: 363695
> > > Fixes: a33969462135 ("raw/ioat: fix work-queue config size")
> > > 
> > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > 
> > Applied, thanks
> 
> Actually no, sorry for the confusion, there is a build issue
> with 32-bit compiler:
> 	error: cast to pointer from integer of different size
> 
> (thanks David for the heads up)
> 
Ok, thanks for heads-up, I'll see about a v2.

  reply	other threads:[~2020-11-04  9:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-03 14:48 Bruce Richardson
2020-11-03 20:21 ` Thomas Monjalon
2020-11-03 21:51   ` Thomas Monjalon
2020-11-04  9:43     ` Bruce Richardson [this message]
2020-11-05 10:41 ` [dpdk-dev] [PATCH v2] " Bruce Richardson
2020-11-13 14:32   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201104094304.GC58@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=kevin.laatz@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git