From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45634A04E7; Wed, 4 Nov 2020 10:43:16 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F418FC884; Wed, 4 Nov 2020 10:43:14 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 5A88FC86C for ; Wed, 4 Nov 2020 10:43:13 +0100 (CET) IronPort-SDR: Ln9xkATewoXRA6hhCW90yk3oVJpL1q5jmdFLHri1kLbfV8mwQQeBI6gHxMNZfC0IftqqOxTSEw 9meJdjYVaEDg== X-IronPort-AV: E=McAfee;i="6000,8403,9794"; a="166601835" X-IronPort-AV: E=Sophos;i="5.77,450,1596524400"; d="scan'208";a="166601835" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2020 01:43:10 -0800 IronPort-SDR: Eifd4LTGvhYaMlp7cZ6n7v7HSVTZ7AbftVbSnrcsn9RNgwdlVndl0QdtTHb0bEQmR7r71KnpvB Kng8wk+55F6A== X-IronPort-AV: E=Sophos;i="5.77,450,1596524400"; d="scan'208";a="538849696" Received: from bricha3-mobl.ger.corp.intel.com ([10.249.46.64]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 04 Nov 2020 01:43:08 -0800 Date: Wed, 4 Nov 2020 09:43:04 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, kevin.laatz@intel.com, david.marchand@redhat.com Message-ID: <20201104094304.GC58@bricha3-MOBL.ger.corp.intel.com> References: <20201103144858.1317742-1-bruce.richardson@intel.com> <3222890.4p7qmXYJiy@thomas> <3222901.gxSNrrN49U@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3222901.gxSNrrN49U@thomas> Subject: Re: [dpdk-dev] [PATCH] raw/ioat: fix queue index calculation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 03, 2020 at 10:51:17PM +0100, Thomas Monjalon wrote: > 03/11/2020 21:21, Thomas Monjalon: > > 03/11/2020 15:48, Bruce Richardson: > > > Coverity flags a possible problem where the 8-bit wq_idx value may have > > > errors when shifted and sign-extended to 64-bits. Since this can only occur > > > if the shift index is larger than any expected value from hardware, it's > > > unlikely to cause any real problems, but we can eliminate any > > > possible errors, and the coverity issue, by explicitly typecasting > > > the uint8_t value to 64-bits before any shift operations occur. > > > > > > Coverity issue: 363695 > > > Fixes: a33969462135 ("raw/ioat: fix work-queue config size") > > > > > > Signed-off-by: Bruce Richardson > > > > Applied, thanks > > Actually no, sorry for the confusion, there is a build issue > with 32-bit compiler: > error: cast to pointer from integer of different size > > (thanks David for the heads up) > Ok, thanks for heads-up, I'll see about a v2.