From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9375BA04B1; Wed, 4 Nov 2020 17:27:00 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D30B12C2D; Wed, 4 Nov 2020 17:26:58 +0100 (CET) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id 1DA0E2C27 for ; Wed, 4 Nov 2020 17:26:57 +0100 (CET) Received: by mail-wm1-f68.google.com with SMTP id d142so2945285wmd.4 for ; Wed, 04 Nov 2020 08:26:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rcZ5wgSreWIJCF5FCWUjk0xarydnTWbWflUgwptbdNU=; b=RkLoMmxsZREX4DfKHUygrfmMsRiZOdArUn83k6WC02TRP1nHyhIm/z8Xe5Pjl12QRv kcA7L5ls9n42YHGExGbRSO5Q0JQZN98sLpqUS1LLikEkntqsTQ55MpCptBRPgb6pjvtX PCZWiihUVWqBCcOiV3Ubz22iFkYPO5JLPD4DxBU6tu2s5T+725AT+RNTU1oSwbdlrPSw IoSXdQ4ZO1IZuQFoO0LIHcYaon2KvXFIgWZoGQZvOTEd+2m7o9aV6IrzZE4Gm3PiimSA 6JMBkFeNIyl2I+6OXJpHbomiqCG2XVs4+MKRxpGmhxn56IlZcl4zWfc65QQY7Wi2iIqv Enkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rcZ5wgSreWIJCF5FCWUjk0xarydnTWbWflUgwptbdNU=; b=SD1ieoTrNtzrLWXvL+nHgzs2mQ2DYIVueegwZmSKg0tOn5A9AllwgIXkPuvZg1ZxaY t3mgjcj9vZNLpMr/ilW3Pi2DWpB8SvTWN+YV3f/3TfrJWGyl5YiJ68VEdrxA0A/kNVAp j9xeR2azum5aJQTvhh1/fPuX/tNEdrME5Jbf0tBScqzPBJbTinATRAj6JQan2skrIyy0 /nTiod571oVqV9++fRacertxgIwzjVHxfg1b2s/0DDaBb/DAMKada2QwK7CxZliYhWrl Zai1rSu+XSTHdrKE2xFEdo8f5N6GDxg75magZD4vNgOp2lZh6jCWD+IqNP0TriEtdG0z f4ng== X-Gm-Message-State: AOAM531R7TSYyFTMv7iTseyAixWdyqf56hNs5WsoCzviFn1XelhY5Zwo NksPXz90JK6dYHFWs34aFDceAIod8/WeCw== X-Google-Smtp-Source: ABdhPJwRJGQ5DJ/CpfNnis8X4x3uMf2HnfUB5mE2it10tEnA0j+UOb6Lsg9ZYc9UlCL0K3aRkDriNQ== X-Received: by 2002:a1c:7303:: with SMTP id d3mr5841266wmb.152.1604507215739; Wed, 04 Nov 2020 08:26:55 -0800 (PST) Received: from 6wind.com (2a01cb0c0005a600345636f7e65ed1a0.ipv6.abo.wanadoo.fr. [2a01:cb0c:5:a600:3456:36f7:e65e:d1a0]) by smtp.gmail.com with ESMTPSA id g186sm7371531wma.1.2020.11.04.08.26.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 08:26:55 -0800 (PST) Date: Wed, 4 Nov 2020 17:26:54 +0100 From: Olivier Matz To: Stephen Hemminger Cc: dev@dpdk.org Message-ID: <20201104162654.GK1898@platinum> References: <20201024004331.25043-1-stephen@networkplumber.org> <20201104162000.9419-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201104162000.9419-1-stephen@networkplumber.org> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v5] mbuf: allow dynamic flags to be used by secondary process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Nov 04, 2020 at 08:20:00AM -0800, Stephen Hemminger wrote: > The dynamic flag management is broken if rte_mbuf_dynflag_lookup() > is done in a secondary process because the local pointer to > the memzone is not ever initialized. > > Fix it by using the same checks as dynfield_register(). > I.e if shared memory zone has not been looked up already, > then discover it. > > Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags") > Cc: olivier.matz@6wind.com > Signed-off-by: Stephen Hemminger Acked-by: Olivier Matz Thanks!