DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, robin.jarry@6wind.com, stephen@networkplumber.org,
	olivier.matz@6wind.com, Neil Horman <nhorman@tuxdriver.com>,
	Rosen Xu <rosen.xu@intel.com>,
	Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
	Luca Boccassi <bluca@debian.org>
Subject: Re: [dpdk-dev] [PATCH v3] usertools: fix pmdinfo parsing
Date: Wed, 4 Nov 2020 16:35:46 +0000
Message-ID: <20201104163546.GA65@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20201104155721.21627-1-david.marchand@redhat.com>

On Wed, Nov 04, 2020 at 04:57:21PM +0100, David Marchand wrote:
> This script inspects an ELF file (binary or shared library) and its
> linked dependencies by following DT_NEEDED tags.
> So far a simple librte_pmd prefix was used as a filter to only parse
> DPDK drivers dependencies.
> While the reason is not clear from the commitlog of the patch that
> introduced this filter, it was probably added for performance reasons,
> since going through all dependencies can be quite long.
> Testing with a DPDK built before the driver name changes:
> - running the script takes ~0.3s with the filter,
> - running the script takes ~9s without the filter,
> Now that we changed the driver library names, it becomes more difficult
> to identify only DPDK drivers, but we can just filter on the librte_
> prefix to identify DPDK libraries: the script later checks for the
> PMD_INFO_STRING string in .rodata and it is enough to differentiate the
> DPDK drivers from the other DPDK libraries.
> A debug message was logged for each inspected file, it gives no useful
> information and is removed.
> Fixes: a20b2c01a7a1 ("build: standardize component names and defines")
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Robin Jarry <robin.jarry@6wind.com>
> ---
> Changelog since v2:
> - revisited the issue and simplified to only filter on librte_ prefix,

Given you provided some original perf numbers of 0.3 vs 9 seconds above,
rather than leave us all in suspense :-), can you perhaps provide the
numbers for this version too.


  reply	other threads:[~2020-11-04 16:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-03 18:39 [dpdk-dev] [PATCH] " David Marchand
2020-11-03 19:27 ` Robin Jarry
2020-11-03 20:20   ` David Marchand
2020-11-03 23:54     ` Stephen Hemminger
2020-11-04  8:04       ` Olivier Matz
2020-11-04  8:06     ` Robin Jarry
2020-11-04  9:40 ` [dpdk-dev] [PATCH v2] " David Marchand
2020-11-04 10:32   ` Bruce Richardson
2020-11-04 10:42     ` David Marchand
2020-11-05 11:46   ` Xu, Rosen
2020-11-12 13:28   ` David Marchand
2020-11-04 15:57 ` [dpdk-dev] [PATCH v3] " David Marchand
2020-11-04 16:35   ` Bruce Richardson [this message]
2020-11-04 16:48     ` David Marchand
2020-11-05 11:49       ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201104163546.GA65@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=bluca@debian.org \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=nhorman@tuxdriver.com \
    --cc=olivier.matz@6wind.com \
    --cc=robin.jarry@6wind.com \
    --cc=rosen.xu@intel.com \
    --cc=stephen@networkplumber.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git