From: Bruce Richardson <bruce.richardson@intel.com> To: Gregory Etelson <getelson@nvidia.com> Cc: dev@dpdk.org, bluca@debian.org, christian.ehrhardt@canonical.com, david.marchand@redhat.com, ktraynor@redhat.com, matan@nvidia.com, rasland@nvidia.com, thomas@monjalon.net Subject: Re: [dpdk-dev] [PATCH v4] build: add pkg-config validation Date: Thu, 5 Nov 2020 13:17:37 +0000 Message-ID: <20201105131737.GC776@bricha3-MOBL.ger.corp.intel.com> (raw) In-Reply-To: <20201105123704.15791-1-getelson@nvidia.com> On Thu, Nov 05, 2020 at 02:37:03PM +0200, Gregory Etelson wrote: > DPDK relies on pkg-config(1) to provide correct parameters for > compiler and linker used in application build. > Inaccurate build parameters, produced by pkg-config from DPDK .pc > files could fail application build or cause unpredicted results > during application runtime. > > This patch validates host pkg-config utility and notifies about > known issues. > > Signed-off-by: Gregory Etelson <getelson@nvidia.com> > --- You can keep my ack from previous version. Acked-by: Bruce Richardson <bruce.richardson@intel.com> One small note is that I don't believe the 'exit $?' line at the end of the script is necessary, that is default shell behaviour. However, it probably doesn't hurt to have it explicitly there. > buildtools/pkg-config/meson.build | 11 ++++++++ > buildtools/pkg-config/pkgconfig-validate.sh | 29 +++++++++++++++++++++ > doc/guides/linux_gsg/sys_reqs.rst | 5 ++++ > 3 files changed, 45 insertions(+) > create mode 100755 buildtools/pkg-config/pkgconfig-validate.sh > > diff --git a/buildtools/pkg-config/meson.build b/buildtools/pkg-config/meson.build > index 5f19304289..4f907d7638 100644 > --- a/buildtools/pkg-config/meson.build > +++ b/buildtools/pkg-config/meson.build > @@ -53,3 +53,14 @@ This is required for a number of static inline functions in the public headers.' > # For static linking with dependencies as shared libraries, > # the internal static libraries must be flagged explicitly. > run_command(py3, 'set-static-linker-flags.py', check: true) > + > +pkgconf = find_program('pkg-config', 'pkgconf', required: false) > +if (pkgconf.found()) > + cmd = run_command('./pkgconfig-validate.sh', pkgconf.path(), > + check:false) > + if cmd.returncode() != 0 > + version = run_command(pkgconf, '--version') > + warning('invalid pkg-config version @0@'.format( > + version.stdout().strip())) > + endif > +endif > diff --git a/buildtools/pkg-config/pkgconfig-validate.sh b/buildtools/pkg-config/pkgconfig-validate.sh > new file mode 100755 > index 0000000000..f5479f999f > --- /dev/null > +++ b/buildtools/pkg-config/pkgconfig-validate.sh > @@ -0,0 +1,29 @@ > +#! /bin/sh > +# SPDX-License-Identifier: BSD-3-Clause > + > +if [ "$#" -ne 1 ]; then > + echo "$0: no pkg-config parameter" > + exit 1 > +fi > +PKGCONF="$1" > + > +# if pkgconf could not locate libdpdk.pc from existing PKG_CONFIG_PATH > +# check meson template instead > +# take the first located file > +pc_file=$(find "$MESON_BUILD_ROOT" -type f -name 'libdpdk.pc' -print -quit) > +if [ ! -f "$pc_file" ]; then > + echo "$0: cannot locate libdpdk.pc" > + exit 1 > +fi > +pc_dir=$(dirname "$pc_file") > +PKG_CONFIG_PATH="${PKG_CONFIG_PATH}:$pc_dir" > + > +# Statically linked private DPDK objects of form > +# -l:file.a must be positioned between --whole-archive … --no-whole-archive > +# linker parameters. > +# Old pkg-config versions misplace --no-whole-archive parameter and put it > +# next to --whole-archive. > +PKG_CONFIG_PATH="$PKG_CONFIG_PATH" \ > +"$PKGCONF" --libs --static libdpdk | \ > +grep -q 'whole-archive.*l:lib.*no-whole-archive' > +exit "$?" > diff --git a/doc/guides/linux_gsg/sys_reqs.rst b/doc/guides/linux_gsg/sys_reqs.rst > index 6ecdc04aa9..b67da05e13 100644 > --- a/doc/guides/linux_gsg/sys_reqs.rst > +++ b/doc/guides/linux_gsg/sys_reqs.rst > @@ -60,6 +60,11 @@ Compilation of the DPDK > > * Linux kernel headers or sources required to build kernel modules. > > + > +**Known Issues:** > + > +* pkg-config v0.27 supplied with RHEL-7 does not process correctly libdpdk.pc Libs.private section. > + > .. note:: > > Please ensure that the latest patches are applied to third party libraries > -- > 2.28.0 >
next prev parent reply other threads:[~2020-11-05 13:17 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-29 9:16 [dpdk-dev] [PATCH] " Gregory Etelson 2020-11-01 10:01 ` Thomas Monjalon 2020-11-01 12:06 ` Gregory Etelson 2020-11-02 6:45 ` [dpdk-dev] [PATCH v2] " Gregory Etelson 2020-11-02 12:11 ` Bruce Richardson 2020-11-02 19:39 ` Gregory Etelson 2020-11-02 19:34 ` [dpdk-dev] [PATCH v3] " Gregory Etelson 2020-11-03 10:09 ` Bruce Richardson 2020-11-04 8:38 ` Gregory Etelson 2020-11-05 12:37 ` [dpdk-dev] [PATCH v4] " Gregory Etelson 2020-11-05 13:17 ` Bruce Richardson [this message] 2020-11-13 13:38 ` David Marchand 2020-11-13 15:16 ` Gregory Etelson 2020-11-13 15:32 ` David Marchand 2020-11-17 18:17 ` [dpdk-dev] [PATCH] doc: notify bug in pkg-config v0.27 Gregory Etelson 2020-11-26 15:42 ` [dpdk-dev] [PATCH v2 1/1] doc: add pkg-config requirement for applications Thomas Monjalon 2020-11-26 16:24 ` Bruce Richardson 2020-11-26 16:38 ` Thomas Monjalon 2020-11-26 16:43 ` [dpdk-dev] [PATCH v3 " Thomas Monjalon 2020-11-26 16:46 ` Bruce Richardson 2020-11-27 0:59 ` Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201105131737.GC776@bricha3-MOBL.ger.corp.intel.com \ --to=bruce.richardson@intel.com \ --cc=bluca@debian.org \ --cc=christian.ehrhardt@canonical.com \ --cc=david.marchand@redhat.com \ --cc=dev@dpdk.org \ --cc=getelson@nvidia.com \ --cc=ktraynor@redhat.com \ --cc=matan@nvidia.com \ --cc=rasland@nvidia.com \ --cc=thomas@monjalon.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git