From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 53658A04DD;
	Thu,  5 Nov 2020 14:31:36 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id E8617BE8B;
	Thu,  5 Nov 2020 14:31:34 +0100 (CET)
Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com
 [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id B138BBE89
 for <dev@dpdk.org>; Thu,  5 Nov 2020 14:31:32 +0100 (CET)
Received: by mail-wr1-f68.google.com with SMTP id c17so1761362wrc.11
 for <dev@dpdk.org>; Thu, 05 Nov 2020 05:31:32 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google;
 h=date:from:to:cc:subject:message-id:references:mime-version
 :content-disposition:in-reply-to:user-agent;
 bh=uKQAYfFy+V4zJiYhNPEPWzjtsE4C1y9niJWNiF2HaiE=;
 b=LxO0kMdVrR/kYH93ErIw9i7wHk7SdVbFNY9YFZeR1kJfq6KfRHabTubtGBjxs4EEBr
 /t0OKdOqVg0I3rWxhyxkPXlFOzZLQnXJENnFg0gJUGvkVez/sykCjxmX2+D0IDfnVEih
 cOI7ZluzcfEYMb29IQbImIeeWKU1Dm2lu7Y2zL0ibaYwIKL8M0n0K4+iIu0APs6a/eZD
 V2CkFrhSQPvndo+iVixGwsFa5T3nvtyzv4Qx3c2lQFQ9E7M4yaWxR/xPbMr+VU7XL3Gu
 2BqZJxOTWGCiCEPfDf8J9h6UhpQpyC7M/l5In0y0lmrk+nwopa1N10icFsPGTtH2rd4G
 IMwg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:references
 :mime-version:content-disposition:in-reply-to:user-agent;
 bh=uKQAYfFy+V4zJiYhNPEPWzjtsE4C1y9niJWNiF2HaiE=;
 b=apG3HubGsggZjAmRU76d2RhRjW4nQKvCh6+hsyAr7mS4Ap6najYynQtRhSmmMuMFTD
 VYkVo6Zf7UdUZ6q/L/1pEv5fk4Sps2RIrujrfsA1kjZYV35kVKd6cnK4uAblfjLzOJqE
 hptrgHK7/AUyjfz0BBtZfeXZXJEG5ED7mb6BaWS9JabaEbcAa7WZ4zoFLJ3xhRkl/0sd
 d6S9N+EvEO9UGgo1FyFsMj6XOl6uXI1tU/rjyzwHDEspngsHjR7LVOc5pXJso+roYnTz
 6euHs5zukCnQ42QaZx8h3fRJ+bFkgOElRlpsOtRpPlaSSijA5E2Mkx7cHhT4Jzi0JkrO
 yq0A==
X-Gm-Message-State: AOAM533EBcCEfp3Eicdg4/ujKakepF9v0z4qKrVa53Vxb3k3YCC+D53r
 KNqalMx4oexdBsbN9Len3imZxQ==
X-Google-Smtp-Source: ABdhPJyCPt84kv6/qByITNI6mJoeF0AfkY+hlyDvmtmXmcfXUOBMopZYVhgAm3QBAfXPnuWWT/1WJA==
X-Received: by 2002:a5d:4dc7:: with SMTP id f7mr2875476wru.375.1604583092299; 
 Thu, 05 Nov 2020 05:31:32 -0800 (PST)
Received: from 6wind.com (2a01cb0c0005a600345636f7e65ed1a0.ipv6.abo.wanadoo.fr.
 [2a01:cb0c:5:a600:3456:36f7:e65e:d1a0])
 by smtp.gmail.com with ESMTPSA id a15sm2597837wrn.75.2020.11.05.05.31.31
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 05 Nov 2020 05:31:31 -0800 (PST)
Date: Thu, 5 Nov 2020 14:31:30 +0100
From: Olivier Matz <olivier.matz@6wind.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org, Jie Zhou <jizh@microsoft.com>,
 Ranjit Menon <ranjit.menon@intel.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>,
 Beilei Xing <beilei.xing@intel.com>,
 Bernard Iremonger <bernard.iremonger@intel.com>,
 Ori Kam <orika@nvidia.com>, Radu Nicolau <radu.nicolau@intel.com>,
 Akhil Goyal <akhil.goyal@nxp.com>,
 Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
 Jasvinder Singh <jasvinder.singh@intel.com>,
 Maxime Coquelin <maxime.coquelin@redhat.com>,
 Chenbo Xia <chenbo.xia@intel.com>, David Hunt <david.hunt@intel.com>
Message-ID: <20201105133130.GT1898@platinum>
References: <20200902183805.5421-1-dmitry.kozliuk@gmail.com>
 <20201030010126.17928-1-dmitry.kozliuk@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201030010126.17928-1-dmitry.kozliuk@gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Subject: Re: [dpdk-dev] [PATCH v3] cmdline: avoid name clash with Windows
	system types
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Oct 30, 2020 at 04:01:26AM +0300, Dmitry Kozlyuk wrote:
> cmdline_numtype member names clash with Windows system identifiers.
> Add RTE_ prefix to cmdline constants to avoid this and possible
> future conflicts.
> 
> Suggested-by: Ranjit Menon <ranjit.menon@intel.com>
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>

Acked-by: Olivier Matz <olivier.matz@6wind.com>