From: Dharmik Thakkar <dharmik.thakkar@arm.com>
To: Ruifeng Wang <ruifeng.wang@arm.com>,
Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, nd@arm.com, Dharmik Thakkar <dharmik.thakkar@arm.com>
Subject: [dpdk-dev] [PATCH 1/2] crypto/armv8: update meson build
Date: Thu, 5 Nov 2020 09:33:15 -0600 [thread overview]
Message-ID: <20201105153316.27918-1-dharmik.thakkar@arm.com> (raw)
With pkg-config support available within AArch64crypto library,
meson option 'armv8_crypto_dir' can be removed.
PKG_CONFIG_PATH environment variable should be set appropriately
to use the crypto library.
Refer [1] for build instructions.
[1]
https://doc.dpdk.org/guides/cryptodevs/armv8.html
Suggested-by: Thomas Monjalon <thomas@monjalon.net>
Signed-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
drivers/crypto/armv8/meson.build | 19 ++++---------------
meson_options.txt | 2 --
2 files changed, 4 insertions(+), 17 deletions(-)
diff --git a/drivers/crypto/armv8/meson.build b/drivers/crypto/armv8/meson.build
index c445c5bd3dfd..3289a2adcac5 100644
--- a/drivers/crypto/armv8/meson.build
+++ b/drivers/crypto/armv8/meson.build
@@ -1,24 +1,13 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2019 Arm Limited
-path = get_option('armv8_crypto_dir')
-if path == ''
+dep = dependency('libAArch64crypto', required: false)
+if not dep.found()
build = false
- reason = 'missing dependency, "armv8_crypto"'
+ reason = 'missing dependency, "libAArch64crypto"'
subdir_done()
endif
-inc_dir = path
-
-lib = cc.find_library('libAArch64crypto', dirs: [path], required: false)
-if not lib.found()
- build = false
- reason = 'missing dependency, "AArch64crypto"'
- subdir_done()
-else
- ext_deps += lib
- includes += include_directories(inc_dir)
-endif
-
+ext_deps += dep
deps += ['bus_vdev']
sources = files('rte_armv8_pmd.c', 'rte_armv8_pmd_ops.c')
diff --git a/meson_options.txt b/meson_options.txt
index 9bf18ab6b1c9..e384e6dbb29e 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -1,7 +1,5 @@
# Please keep these options sorted alphabetically.
-option('armv8_crypto_dir', type: 'string', value: '',
- description: 'path to the armv8_crypto library installation directory')
option('disable_drivers', type: 'string', value: '',
description: 'Comma-separated list of drivers to explicitly disable.')
option('drivers_install_subdir', type: 'string', value: 'dpdk/pmds-<VERSION>',
--
2.17.1
next reply other threads:[~2020-11-05 15:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 15:33 Dharmik Thakkar [this message]
2020-11-05 15:33 ` [dpdk-dev] [PATCH 2/2] doc: update build guide for armv8 crypto PMD Dharmik Thakkar
2020-11-06 1:39 ` Ruifeng Wang
2020-11-05 16:11 ` [dpdk-dev] [PATCH 1/2] crypto/armv8: update meson build Bruce Richardson
2020-11-13 9:29 ` Thomas Monjalon
2020-11-13 9:39 ` Thomas Monjalon
2020-11-06 1:40 ` Ruifeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201105153316.27918-1-dharmik.thakkar@arm.com \
--to=dharmik.thakkar@arm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=nd@arm.com \
--cc=ruifeng.wang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).