From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 9B740A0521;
Thu, 5 Nov 2020 22:17:59 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 38E0C2BD3;
Thu, 5 Nov 2020 22:17:38 +0100 (CET)
Received: from mx1.tetrasec.net (mx1.tetrasec.net [66.245.176.36])
by dpdk.org (Postfix) with ESMTP id 0161323D;
Thu, 5 Nov 2020 22:17:35 +0100 (CET)
Received: from mx1.tetrasec.net (mail.local [127.0.0.1])
by mx1.tetrasec.net (Postfix) with ESMTP id 959C213C5E2;
Thu, 5 Nov 2020 21:17:33 +0000 (UTC)
Received: from ncopa-desktop.lan (67.63.200.37.customer.cdi.no [37.200.63.67])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest
SHA256) (No client certificate requested)
(Authenticated sender: n@tanael.org)
by mx1.tetrasec.net (Postfix) with ESMTPSA id 2A14A13C5E1;
Thu, 5 Nov 2020 21:17:32 +0000 (UTC)
From: Natanael Copa <ncopa@alpinelinux.org>
To: dev@dpdk.org, Wenzhuo Lu <wenzhuo.lu@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>
Cc: Natanael Copa <ncopa@alpinelinux.org>,
stable@dpdk.org
Date: Thu, 5 Nov 2020 22:17:09 +0100
Message-Id: <20201105211716.25181-2-ncopa@alpinelinux.org>
X-Mailer: git-send-email 2.29.2
In-Reply-To: <20201105211716.25181-1-ncopa@alpinelinux.org>
References: <18966392.1bK43UoomU@xps>
<20201105211716.25181-1-ncopa@alpinelinux.org>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Subject: [dpdk-dev] [PATCH v4 1/8] app/testpmd: fix uint build error with
musl libc
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Improve portability by avoid use non-standard 'uint'.
Use uint8_t for hash_key_len as rss_key_len is a uint8_t type.
This solves following build error when building with musl libc:
In file included from ../app/test-pmd/cmdline.c:74:
../app/test-pmd/testpmd.h:813:29: error: unknown type name 'uint'; did
you mean 'int'?
813 | uint8_t *hash_key, uint hash_key_len);
| ^~~~
| int
Fixes: 8205e241b2b0 ("app/testpmd: add missing type to RSS hash commands"=
)
Cc: stable@dpdk.org
Signed-off-by: Natanael Copa <ncopa@alpinelinux.org>
---
app/test-pmd/config.c | 2 +-
app/test-pmd/testpmd.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 755d1dfc9..8ec091077 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -3015,7 +3015,7 @@ port_rss_hash_conf_show(portid_t port_id, int show_=
rss_key)
=20
void
port_rss_hash_key_update(portid_t port_id, char rss_type[], uint8_t *has=
h_key,
- uint hash_key_len)
+ uint8_t hash_key_len)
{
struct rte_eth_rss_conf rss_conf;
int diag;
diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h
index 519d5517e..1cb6a6d04 100644
--- a/app/test-pmd/testpmd.h
+++ b/app/test-pmd/testpmd.h
@@ -945,7 +945,7 @@ int set_vf_rate_limit(portid_t port_id, uint16_t vf, =
uint16_t rate,
=20
void port_rss_hash_conf_show(portid_t port_id, int show_rss_key);
void port_rss_hash_key_update(portid_t port_id, char rss_type[],
- uint8_t *hash_key, uint hash_key_len);
+ uint8_t *hash_key, uint8_t hash_key_len);
int rx_queue_id_is_invalid(queueid_t rxq_id);
int tx_queue_id_is_invalid(queueid_t txq_id);
void setup_gro(const char *onoff, portid_t port_id);
--=20
2.29.2