From: Ciara Power <ciara.power@intel.com>
To: dev@dpdk.org
Cc: stephen@networkplumber.org, bruce.richardson@intel.com,
Ciara Power <ciara.power@intel.com>,
andriy.berestovskyy@caviumnetworks.com, thomas@monjalon.net,
stable@dpdk.org
Subject: [dpdk-dev] [PATCH] usertools/cpu_layout: fix code to be pep8 style compliant
Date: Fri, 6 Nov 2020 12:40:53 +0000 [thread overview]
Message-ID: <20201106124053.641946-1-ciara.power@intel.com> (raw)
The pycodestyle tool flagged the following issues, which are now fixed.
$ pycodestyle cpu_layout.py
cpu_layout.py:18:5: E722 do not use bare 'except'
cpu_layout.py:62:14: E231 missing whitespace after ','
Fixes: deb87e6777c0 ("usertools: use sysfs for CPU layout")
Fixes: c9208f1dc967 ("usertools: fix CPU layout with python 3")
Cc: andriy.berestovskyy@caviumnetworks.com
Cc: thomas@monjalon.net
Cc: stable@dpdk.org
Signed-off-by: Ciara Power <ciara.power@intel.com>
---
usertools/cpu_layout.py | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/usertools/cpu_layout.py b/usertools/cpu_layout.py
index cc39638213..891b9238fa 100755
--- a/usertools/cpu_layout.py
+++ b/usertools/cpu_layout.py
@@ -15,8 +15,6 @@
fd = open("{}/cpu{}/topology/core_id".format(base_path, cpu))
except IOError:
continue
- except:
- break
core = int(fd.read())
fd.close()
fd = open("{}/cpu{}/topology/physical_package_id".format(base_path, cpu))
@@ -59,7 +57,7 @@
for c in cores:
output = "Core %s" % str(c).ljust(max_core_id_len)
for s in sockets:
- if (s,c) in core_map:
+ if (s, c) in core_map:
output += " " + str(core_map[(s, c)]).ljust(max_core_map_len)
else:
output += " " * (max_core_map_len + 1)
--
2.25.1
next reply other threads:[~2020-11-06 12:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 12:40 Ciara Power [this message]
2020-11-13 14:41 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201106124053.641946-1-ciara.power@intel.com \
--to=ciara.power@intel.com \
--cc=andriy.berestovskyy@caviumnetworks.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).