From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E6480A0527; Mon, 9 Nov 2020 17:20:34 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C3CC86A1C; Mon, 9 Nov 2020 17:20:33 +0100 (CET) Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id EE1966004 for <dev@dpdk.org>; Mon, 9 Nov 2020 17:20:31 +0100 (CET) Received: by mail-pf1-f194.google.com with SMTP id x13so8602781pfa.9 for <dev@dpdk.org>; Mon, 09 Nov 2020 08:20:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YmeAhhG8CUZk0vg9mqQADlJlK8ArOJUDdIGP+oEjQ0w=; b=cOmYK+1ZoI+8wxkFkCytoT8Cijoz4fi3UeexTjjvaYwxm9fnqyq+BnZ5j5Y+FznvHL LdFZejyVyhPzrfEui8sivvC8Fng1GyYK+EES4fdFl/tX99dxB9Hxu5NK5zgJbp87jyX5 IYnoX+BK4Y/rfBvVMThhZ3P5FgS31j2nno1vbKKxaCv1mlm9Hmu8qsE3s9lZ/qq6D0PR ry1OaqrPNMKba5d3O3D70XkT1P8TXfOL8TlUTszSOfgL9CCUAwMs8sRVu9s/6oXGV3eP bXbBuePhvjDG8Ts6l2dJDCXXSN1q9M7Zxf23+I2nETGYsT8hUXltpS35yicQN6l9ZRMF E44A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YmeAhhG8CUZk0vg9mqQADlJlK8ArOJUDdIGP+oEjQ0w=; b=XI5jQaqjduSAwH/7OO6mMc2q9Er3704w6dxtcrCARgVLb7UsoDpVShnQEGdi5c2pCk F5b0R+N57lFICzQhjcR5FxhvHsl6PHljzSJ68tkByglK0AsQkNYvduolF8gdr+XfMJbS PQSl+OsKMIGlSapylveStFrdVYJIRSIS1cGFFge1c4casLB/WxpCEkvp5eXnXXG+urTz 7fWf7OIiWiRKiwJOcAFos4w3zHhmpW9xpD4IWZ7F7iJTT9Y+1Fjdqhw/lG+xmsvo2JSc UlpgXuwLqNIQu1XLLFOL0Jjpgbv99ivW9JpWXGheLaW+NsIF+HUDDb2b39SH88UfiETx 0TQA== X-Gm-Message-State: AOAM533lmiRkzYZF7faNSwSkvP4QTnhrCPjAFKJHUgWBW6Vm9uXK0HfJ y6SqmvLKsx2V9QvRNoQYWbOT+RSiO5/D0GG/ X-Google-Smtp-Source: ABdhPJxH63ImDokRGLbmIJMUYHD83er88dXeuBLGZ/AJpuWhf5Kb2tC9bvUJw5FZe57UYmWAdxMRHQ== X-Received: by 2002:a17:90b:3d6:: with SMTP id go22mr84792pjb.53.1604938830041; Mon, 09 Nov 2020 08:20:30 -0800 (PST) Received: from hermes.local (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id c11sm10180895pgl.20.2020.11.09.08.20.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 08:20:29 -0800 (PST) Date: Mon, 9 Nov 2020 08:20:21 -0800 From: Stephen Hemminger <stephen@networkplumber.org> To: Bruce Richardson <bruce.richardson@intel.com> Cc: David Marchand <david.marchand@redhat.com>, Thomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>, Luca Boccassi <bluca@debian.org>, Gaetan Rivet <grive@u256.net> Message-ID: <20201109082021.4d09d9cc@hermes.local> In-Reply-To: <20201109161045.GK831@bricha3-MOBL.ger.corp.intel.com> References: <20200922143202.8755-1-stephen@networkplumber.org> <20201105223602.5965-1-stephen@networkplumber.org> <20201105223602.5965-2-stephen@networkplumber.org> <20201109134931.GG831@bricha3-MOBL.ger.corp.intel.com> <20201109075440.44130509@hermes.local> <CAJFAV8zKLwphemj+faU8vXNezAirP1wx=u3ebPBub9WKDk5WjA@mail.gmail.com> <20201109160548.GJ831@bricha3-MOBL.ger.corp.intel.com> <CAJFAV8ypJ6dayszBR3d8F0gXaox4V-8JtOGqY4Lz0S6DHKK_kg@mail.gmail.com> <20201109161045.GK831@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v9 1/6] eal: replace usage of blacklist/whitelist in enum X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Mon, 9 Nov 2020 16:10:45 +0000 Bruce Richardson <bruce.richardson@intel.com> wrote: > On Mon, Nov 09, 2020 at 05:07:16PM +0100, David Marchand wrote: > > On Mon, Nov 9, 2020 at 5:06 PM Bruce Richardson > > <bruce.richardson@intel.com> wrote: > > > > > > On Mon, Nov 09, 2020 at 05:03:06PM +0100, David Marchand wrote: > > > > On Mon, Nov 9, 2020 at 4:55 PM Stephen Hemminger > > > > <stephen@networkplumber.org> wrote: > > > > > > This patch causes build failures which persist until patch 3, because of > > > > > > these deprecations. I think you need to define the backward-compatibility > > > > > > macros here, but only mark them deprecated at the end of the set. > > > > > > > > > > > > /Bruce > > > > > > > > > > Is building without warnings in every step that important? > > > > > The previous patch series for master/slave had the same effect > > > > > > > > Thomas fixed it while applying. > > > > https://patchwork.dpdk.org/cover/80987/#122107 > > > > > > > > > > > In this case I believe the below needs to be applied to patch 1, and then > > > the inverse of it set as patch 4 to mark the compatibility macros as > > > deprecated. > > > > Or just squash the patches and be done with it, like I already commented. > > No one cares about this series anyway. > > > Ok, yep, that's fine too. > > /Bruce Agree, go ahead and combine the patches. They were split for testing and review.