DPDK patches and discussions
 help / color / mirror / Atom feed
From: Gaëtan Rivet <grive@u256.net>
To: Hemant Agrawal <hemant.agrawal@nxp.com>,
	Sachin Saxena <sachin.saxena@oss.nxp.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] bus/dpaa: optimize device name parsing
Date: Mon, 9 Nov 2020 12:44:50 +0100
Message-ID: <20201109114450.y7iq6ec2hmn4zesv@u256.net> (raw)
In-Reply-To: <20201109113147.962882-1-grive@u256.net>

On 09/11/20 12:31 +0100, Gaetan Rivet wrote:
> Device name parsing is done on all buses during device iterations at
> either EAL or ethdev levels.
> 
> When a bus implements device name parsing slowly, all iterations are
> impacted. Efficient implementation is important.
> 
> The DPAA bus device name parsing has two issues: it allocates dynamic
> memory and uses snprintf without a real need for it. Both can be
> avoided, which improves the parsing performance.
> 
> The function is also simpler and shorter.
> 
> Signed-off-by: Gaetan Rivet <grive@u256.net>
> ---

Sorry I meant to annotate this patch before sending.

Please note that I could not test with a real DPAA bus. There are some
string offsets that should be correct but the parsing still needs to
be tested.

Cheers,
-- 
Gaëtan

  reply	other threads:[~2020-11-09 11:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-09 11:31 Gaetan Rivet
2020-11-09 11:44 ` Gaëtan Rivet [this message]
2020-11-09 11:58 ` David Marchand
2020-11-09 13:36   ` Gaëtan Rivet
2020-11-09 13:37 ` [dpdk-dev] [PATCH v2] " Gaetan Rivet
2021-01-15 11:16   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201109114450.y7iq6ec2hmn4zesv@u256.net \
    --to=grive@u256.net \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=sachin.saxena@oss.nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git