From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 904BCA0527; Mon, 9 Nov 2020 17:10:59 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 383215F18; Mon, 9 Nov 2020 17:10:58 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 5EEFA5F13 for ; Mon, 9 Nov 2020 17:10:55 +0100 (CET) IronPort-SDR: KhhVZVbyhwMTM9nFqMSkcWkXeMJC6wqyP6SYX5xLQXKOtP6gL5YOODLr9WwU3bep6iCKuCxqzz yqWDoi0AJRCQ== X-IronPort-AV: E=McAfee;i="6000,8403,9800"; a="157608490" X-IronPort-AV: E=Sophos;i="5.77,463,1596524400"; d="scan'208";a="157608490" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2020 08:10:53 -0800 IronPort-SDR: WNAKs8dae+LMiTPfght8q4Q4tqbsu7kxkdJmTqqFZ6koVlSRGe6YQd6q6F+wkx9tENEqhFLbgF ZXK/qextFzFA== X-IronPort-AV: E=Sophos;i="5.77,463,1596524400"; d="scan'208";a="540907197" Received: from bricha3-mobl.ger.corp.intel.com ([10.214.194.11]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 09 Nov 2020 08:10:50 -0800 Date: Mon, 9 Nov 2020 16:10:45 +0000 From: Bruce Richardson To: David Marchand Cc: Stephen Hemminger , Thomas Monjalon , dev , Luca Boccassi , Gaetan Rivet Message-ID: <20201109161045.GK831@bricha3-MOBL.ger.corp.intel.com> References: <20200922143202.8755-1-stephen@networkplumber.org> <20201105223602.5965-1-stephen@networkplumber.org> <20201105223602.5965-2-stephen@networkplumber.org> <20201109134931.GG831@bricha3-MOBL.ger.corp.intel.com> <20201109075440.44130509@hermes.local> <20201109160548.GJ831@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v9 1/6] eal: replace usage of blacklist/whitelist in enum X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Nov 09, 2020 at 05:07:16PM +0100, David Marchand wrote: > On Mon, Nov 9, 2020 at 5:06 PM Bruce Richardson > wrote: > > > > On Mon, Nov 09, 2020 at 05:03:06PM +0100, David Marchand wrote: > > > On Mon, Nov 9, 2020 at 4:55 PM Stephen Hemminger > > > wrote: > > > > > This patch causes build failures which persist until patch 3, because of > > > > > these deprecations. I think you need to define the backward-compatibility > > > > > macros here, but only mark them deprecated at the end of the set. > > > > > > > > > > /Bruce > > > > > > > > Is building without warnings in every step that important? > > > > The previous patch series for master/slave had the same effect > > > > > > Thomas fixed it while applying. > > > https://patchwork.dpdk.org/cover/80987/#122107 > > > > > > > > In this case I believe the below needs to be applied to patch 1, and then > > the inverse of it set as patch 4 to mark the compatibility macros as > > deprecated. > > Or just squash the patches and be done with it, like I already commented. > No one cares about this series anyway. > Ok, yep, that's fine too. /Bruce