From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 34106A04DD; Tue, 10 Nov 2020 17:40:18 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 95ADCF64; Tue, 10 Nov 2020 17:40:16 +0100 (CET) Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id BC86CDED for ; Tue, 10 Nov 2020 17:40:15 +0100 (CET) Received: by mail-pf1-f194.google.com with SMTP id c66so6204840pfa.4 for ; Tue, 10 Nov 2020 08:40:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Nj5XcJqHxUPt1FIKWAvHshUf9Y1AHjiSMnJEdwahx7U=; b=MIbLLgQxEUqzLnKnIJojbG14DuiFH1MA722qy8x1Km4BpsaKu9mce4l1IU95pySmqv 1lqKbeNditMheR0rbOE+a+sj6aPg3on6Zbr79LaX11GWvlpOSqckIbBEwICNOFdl4/Ru NiUZzAXLce0pkEKo/4+cxHBpmkyTg7T8WnZ85MUIhcCC3LV/D3VpQIK69n4WIbwfRvXk hCVCSv9ZPvam++kiF8kBQY7wDlnxNBsW8x0tJZyOqlzc1k20WQDhkmEGcv4OkNfgNL7p tkOqTW2oJoOtG+qRIu30iTh8qj/Gd1R9L4DNu/RVlAaifXGyqA1y4Ep6eMdKWvClxddo q0mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Nj5XcJqHxUPt1FIKWAvHshUf9Y1AHjiSMnJEdwahx7U=; b=Ig1B7+78THYuOOVNvujC0nAZ1d0tgb+rSzESyfL8fB34zGYKUGrciCVnAM3dhBAj9j rK0yI2Ia0hlXylWri/8A3q0Cd6ec4z1jEV9LfYZZ1Fk7e3PD8ZxyzFG/GoLVmSWjzAwF pCcoEJ2ZFNy7Dew7JjIlZ1U7uKV0ry7pNKDBmcyDwaGb9Cx1jE59PKHL/QCafFmXEuhw 9yR14Pz5BLOJlffeu4dxkNIzmUz/aDDTUP5GGm3t68o5ipswUVSWf5cL8h+4JzRKH55w jRn+fRJkMnOAJy4R0btXniKD0TDx9RuDN/X/eVZnX9EcXqKsvpvr3XibEFgHbj+K0WHr Egyw== X-Gm-Message-State: AOAM531kQHomf4QfsoH0O9FNbHUxVeGXtnx3wvBja+LAXp9K0RthOLDt OXK4eVb2BY0FtaCQ6IslFN0jJA== X-Google-Smtp-Source: ABdhPJw1u/uUM9pQP71fqD2l0uuKfnU6J+cGIOGvufZ2sqZSZK8QZdjMNrgy5ilDCsXzWAAVmC6wxg== X-Received: by 2002:a63:eb4a:: with SMTP id b10mr17180635pgk.416.1605026413780; Tue, 10 Nov 2020 08:40:13 -0800 (PST) Received: from hermes.local (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id r73sm15121392pfc.20.2020.11.10.08.40.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2020 08:40:13 -0800 (PST) Date: Tue, 10 Nov 2020 08:40:10 -0800 From: Stephen Hemminger To: Luca Boccassi Cc: dev@dpdk.org Message-ID: <20201110084010.7b896efb@hermes.local> In-Reply-To: <6bc3f5b2b1814fb1824c6d4864155377d9413691.camel@debian.org> References: <20200922143202.8755-1-stephen@networkplumber.org> <20201105223602.5965-1-stephen@networkplumber.org> <20201105223602.5965-2-stephen@networkplumber.org> <6bc3f5b2b1814fb1824c6d4864155377d9413691.camel@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v9 1/6] eal: replace usage of blacklist/whitelist in enum X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 10 Nov 2020 12:33:48 +0000 Luca Boccassi wrote: > On Thu, 2020-11-05 at 14:35 -0800, Stephen Hemminger wrote: > > This patch renames the enum values in the EAL include files. > > As a backward compatible temporary migration tool, define > > a replacement mapping for old values. > > > > The old names relating to blacklist and whitelist are replaced > > by block list and allow list, but applications may be using the > > older compatibility macros. To help with conversion to new names > > cause a message when the compatibility names are used. > > > > Signed-off-by: Stephen Hemminger > > Acked-by: Luca Boccassi > > Acked-by: Gaetan Rivet > > --- > > lib/librte_eal/common/eal_common_devargs.c | 14 +++++++------- > > lib/librte_eal/include/rte_bus.h | 10 ++++++++-- > > lib/librte_eal/include/rte_dev.h | 10 ++++++++-- > > lib/librte_eal/include/rte_devargs.h | 10 ++++++++-- > > 4 files changed, 31 insertions(+), 13 deletions(-) > > <..> > > > diff --git a/lib/librte_eal/include/rte_devargs.h b/lib/librte_eal/include/rte_devargs.h > > index 898efa0d667b..296f19324fae 100644 > > --- a/lib/librte_eal/include/rte_devargs.h > > +++ b/lib/librte_eal/include/rte_devargs.h > > @@ -29,11 +29,17 @@ extern "C" { > > * Type of generic device > > */ > > enum rte_devtype { > > - RTE_DEVTYPE_WHITELISTED_PCI, > > - RTE_DEVTYPE_BLACKLISTED_PCI, > > + RTE_DEVTYPE_ALLOWED, > > + RTE_DEVTYPE_BLOCKED, > > RTE_DEVTYPE_VIRTUAL, > > Any particular reason to drop the _PCI suffix from the enums and > command line parameters? Does it apply to more than PCI devices > nowadays? Yes, block/allow also works for VMBus devices and and I think other busses use it as well.