From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA823A0526; Tue, 10 Nov 2020 12:21:00 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BAE262B9D; Tue, 10 Nov 2020 12:20:59 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 5ABCFF90; Tue, 10 Nov 2020 12:20:56 +0100 (CET) IronPort-SDR: BeI5u1M226x0YqNUDuvgHtpYCTlv5gZNlBn8fa+vC3lJRaCPwYpMQNgbx9fYh2oBbuNbSAWsyt yg5uVO6QGb4w== X-IronPort-AV: E=McAfee;i="6000,8403,9800"; a="149233510" X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="149233510" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2020 03:20:54 -0800 IronPort-SDR: zydUMRhfozzoB8OTx+LwPaN3sA2zI4U3ZU+I5XBFFBefIEykwAfUhTOLvNdGgFoDCTFbNg+BaN KaCNJXtMEs7A== X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="531172439" Received: from bricha3-mobl.ger.corp.intel.com ([10.213.241.186]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 10 Nov 2020 03:20:50 -0800 Date: Tue, 10 Nov 2020 11:20:44 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, ferruh.yigit@intel.com, david.marchand@redhat.com, stable@dpdk.org, Luca Boccassi Message-ID: <20201110112044.GD1641@bricha3-MOBL.ger.corp.intel.com> References: <20201109210009.919129-1-thomas@monjalon.net> <20201110101419.GB1641@bricha3-MOBL.ger.corp.intel.com> <2429206.vUhvlFYDAN@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2429206.vUhvlFYDAN@thomas> Subject: Re: [dpdk-dev] [PATCH 1/1] devtools: fix build test config inheritance from env X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 10, 2020 at 11:45:52AM +0100, Thomas Monjalon wrote: > 10/11/2020 11:14, Bruce Richardson: > > On Mon, Nov 09, 2020 at 10:00:08PM +0100, Thomas Monjalon wrote: > > > PKG_CONFIG_PATH is specific to each target, so it must be empty > > > before configuring each build from the file according to DPDK_TARGET. > > > Inheriting a default PKG_CONFIG_PATH for all targets does not make sense > > > and is prone to confusion. > > > > > > DPDK_MESON_OPTIONS might take a global initial value from environment > > > to customize a build test from the shell. Example: > > > DPDK_MESON_OPTIONS="b_lto=true" > > > Some target-specific options can be added in the configuration file: > > > DPDK_MESON_OPTIONS="$DPDK_MESON_OPTIONS kernel_dir=$MYKERNEL" > > > > > > Fixes: 272236741258 ("devtools: load target-specific compilation environment") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Thomas Monjalon > > > --- > > > > Patch looks fine, but I think the log (and comments in the code too, > > perhaps) should make it clear that the PKG_CONFIG_PATH can be set in the > > local config file, to make it available to the script. > > OK, I'll look at improving the "doc". > We could also provide a template for the config file. > Acked-by: Bruce Richardson