From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8479CA04B1; Tue, 10 Nov 2020 15:10:59 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4C52B5A8C; Tue, 10 Nov 2020 15:10:03 +0100 (CET) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id 238895A8C for ; Tue, 10 Nov 2020 15:10:00 +0100 (CET) Received: by mail-wm1-f66.google.com with SMTP id a65so3133975wme.1 for ; Tue, 10 Nov 2020 06:10:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TlKWmetg7poIuCtYNC1Yhq8ev+fT2UaNBDjwBbwkMlk=; b=KeE8nixOa4VOh15YYWvw2rValPpDD4yY52UdDzRhnRHTHLR0VSgqZ7FDL/6ByxlCa8 41EPF79bW2NKzNrHKS3IM0NQx9R7PLcl6/C2haO2PLTrAfsvfg6PuD2SW0F3k1WZz30l CcEIe715GDaxPX4JrVq0aSGvIQOYG7M73jLmSgy9Ikghl4u5j3gcJ3cMhwMxCrNr7WSq wTeTJ8ywsdDu4WCDSlhDyPWccuuAKPgBbJPGdlexLrEUUhVw0FeRbWy9nkAiSu6Yj+ke EjB1dYPuHvPEyNtvH37mCShAO8dKbQK81amS3vTQMLTjkbDlUQfasV/9ak8g/hT4jnGI UQvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TlKWmetg7poIuCtYNC1Yhq8ev+fT2UaNBDjwBbwkMlk=; b=VPJCJovXqAUe5cs7HusgffUreBu5kdcIy4Yz5eOHXXEkLSFfh40r/kSymfXYJNkNF/ 2PppYwZgHg4lWh1/FqeWWEBeqdvdUmVlKiw00DRVEEl4MXQ5tA9pgj8gce7TZslJukij JSGBmPLKM0HhF6gHAsA0+kLs194xH3hVm7aX7SMondVmoWEa0d3Qo56vygRim6p63OgN hkAK0dsHSNc9rXpO1KkT/++Phj2wMRiT0vMHSNESzysZpqBWvQJwjzjZqImirech38Mb pMzrgH0F8t8UelFKy66ldR8QIZwkPSA5VQpXkJKs/zTyeYLtZ50SlXVrKIl5qpbAXSSx layg== X-Gm-Message-State: AOAM530MsT8GhDhu5FbIu+l1pkJch4s2gf6C2mgamiLKpGkUGIdQzpcP sQHt76SfvvzOrANjrR06S9GXRA== X-Google-Smtp-Source: ABdhPJyXwnU/1gAVD87HpjqYB8EOk97PTBChgVY7vLMng81Jg/LVVltRykGKkH9WgeDuDtqllWyZww== X-Received: by 2002:a1c:c30a:: with SMTP id t10mr4828676wmf.183.1605017398937; Tue, 10 Nov 2020 06:09:58 -0800 (PST) Received: from bolet.dev.6wind.com. (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id y187sm3112158wmg.33.2020.11.10.06.09.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2020 06:09:58 -0800 (PST) From: Maxime Leroy To: Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Olivier Matz Cc: dev@dpdk.org, Didier Pallard Date: Tue, 10 Nov 2020 15:09:37 +0100 Message-Id: <20201110140938.15046-4-maxime.leroy@6wind.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201110140938.15046-1-maxime.leroy@6wind.com> References: <20201110140938.15046-1-maxime.leroy@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 3/4] net/mlx5: fix Rx descriptor status returned value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Didier Pallard Two bugs in rx_queue_count function: - One entry may contain several segments, so 'used' must be multiplied by number of segments per entry to properly reflect the queue usage. - rx_queue_count returns the number of entries used in queue, so it ranges from 0 to max number of entries in queue, not this number minus one. Fixes: 8788fec1f269 ("net/mlx5: implement descriptor status API") Signed-off-by: Didier Pallard --- drivers/net/mlx5/mlx5_rxtx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c index 511003d1..2cabd650 100644 --- a/drivers/net/mlx5/mlx5_rxtx.c +++ b/drivers/net/mlx5/mlx5_rxtx.c @@ -463,6 +463,7 @@ rx_queue_count(struct mlx5_rxq_data *rxq) struct rxq_zip *zip = &rxq->zip; volatile struct mlx5_cqe *cqe; const unsigned int cqe_n = (1 << rxq->cqe_n); + const unsigned int sges_n = (1 << rxq->sges_n); const unsigned int cqe_cnt = cqe_n - 1; unsigned int cq_ci, cq_end, cq_cur; unsigned int used; @@ -491,7 +492,7 @@ rx_queue_count(struct mlx5_rxq_data *rxq) used += n; cqe = &(*rxq->cqes)[cq_ci & cqe_cnt]; } - used = RTE_MIN(used, (1U << rxq->elts_n) - 1); + used = RTE_MIN(used * sges_n, 1U << rxq->elts_n); return used; } -- 2.27.0