From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96842A04DD; Tue, 10 Nov 2020 18:42:51 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0414EF90; Tue, 10 Nov 2020 18:42:49 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 3FFDDF64; Tue, 10 Nov 2020 18:42:46 +0100 (CET) IronPort-SDR: 7PvkNgQzcSg11aQCg+Y0N6/xKzHxInemSjjvGaQf+WbuK+F+p7CxocEYbHQU9/I9hu8wJyYQU2 is5LnSID/TLw== X-IronPort-AV: E=McAfee;i="6000,8403,9801"; a="149868024" X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="149868024" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2020 09:42:36 -0800 IronPort-SDR: XC8X2hHeUy1TES6IlFTHY1sxpT3wcodds9IMrFgFHUFj/5OWWxV5e4+4bN6M5H1MJnjEH43YGW 6jmpstv68Rbg== X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="541420752" Received: from bricha3-mobl.ger.corp.intel.com ([10.213.241.186]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 10 Nov 2020 09:42:35 -0800 Date: Tue, 10 Nov 2020 17:42:31 +0000 From: Bruce Richardson To: David Marchand Cc: dev , dpdk stable , Thomas Monjalon Message-ID: <20201110174231.GR1641@bricha3-MOBL.ger.corp.intel.com> References: <20201110170809.1309043-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] install: fix flattening of examples directory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 10, 2020 at 06:33:03PM +0100, David Marchand wrote: > On Tue, Nov 10, 2020 at 6:08 PM Bruce Richardson > wrote: > > > > By installing the examples one-by-one in a loop in the examples > > meson.build file we effectively flatted out the structure of the examples > > flattened* > > > folder and omitted some common and shared subfolders that were never > > directly built. Instead, we can remove the loop and just have the whole > > "examples" folder installed as-is in a single statement, preserving its > > directory structure, and thereby fixing the build of a number of the > > examples. > > It seems wrong to provide all examples without looking at all_examples. > We would provide examples that can't link against the available dpdk libraries. > Yes, let me think on this a bit about what is best to do, or how to manage it. I'll try and get a v2 tomorrow. For older releases with "make" buildsystem, did we provide an installation method for examples, because I can't think of how we handled this fact there?