From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CEA0DA09D2; Wed, 11 Nov 2020 09:16:11 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9ECE25916; Wed, 11 Nov 2020 09:15:45 +0100 (CET) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id F0BD35913 for ; Wed, 11 Nov 2020 09:15:42 +0100 (CET) Received: by mail-wm1-f68.google.com with SMTP id h2so1426551wmm.0 for ; Wed, 11 Nov 2020 00:15:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emumba-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=zlM9Wry19VUPUSww91VmY9rkU/sQzcIcwnaouWkfus0=; b=LgbYjKaWTZ94rxMBhixdobKcZG1Jcsc/QrSyrNbfdh2l0E5uQafO2ZAHHwSiAYbS1n sS7E+v0pFHM3/wSZJI0FWIgT/PACeqSEeBjPysCnEZgxtb6KD7ILHNea8sMZ7Sgy4u1L 4cdQ4q+k5w/RRzODjS+TdwVCXX3F4A7bC59w44Hwt7hTOrpPpZOTcXP43SQ4YL5ImED8 0DYT2dPH+C32w3cfIv0Xb+dc2dG0TxRRXZz/NxJ0lY4EZSsTiZ4CWrgkDFt0WLBEiade M34Sxo0DFMi2Ifzd349QamG1tBfIQOJcvna3MZJ8gWsZh0P9zzcrZ4Cvp5Lrki3vVypk G5nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=zlM9Wry19VUPUSww91VmY9rkU/sQzcIcwnaouWkfus0=; b=h+Tpc8QH5QOn7gguoxVuCU0zKPIVPGiugnACJ5vzIbK1TA4LXXYp6m6J7kikJUJWi0 v60hnnZN6SzeY/jwIgUUQcxoQSKhEcLR/LNurE8zB4Uk3RgTpi5zPpMAX6PaGJK1051x H/P1ayWHFk8HmTiXfg89ToPvLmS5NIU40w5G/tmaeRsR9QkLKEzxnogzVlCbB6MU+juw 9gJj5kGyhz00dBWzy45drP4niZpj83fMqamUYxvJIVtePB4WxWa7jSo8m5H2M+O6AcL1 wLQ0IOsCiWI4r4jZhLKwebP1iG273e+1u80jrcHF44PTyL79/W+RCJkDGlCQitSXs9xP GoTA== X-Gm-Message-State: AOAM531EkcLP7vg/5DSRYtTmXcTnxeuxTgTyyPHyuSa9P9h8RSYxiR0h uim6/8nKkSaR/008lIe/m41lYA== X-Google-Smtp-Source: ABdhPJy+kGHhOXrjUcU1fMGxEKhnP85mbZG4EUfAdZODYUfa/W2H8cyFljdwQ5Aqq7MOpTiPczS9+A== X-Received: by 2002:a1c:205:: with SMTP id 5mr2510295wmc.7.1605082542791; Wed, 11 Nov 2020 00:15:42 -0800 (PST) Received: from localhost.localdomain ([39.33.227.210]) by smtp.gmail.com with ESMTPSA id z3sm909539wrw.87.2020.11.11.00.15.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2020 00:15:42 -0800 (PST) From: Ibtisam Tariq To: maxime.coquelin@redhat.com, chenbo.xia@intel.com, cristian.dumitrescu@intel.com, jasvinder.singh@intel.com, john.mcnamara@intel.com, reshma.pattan@intel.com, konstantin.ananyev@intel.com, marko.kovacevic@intel.com Cc: dev@dpdk.org, Ibtisam Tariq , sergio.gonzalez.monroy@intel.com, phil.yang@arm.com Date: Wed, 11 Nov 2020 08:15:03 +0000 Message-Id: <20201111081507.19913-3-ibtisam.tariq@emumba.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201111081507.19913-1-ibtisam.tariq@emumba.com> References: <20201111081507.19913-1-ibtisam.tariq@emumba.com> Subject: [dpdk-dev] [PATCH 3/7] examples/packet_ordering: enhance getopt_long usage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Instead of using getopt_long return value, strcmp was used to compare the input parameters with the struct option array. This patch get rid of all those strcmp by directly binding each longopt with an int enum. This is to improve readability and consistency in all examples. Bugzilla ID: 238 Cc: sergio.gonzalez.monroy@intel.com Cc: phil.yang@arm.com Reported-by: David Marchand Signed-off-by: Ibtisam Tariq --- v2 * Remove extra indentations. * Remove extra block brackets in switch statement. * Change enum names to start with OPT_ and remove KEYWORD from enum names. v1 * enhance getopt_long usage --- examples/packet_ordering/main.c | 33 ++++++++++++++++++++------------- 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/examples/packet_ordering/main.c b/examples/packet_ordering/main.c index 4bea1982d..32e58c9cd 100644 --- a/examples/packet_ordering/main.c +++ b/examples/packet_ordering/main.c @@ -29,6 +29,13 @@ /* Macros for printing using RTE_LOG */ #define RTE_LOGTYPE_REORDERAPP RTE_LOGTYPE_USER1 +enum { +#define OPT_DISABLE_REORDER "disable-reorder" + OPT_DISABLE_REORDER_NUM = 256, +#define OPT_INSIGHT_WORKER "insight-worker" + OPT_INSIGHT_WORKER_NUM, +}; + unsigned int portmask; unsigned int disable_reorder; unsigned int insight_worker; @@ -157,9 +164,9 @@ parse_args(int argc, char **argv) char **argvopt; char *prgname = argv[0]; static struct option lgopts[] = { - {"disable-reorder", 0, 0, 0}, - {"insight-worker", 0, 0, 0}, - {NULL, 0, 0, 0} + {OPT_DISABLE_REORDER, 0, NULL, OPT_DISABLE_REORDER_NUM}, + {OPT_INSIGHT_WORKER, 0, NULL, OPT_INSIGHT_WORKER_NUM }, + {NULL, 0, 0, 0 } }; argvopt = argv; @@ -176,18 +183,18 @@ parse_args(int argc, char **argv) return -1; } break; + /* long options */ - case 0: - if (!strcmp(lgopts[option_index].name, "disable-reorder")) { - printf("reorder disabled\n"); - disable_reorder = 1; - } - if (!strcmp(lgopts[option_index].name, - "insight-worker")) { - printf("print all worker statistics\n"); - insight_worker = 1; - } + case OPT_DISABLE_REORDER_NUM: + printf("reorder disabled\n"); + disable_reorder = 1; + break; + + case OPT_INSIGHT_WORKER_NUM: + printf("print all worker statistics\n"); + insight_worker = 1; break; + default: print_usage(prgname); return -1; -- 2.17.1