* [dpdk-dev] [PATCH v1] net/txgbe: offset needs to be initialised to fix gcc compile error
@ 2020-11-11 13:05 Conor Walsh
2020-11-11 13:14 ` Ferruh Yigit
2020-11-11 15:39 ` [dpdk-dev] [PATCH v2] net/txgbe: return changed " Conor Walsh
0 siblings, 2 replies; 4+ messages in thread
From: Conor Walsh @ 2020-11-11 13:05 UTC (permalink / raw)
To: jiawenwu, jianwang; +Cc: dev, linglix.chen, Conor Walsh
When DPDK is compiled with gcc 7.5 with the optimization level set to 1
gcc sees the offset variable in txgbe_ethdev.c as possibly being
uninitialised. To correct this error offset has been initialised to 0 in
txgbe_ethdev.c
Signed-off-by: Conor Walsh <conor.walsh@intel.com>
---
drivers/net/txgbe/txgbe_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c
index 9f533603a1..7fd56c2698 100644
--- a/drivers/net/txgbe/txgbe_ethdev.c
+++ b/drivers/net/txgbe/txgbe_ethdev.c
@@ -2247,7 +2247,7 @@ txgbe_dev_xstats_get_(struct rte_eth_dev *dev, uint64_t *values,
/* Extended stats from txgbe_hw_stats */
for (i = 0; i < limit; i++) {
- uint32_t offset;
+ uint32_t offset = 0;
if (txgbe_get_offset_by_id(i, &offset)) {
PMD_INIT_LOG(WARNING, "id value %d isn't valid", i);
@@ -2270,7 +2270,7 @@ txgbe_dev_xstats_get_by_id(struct rte_eth_dev *dev, const uint64_t *ids,
return txgbe_dev_xstats_get_(dev, values, limit);
for (i = 0; i < limit; i++) {
- uint32_t offset;
+ uint32_t offset = 0;
if (txgbe_get_offset_by_id(ids[i], &offset)) {
PMD_INIT_LOG(WARNING, "id value %d isn't valid", i);
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH v1] net/txgbe: offset needs to be initialised to fix gcc compile error
2020-11-11 13:05 [dpdk-dev] [PATCH v1] net/txgbe: offset needs to be initialised to fix gcc compile error Conor Walsh
@ 2020-11-11 13:14 ` Ferruh Yigit
2020-11-11 15:39 ` [dpdk-dev] [PATCH v2] net/txgbe: return changed " Conor Walsh
1 sibling, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2020-11-11 13:14 UTC (permalink / raw)
To: Conor Walsh, jiawenwu, jianwang; +Cc: dev, linglix.chen
On 11/11/2020 1:05 PM, Conor Walsh wrote:
> When DPDK is compiled with gcc 7.5 with the optimization level set to 1
> gcc sees the offset variable in txgbe_ethdev.c as possibly being
> uninitialised. To correct this error offset has been initialised to 0 in
> txgbe_ethdev.c
>
> Signed-off-by: Conor Walsh <conor.walsh@intel.com>
> ---
> drivers/net/txgbe/txgbe_ethdev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c
> index 9f533603a1..7fd56c2698 100644
> --- a/drivers/net/txgbe/txgbe_ethdev.c
> +++ b/drivers/net/txgbe/txgbe_ethdev.c
> @@ -2247,7 +2247,7 @@ txgbe_dev_xstats_get_(struct rte_eth_dev *dev, uint64_t *values,
>
> /* Extended stats from txgbe_hw_stats */
> for (i = 0; i < limit; i++) {
> - uint32_t offset;
> + uint32_t offset = 0;
>
This is false positive, right?
Is there an actual case that 'offset' is used without initialization?
'txgbe_get_offset_by_id()' return value seems used only to detect fail/success,
can you please try with 'txgbe_get_offset_by_id()' returning a simple '-1' on
failure, instead of current "-(int)(id + 1)", if it helps with the compiler warning?
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH v2] net/txgbe: return changed to fix gcc compile error
2020-11-11 13:05 [dpdk-dev] [PATCH v1] net/txgbe: offset needs to be initialised to fix gcc compile error Conor Walsh
2020-11-11 13:14 ` Ferruh Yigit
@ 2020-11-11 15:39 ` Conor Walsh
2020-11-12 15:05 ` Ferruh Yigit
1 sibling, 1 reply; 4+ messages in thread
From: Conor Walsh @ 2020-11-11 15:39 UTC (permalink / raw)
To: jiawenwu, jianwang; +Cc: dev, linglix.chen, Conor Walsh
When DPDK is compiled with gcc 7.5 with the optimization level set to 1
gcc sees the offset variable in txgbe_ethdev.c as possibly being
uninitialised. To correct this the final return statement in
txgbe_get_offset_by_id was simplified to return -1.
Signed-off-by: Conor Walsh <conor.walsh@intel.com>
---
drivers/net/txgbe/txgbe_ethdev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c
index 9f533603a1..f8dffe1f12 100644
--- a/drivers/net/txgbe/txgbe_ethdev.c
+++ b/drivers/net/txgbe/txgbe_ethdev.c
@@ -2140,9 +2140,8 @@ txgbe_get_offset_by_id(uint32_t id, uint32_t *offset)
nb * (TXGBE_NB_QP_STATS * sizeof(uint64_t));
return 0;
}
- id -= TXGBE_NB_QP_STATS * TXGBE_MAX_QP;
- return -(int)(id + 1);
+ return -1;
}
static int txgbe_dev_xstats_get_names(struct rte_eth_dev *dev,
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH v2] net/txgbe: return changed to fix gcc compile error
2020-11-11 15:39 ` [dpdk-dev] [PATCH v2] net/txgbe: return changed " Conor Walsh
@ 2020-11-12 15:05 ` Ferruh Yigit
0 siblings, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2020-11-12 15:05 UTC (permalink / raw)
To: Conor Walsh, jiawenwu, jianwang; +Cc: dev, linglix.chen
On 11/11/2020 3:39 PM, Conor Walsh wrote:
> When DPDK is compiled with gcc 7.5 with the optimization level set to 1
> gcc sees the offset variable in txgbe_ethdev.c as possibly being
> uninitialised. To correct this the final return statement in
> txgbe_get_offset_by_id was simplified to return -1.
>
> Signed-off-by: Conor Walsh <conor.walsh@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-12 15:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-11 13:05 [dpdk-dev] [PATCH v1] net/txgbe: offset needs to be initialised to fix gcc compile error Conor Walsh
2020-11-11 13:14 ` Ferruh Yigit
2020-11-11 15:39 ` [dpdk-dev] [PATCH v2] net/txgbe: return changed " Conor Walsh
2020-11-12 15:05 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).