From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: David Christensen <drc@linux.vnet.ibm.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
"Ruifeng Wang (Arm Technology China)" <ruifeng.wang@arm.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
"Xia, Chenbo" <chenbo.xia@intel.com>, dev <dev@dpdk.org>,
Marvin Liu <yong.liu@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH] net/virtio: enable packet data prefetch on x86
Date: Wed, 11 Nov 2020 15:53:46 +0000 [thread overview]
Message-ID: <20201111155346.GD1500@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <CAJFAV8y+kyHJG6j0kYtt=z37rLqXL-cbtahcQCutjCRRLk4bhA@mail.gmail.com>
On Wed, Nov 11, 2020 at 04:45:25PM +0100, David Marchand wrote:
> On Wed, Nov 11, 2020 at 4:40 PM Marvin Liu <yong.liu@intel.com> wrote:
> >
> > Data prefetch instruction can preload data into cpu’s hierarchical
> > cache before data access. Virtio datapath utilized this feature for
> > data access acceleration. As config RTE_PMD_PACKET_PREFETCH was
> > discarded, now packet data prefetch is enabled based on architecture.
>
> IIUC, this config item was set for all architectures under make compilation.
>
> $ git grep RTE_PMD_PACKET_PREFETCH v20.08 config/
> v20.08:config/common_base:CONFIG_RTE_PMD_PACKET_PREFETCH=y
>
> Now that we switched to meson, it got lost and this patch only
> restores it for x86.
> Can other architectures check this?
>
If it was globally enabled before, it probably should just be added to
config/rte_config.h file.
/Bruce
next prev parent reply other threads:[~2020-11-11 15:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 15:40 Marvin Liu
2020-11-11 15:45 ` David Marchand
2020-11-11 15:53 ` Bruce Richardson [this message]
2020-11-11 15:56 ` David Marchand
2020-11-12 8:48 ` Maxime Coquelin
2020-11-12 8:57 ` David Marchand
2020-11-13 1:20 ` Liu, Yong
2020-11-13 7:27 ` David Marchand
2020-11-13 12:21 ` Liu, Yong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201111155346.GD1500@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=chenbo.xia@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=jerinj@marvell.com \
--cc=maxime.coquelin@redhat.com \
--cc=ruifeng.wang@arm.com \
--cc=thomas@monjalon.net \
--cc=yong.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).