From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0AB4A09D9; Wed, 11 Nov 2020 16:53:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5CC9B31FC; Wed, 11 Nov 2020 16:53:56 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 27465DED for ; Wed, 11 Nov 2020 16:53:54 +0100 (CET) IronPort-SDR: BT2bcGVzTaK8n7/RRxLKZh3/lfIUkg51rtARdB1WaHlHOffGdEzD/ufoqu3aJUtmbpNZOf1KbI 6sCzwlp83fLQ== X-IronPort-AV: E=McAfee;i="6000,8403,9801"; a="254874547" X-IronPort-AV: E=Sophos;i="5.77,469,1596524400"; d="scan'208";a="254874547" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2020 07:53:53 -0800 IronPort-SDR: /D6bI+uPNpTmyJxxBgHboaVc2T8xSf1ntetCmdbsH5GBZ3lDvmnBMYOysGsKaf3DnHmSFIK2tf I1UGegrPh34g== X-IronPort-AV: E=Sophos;i="5.77,469,1596524400"; d="scan'208";a="541851282" Received: from bricha3-mobl.ger.corp.intel.com ([10.249.32.180]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 11 Nov 2020 07:53:50 -0800 Date: Wed, 11 Nov 2020 15:53:46 +0000 From: Bruce Richardson To: David Marchand Cc: David Christensen , Jerin Jacob Kollanukkaran , "Ruifeng Wang (Arm Technology China)" , Maxime Coquelin , "Xia, Chenbo" , dev , Marvin Liu , Thomas Monjalon Message-ID: <20201111155346.GD1500@bricha3-MOBL.ger.corp.intel.com> References: <20201111154007.13426-1-yong.liu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Subject: Re: [dpdk-dev] [PATCH] net/virtio: enable packet data prefetch on x86 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Nov 11, 2020 at 04:45:25PM +0100, David Marchand wrote: > On Wed, Nov 11, 2020 at 4:40 PM Marvin Liu wrote: > > > > Data prefetch instruction can preload data into cpu’s hierarchical > > cache before data access. Virtio datapath utilized this feature for > > data access acceleration. As config RTE_PMD_PACKET_PREFETCH was > > discarded, now packet data prefetch is enabled based on architecture. > > IIUC, this config item was set for all architectures under make compilation. > > $ git grep RTE_PMD_PACKET_PREFETCH v20.08 config/ > v20.08:config/common_base:CONFIG_RTE_PMD_PACKET_PREFETCH=y > > Now that we switched to meson, it got lost and this patch only > restores it for x86. > Can other architectures check this? > If it was globally enabled before, it probably should just be added to config/rte_config.h file. /Bruce