From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 04B1CA09D9;
	Wed, 11 Nov 2020 18:33:16 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id EFAEBF90;
	Wed, 11 Nov 2020 18:33:14 +0100 (CET)
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id B28872AB
 for <dev@dpdk.org>; Wed, 11 Nov 2020 18:33:12 +0100 (CET)
IronPort-SDR: a7CEZNWpwj4/0/dS0bhvJdueu5pnD5bBIXu7Ku6BqVHIfSqhWrVn9RVVXEryU5z0n2wL0GPPyO
 tXf0MwmksUwQ==
X-IronPort-AV: E=McAfee;i="6000,8403,9802"; a="188167000"
X-IronPort-AV: E=Sophos;i="5.77,470,1596524400"; d="scan'208";a="188167000"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga005.jf.intel.com ([10.7.209.41])
 by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 11 Nov 2020 09:33:08 -0800
IronPort-SDR: naxRF2VH0HixFl002+JDlmuLagN3fuyfIoHYYtsQKSWsvvqHSMlZjHU/cRjekr4rK6tuzBWKJF
 06k154bMiNeA==
X-IronPort-AV: E=Sophos;i="5.77,470,1596524400"; d="scan'208";a="541885129"
Received: from bricha3-mobl.ger.corp.intel.com ([10.249.32.180])
 by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA;
 11 Nov 2020 09:33:07 -0800
Date: Wed, 11 Nov 2020 17:33:03 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: david.marchand@redhat.com
Message-ID: <20201111173303.GE1500@bricha3-MOBL.ger.corp.intel.com>
References: <20201110170809.1309043-1-bruce.richardson@intel.com>
 <20201111155647.1720787-1-bruce.richardson@intel.com>
 <20201111155647.1720787-2-bruce.richardson@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201111155647.1720787-2-bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 2/2] examples: skip installing unbuildable
	examples
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Nov 11, 2020 at 03:56:47PM +0000, Bruce Richardson wrote:
> Rather than just installing all examples, we can use the build checks to
> filter out any examples that are missing dependencies or are otherwise
> unbuildable on the current system.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  examples/meson.build | 54 +++++++++++++++++++++++++++-----------------
>  meson.build          |  2 ++
>  2 files changed, 35 insertions(+), 21 deletions(-)
> 
This seems to have broken the windows builds because we now process all the
examples meson.build file, even if not asked to build them. l2fwd-keepalive
has a mandatory, unconditional dependency on librt, which needs to be made
optional.

Based on that, V3 pending...