From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23C1CA09D3; Thu, 12 Nov 2020 10:25:04 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8940B5928; Thu, 12 Nov 2020 10:25:01 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 160581E2B for ; Thu, 12 Nov 2020 10:24:58 +0100 (CET) IronPort-SDR: ubau9ccUoftA6OTwT9K+ofda5/fqifCws06nmRQE/tvIxOnS6iMNf/OOOrPuMjb5ZhMj1T9rQh Mu/CgiUMRRBQ== X-IronPort-AV: E=McAfee;i="6000,8403,9802"; a="149555166" X-IronPort-AV: E=Sophos;i="5.77,471,1596524400"; d="scan'208";a="149555166" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Nov 2020 01:24:57 -0800 IronPort-SDR: Cgz9QUY4ljC6Yzl4V88QELK+yHWy5oYTogs3jHZk7PQ2FgZEWp9Ty+fxYexiCSsYWENtnOb7dr Z2s1kUoIZjwA== X-IronPort-AV: E=Sophos;i="5.77,471,1596524400"; d="scan'208";a="328431565" Received: from bricha3-mobl.ger.corp.intel.com ([10.213.208.146]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 12 Nov 2020 01:24:55 -0800 Date: Thu, 12 Nov 2020 09:24:52 +0000 From: Bruce Richardson To: David Marchand Cc: dev Message-ID: <20201112092452.GA1309@bricha3-MOBL.ger.corp.intel.com> References: <20201110170809.1309043-1-bruce.richardson@intel.com> <20201111155647.1720787-1-bruce.richardson@intel.com> <20201111155647.1720787-2-bruce.richardson@intel.com> <20201111173303.GE1500@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v2 2/2] examples: skip installing unbuildable examples X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Nov 12, 2020 at 10:14:23AM +0100, David Marchand wrote: > On Wed, Nov 11, 2020 at 6:33 PM Bruce Richardson > wrote: > > > > On Wed, Nov 11, 2020 at 03:56:47PM +0000, Bruce Richardson wrote: > > > Rather than just installing all examples, we can use the build checks to > > > filter out any examples that are missing dependencies or are otherwise > > > unbuildable on the current system. > > > > > > Signed-off-by: Bruce Richardson > > > --- > > > examples/meson.build | 54 +++++++++++++++++++++++++++----------------- > > > meson.build | 2 ++ > > > 2 files changed, 35 insertions(+), 21 deletions(-) > > > > > This seems to have broken the windows builds because we now process all the > > examples meson.build file, even if not asked to build them. l2fwd-keepalive > > has a mandatory, unconditional dependency on librt, which needs to be made > > optional. > > > > Based on that, V3 pending... > > Strange, the v3 patches 2 and 3 linked to the v2 series. > As far as I can see, the lab only tested the v3 series with patches > 84029 and 30, so the error on Windows is still reported. > > -- > David Marchand > Yes, I see that in patchwork, and it's a bit strange. The emails seem correctly threaded to me in my mail client though. I'll resubmit as v4 with a cover letter to see if that allows the CI to run properly. /Bruce