From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 9D229A09D3;
	Thu, 12 Nov 2020 11:22:38 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 0AC0056A3;
	Thu, 12 Nov 2020 11:22:37 +0100 (CET)
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by dpdk.org (Postfix) with ESMTP id 150DF2AB
 for <dev@dpdk.org>; Thu, 12 Nov 2020 11:22:33 +0100 (CET)
IronPort-SDR: kcR/jqhym6dOEr1rYVeBx1gq2d3hGZI8KWCmUSZVlqVIMGgCHRL+A4EOUzl8f5s6QTumirah2R
 VA466kN7mbwQ==
X-IronPort-AV: E=McAfee;i="6000,8403,9802"; a="150138150"
X-IronPort-AV: E=Sophos;i="5.77,471,1596524400"; d="scan'208";a="150138150"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga005.jf.intel.com ([10.7.209.41])
 by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 12 Nov 2020 02:22:31 -0800
IronPort-SDR: 5KtBxnncmZ7ZIlykdWXt1z9ZA+KXP03ldG5Sq5+EnEkTSi3Cy1qHOsWJ4O1Ous0K9Y2HWDrrkK
 oJXuH85Clrqg==
X-IronPort-AV: E=Sophos;i="5.77,471,1596524400"; d="scan'208";a="542207361"
Received: from bricha3-mobl.ger.corp.intel.com ([10.213.208.146])
 by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA;
 12 Nov 2020 02:22:29 -0800
Date: Thu, 12 Nov 2020 10:22:26 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: "Jiang, Cheng1" <cheng1.jiang@intel.com>,
 Maxime Coquelin <maxime.coquelin@redhat.com>,
 "Xia, Chenbo" <chenbo.xia@intel.com>, dev <dev@dpdk.org>,
 "Fu, Patrick" <patrick.fu@intel.com>,
 "Yang, YvonneX" <yvonnex.yang@intel.com>, "Hu, Jiayu" <jiayu.hu@intel.com>,
 Thomas Monjalon <thomas@monjalon.net>,
 "Yigit, Ferruh" <ferruh.yigit@intel.com>
Message-ID: <20201112102226.GD1309@bricha3-MOBL.ger.corp.intel.com>
References: <20201111111957.46090-1-Cheng1.jiang@intel.com>
 <CAJFAV8yoAhOvOHKY4UJRRYD_x_h6hqnGqWHcwTVW+cjBorwiVw@mail.gmail.com>
 <CO1PR11MB499597446E7CBC60BA8BC229DCE70@CO1PR11MB4995.namprd11.prod.outlook.com>
 <20201112093113.GB1309@bricha3-MOBL.ger.corp.intel.com>
 <CAJFAV8yFYXQufQ-BcJ_BidLgF=5cSM4fLO8G3LBAvc_pcoEtUw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJFAV8yFYXQufQ-BcJ_BidLgF=5cSM4fLO8G3LBAvc_pcoEtUw@mail.gmail.com>
Subject: Re: [dpdk-dev] [PATCH v1] examples/vhost: fix ioat dependency issue
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Nov 12, 2020 at 10:39:33AM +0100, David Marchand wrote:
> On Thu, Nov 12, 2020 at 10:31 AM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> > > > main.c should check for RTE_RAW_IOAT before including ioat.h.
> > > > And then in this header, you can remove this stub too.
> > > >
> > >
> > > As for this one, ioat.h don't have dependency on IOAT driver, it is needed by the example regardless of whether the raw/ioat driver exists. And I added more RTE_RAW_IOAT check in ioat.h. Now it can be compiled.
> > >
> >
> > The trouble is that the ioat header file won't be installed if the driver
> > is not built. They will be available for building inside the source tree,
> > but not on a system with dpdk installed using "ninja install"
> 
> I tested disabling the driver, and I can see:
> installdir/usr/local/share/dpdk/examples/vhost/ioat.h
> 
My mistake, I assumed the reference was to the rte_ioat_rawdev.h file from
the ioat driver.
Please ignore my comment so.