From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v4 0/4] improve examples installation
Date: Thu, 12 Nov 2020 14:57:28 +0000 [thread overview]
Message-ID: <20201112145728.GJ1309@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <CAJFAV8zs=8t=b4Pnne8SXryL8Av-zH5GYQrJr8=oOTqbDs4TpA@mail.gmail.com>
On Thu, Nov 12, 2020 at 02:48:52PM +0100, David Marchand wrote:
> On Thu, Nov 12, 2020 at 12:38 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> > > My only comment is about vm_power_manager which won't build without
> > > the internal librte_power header.
> > > It builds fine with meson, because I guess meson pulls this library
> > > directory into the include flags of the example, but it won't build
> > > outside.
> > >
> > > We can skip it in devtools/test-meson-builds.sh but, on the other
> > > hand, I would exclude it from installing until it is fixed (in a
> > > future release).
> > >
> > Yes, good point.
> > Rather than adding special logic for it, I think we just add it in the
> > initialization of the exclusion array in patch 4, i.e.
> >
> > -dpdk_examples_exclude = []$
> > +dpdk_examples_exclude = ['vm_power_manager']
> >
> > Can this be done on apply, or do you want a v5 for it?
>
> CI is happy with v4.
>
> I tested this additional change, lgtm too.
> I would add something in the commitlog to give some context:
>
> """
> vm_power_manager relies on an internal header and can't build outside
> the dpdk tree.
> Hence, it is still built with meson but it is excluded from install
> examples until it has been fixed.
> """
>
> WDYT?
>
LGTM
next prev parent reply other threads:[~2020-11-12 14:57 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 17:08 [dpdk-dev] [PATCH] install: fix flattening of examples directory Bruce Richardson
2020-11-10 17:09 ` Bruce Richardson
2020-11-10 17:14 ` David Marchand
2020-11-10 17:33 ` [dpdk-dev] [dpdk-stable] " David Marchand
2020-11-10 17:42 ` Bruce Richardson
2020-11-11 15:56 ` [dpdk-dev] [PATCH v2 1/2] examples: fix flattening directory layout on install Bruce Richardson
2020-11-11 15:56 ` [dpdk-dev] [PATCH v2 2/2] examples: skip installing unbuildable examples Bruce Richardson
2020-11-11 17:33 ` Bruce Richardson
2020-11-12 9:14 ` David Marchand
2020-11-12 9:24 ` Bruce Richardson
2020-11-12 9:27 ` David Marchand
2020-11-12 9:35 ` Bruce Richardson
2020-11-11 17:48 ` [dpdk-dev] [PATCH v3 1/4] examples: fix flattening directory layout on install Bruce Richardson
2020-11-11 17:48 ` [dpdk-dev] [PATCH v3 2/4] examples/l2fwd-keepalive: skip build when no librt Bruce Richardson
2020-11-11 17:48 ` [dpdk-dev] [PATCH v3 3/4] examples: stop processing build file if build is impossible Bruce Richardson
2020-11-11 17:48 ` [dpdk-dev] [PATCH v3 4/4] examples: skip installing unbuildable examples Bruce Richardson
2020-11-12 9:41 ` [dpdk-dev] [PATCH v4 0/4] improve examples installation Bruce Richardson
2020-11-12 9:41 ` [dpdk-dev] [PATCH v4 1/4] examples: fix flattening directory layout on install Bruce Richardson
2020-11-12 9:41 ` [dpdk-dev] [PATCH v4 2/4] examples/l2fwd-keepalive: skip build when no librt Bruce Richardson
2020-11-12 9:41 ` [dpdk-dev] [PATCH v4 3/4] examples: stop processing build file if build is impossible Bruce Richardson
2020-11-12 9:41 ` [dpdk-dev] [PATCH v4 4/4] examples: skip installing unbuildable examples Bruce Richardson
2020-11-12 17:06 ` Thomas Monjalon
2020-11-12 11:14 ` [dpdk-dev] [PATCH v4 0/4] improve examples installation David Marchand
2020-11-12 11:38 ` Bruce Richardson
2020-11-12 13:48 ` David Marchand
2020-11-12 14:57 ` Bruce Richardson [this message]
2020-11-12 18:36 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201112145728.GJ1309@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).