From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 90996A09D3; Thu, 12 Nov 2020 15:57:46 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CB00B5928; Thu, 12 Nov 2020 15:57:44 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 8803556A3 for ; Thu, 12 Nov 2020 15:57:42 +0100 (CET) IronPort-SDR: S4LJdFtYfTcEaYWDqKo2pUl7WKZZsYl1X9CvRf1GOSEB2W/zN4G2x6Fo9IrFkupbOzJXjUM67S x9zNVpCygxtQ== X-IronPort-AV: E=McAfee;i="6000,8403,9802"; a="157335738" X-IronPort-AV: E=Sophos;i="5.77,472,1596524400"; d="scan'208";a="157335738" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Nov 2020 06:57:34 -0800 IronPort-SDR: s5miIgc8R1tUXUYHT2+DxemEqyFeZg6Ka8B6Hh6Ko+URj8j7e6WQo+yAsUilMG3hgLXLjgEJJ2 lnA4DRtFx4XQ== X-IronPort-AV: E=Sophos;i="5.77,472,1596524400"; d="scan'208";a="474297263" Received: from bricha3-mobl.ger.corp.intel.com ([10.213.208.146]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 12 Nov 2020 06:57:32 -0800 Date: Thu, 12 Nov 2020 14:57:28 +0000 From: Bruce Richardson To: David Marchand Cc: dev , Thomas Monjalon Message-ID: <20201112145728.GJ1309@bricha3-MOBL.ger.corp.intel.com> References: <20201110170809.1309043-1-bruce.richardson@intel.com> <20201112094142.1781861-1-bruce.richardson@intel.com> <20201112113827.GG1309@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v4 0/4] improve examples installation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Nov 12, 2020 at 02:48:52PM +0100, David Marchand wrote: > On Thu, Nov 12, 2020 at 12:38 PM Bruce Richardson > wrote: > > > My only comment is about vm_power_manager which won't build without > > > the internal librte_power header. > > > It builds fine with meson, because I guess meson pulls this library > > > directory into the include flags of the example, but it won't build > > > outside. > > > > > > We can skip it in devtools/test-meson-builds.sh but, on the other > > > hand, I would exclude it from installing until it is fixed (in a > > > future release). > > > > > Yes, good point. > > Rather than adding special logic for it, I think we just add it in the > > initialization of the exclusion array in patch 4, i.e. > > > > -dpdk_examples_exclude = []$ > > +dpdk_examples_exclude = ['vm_power_manager'] > > > > Can this be done on apply, or do you want a v5 for it? > > CI is happy with v4. > > I tested this additional change, lgtm too. > I would add something in the commitlog to give some context: > > """ > vm_power_manager relies on an internal header and can't build outside > the dpdk tree. > Hence, it is still built with meson but it is excluded from install > examples until it has been fixed. > """ > > WDYT? > LGTM