From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BCD0DA09D3; Thu, 12 Nov 2020 16:48:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 41878569B; Thu, 12 Nov 2020 16:48:35 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 32B964CA6 for ; Thu, 12 Nov 2020 16:48:33 +0100 (CET) IronPort-SDR: rRh2UU4OMSipYF/GK51FyE2CrIn6+BZavgqYkdJAd1gkkJaiNL5kqM8et2X2MX4H2K/Qdu8O9L ht5OKWBgsHBA== X-IronPort-AV: E=McAfee;i="6000,8403,9803"; a="150178270" X-IronPort-AV: E=Sophos;i="5.77,472,1596524400"; d="scan'208";a="150178270" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Nov 2020 07:48:26 -0800 IronPort-SDR: V9LlZH+lkEEJATd8I0PglrOiHFOxvsCRbTO6UeBt/txVNIxD5UlBtZHo9hzyHmVSR0hnvx77yz 44sq1+IAWz5g== X-IronPort-AV: E=Sophos;i="5.77,472,1596524400"; d="scan'208";a="542302976" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.3.153]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 12 Nov 2020 07:48:24 -0800 Date: Thu, 12 Nov 2020 15:48:20 +0000 From: Bruce Richardson To: "David Harton (dharton)" Cc: "dev@dpdk.org" Message-ID: <20201112154820.GA1322@bricha3-MOBL.ger.corp.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] Eliminate config/rte_config.h? X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Nov 12, 2020 at 03:39:10PM +0000, David Harton (dharton) wrote: > Hi folks, > > > > Been experimenting with DPDK 20.11 and the loss of the old "config" > hierarchy. > > > > I wonder if anyone considered eliminating config/rte_config.h in favor of > a config/dpdk_conf that can contain the default values at the start of > the file but can be overridden with values later in the file similar to > how the old config files worked? > > > > It just feels awkward to modify a versioned header file per build > especially if multiple builds want to share the same repo but with > different values specified in config/rte_config.h especially when > "rte_build_config.h" is included at the very beginning of > config/rte_config.h. > > > > Thoughts? > > Dave > I'd personally be open to replacing it if we have a better solution. Are there many values in it that you look to tune, because I believe the general consensus is that we want to reduce the number of tunables we have per DPDK build? To that end our main concern should be having decent defaults, and thereafter we can see about the best mechanism to allow easy overriding for edge-cases. Any early attempt at such a thing was tried [1], but unfortunately it had issues so we need a new approach - possibly one as you had suggested. /Bruce