From: Bruce Richardson <bruce.richardson@intel.com>
To: "David Harton (dharton)" <dharton@cisco.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] Eliminate config/rte_config.h?
Date: Thu, 12 Nov 2020 16:33:24 +0000 [thread overview]
Message-ID: <20201112163324.GC1322@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20201112154820.GA1322@bricha3-MOBL.ger.corp.intel.com>
On Thu, Nov 12, 2020 at 03:48:20PM +0000, Bruce Richardson wrote:
> On Thu, Nov 12, 2020 at 03:39:10PM +0000, David Harton (dharton) wrote:
> > Hi folks,
> >
> >
> >
> > Been experimenting with DPDK 20.11 and the loss of the old "config"
> > hierarchy.
> >
> >
> >
> > I wonder if anyone considered eliminating config/rte_config.h in favor of
> > a config/dpdk_conf that can contain the default values at the start of
> > the file but can be overridden with values later in the file similar to
> > how the old config files worked?
> >
> >
> >
> > It just feels awkward to modify a versioned header file per build
> > especially if multiple builds want to share the same repo but with
> > different values specified in config/rte_config.h especially when
> > "rte_build_config.h" is included at the very beginning of
> > config/rte_config.h.
> >
> >
> >
> > Thoughts?
> >
> > Dave
> >
>
> I'd personally be open to replacing it if we have a better solution. Are
> there many values in it that you look to tune, because I believe the
> general consensus is that we want to reduce the number of tunables we have
> per DPDK build? To that end our main concern should be having decent
> defaults, and thereafter we can see about the best mechanism to allow easy
> overriding for edge-cases.
>
> Any early attempt at such a thing was tried [1], but unfortunately it had
> issues so we need a new approach - possibly one as you had suggested.
>
Just sent another idea of what options might be possible:
http://patches.dpdk.org/patch/84068/
Regards,
/Bruce
next prev parent reply other threads:[~2020-11-12 16:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 15:39 David Harton (dharton)
2020-11-12 15:48 ` Bruce Richardson
2020-11-12 16:33 ` Bruce Richardson [this message]
2020-11-12 17:09 ` David Harton (dharton)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201112163324.GC1322@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dharton@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).