From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3524AA09D3; Thu, 12 Nov 2020 17:33:41 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 11F54592B; Thu, 12 Nov 2020 17:33:40 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 85B2056A3 for ; Thu, 12 Nov 2020 17:33:37 +0100 (CET) IronPort-SDR: ZaUcJPw6iO9Mj2FFl4mdI1RHmec44Susvw1Zvck/EqmYauGOPjOTrkz/t0ppsIelPa5HVhb4cf 0URSoeZX/rVQ== X-IronPort-AV: E=McAfee;i="6000,8403,9803"; a="166831003" X-IronPort-AV: E=Sophos;i="5.77,472,1596524400"; d="scan'208";a="166831003" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Nov 2020 08:33:33 -0800 IronPort-SDR: 3Edu7MFSC9OVfwcRbC7zGEiXNDHF224Ai+eOMODeOjN1ZY9jv1lsmZwC/8bv9VnzCsjTrikSzF LFWYDucMWNkw== X-IronPort-AV: E=Sophos;i="5.77,472,1596524400"; d="scan'208";a="542320089" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.3.153]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 12 Nov 2020 08:33:31 -0800 Date: Thu, 12 Nov 2020 16:33:24 +0000 From: Bruce Richardson To: "David Harton (dharton)" Cc: "dev@dpdk.org" Message-ID: <20201112163324.GC1322@bricha3-MOBL.ger.corp.intel.com> References: <20201112154820.GA1322@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201112154820.GA1322@bricha3-MOBL.ger.corp.intel.com> Subject: Re: [dpdk-dev] Eliminate config/rte_config.h? X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Nov 12, 2020 at 03:48:20PM +0000, Bruce Richardson wrote: > On Thu, Nov 12, 2020 at 03:39:10PM +0000, David Harton (dharton) wrote: > > Hi folks, > > > > > > > > Been experimenting with DPDK 20.11 and the loss of the old "config" > > hierarchy. > > > > > > > > I wonder if anyone considered eliminating config/rte_config.h in favor of > > a config/dpdk_conf that can contain the default values at the start of > > the file but can be overridden with values later in the file similar to > > how the old config files worked? > > > > > > > > It just feels awkward to modify a versioned header file per build > > especially if multiple builds want to share the same repo but with > > different values specified in config/rte_config.h especially when > > "rte_build_config.h" is included at the very beginning of > > config/rte_config.h. > > > > > > > > Thoughts? > > > > Dave > > > > I'd personally be open to replacing it if we have a better solution. Are > there many values in it that you look to tune, because I believe the > general consensus is that we want to reduce the number of tunables we have > per DPDK build? To that end our main concern should be having decent > defaults, and thereafter we can see about the best mechanism to allow easy > overriding for edge-cases. > > Any early attempt at such a thing was tried [1], but unfortunately it had > issues so we need a new approach - possibly one as you had suggested. > Just sent another idea of what options might be possible: http://patches.dpdk.org/patch/84068/ Regards, /Bruce