DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [RFC PATCH] build: allow passing extra config header to	build
Date: Fri, 13 Nov 2020 10:06:14 +0000
Message-ID: <20201113100614.GA53@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <DBAPR08MB58144044F6A114C7157FA8A498E60@DBAPR08MB5814.eurprd08.prod.outlook.com>

On Fri, Nov 13, 2020 at 04:55:57AM +0000, Honnappa Nagarahalli wrote:
> <snip>
> 
> > 
> > To allow per-build override of some settings, without having to change
> > DPDK source-code files, i.e. rte_config.h, we can add an option to
> > allow the user to pass in a file containing their own defines for the
> > build.
> I guess, the file format should be same as any header file.  One could
> derive a file from rte_config.h. I think this will provide good
> flexibility.  If this is provided, we could deprecate options such as
> max_lcores, max_numa_nodes. But it would mean, one needs to know the
> exact #defines.
>
Yep, fully agree and I definitely think we should look to remove some
options like those.

 However, this is just one possibility of the way we can do things, so I'd
like to see other prototype suggestions also proposed here on-list (or
suggested approaches just outlined in email such as proposed by David
Harton).  I also will add this to the techboard agenda for future
discussion, so that we can do some brain-storming as to how best to improve
this area, and discuss any prototypes covered on-list.

/Bruce

  reply	other threads:[~2020-11-13 10:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-12 16:31 Bruce Richardson
2020-11-13  4:55 ` Honnappa Nagarahalli
2020-11-13 10:06   ` Bruce Richardson [this message]
2020-11-17 17:08 ` David Harton (dharton)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201113100614.GA53@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=dev@dpdk.org \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git