From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D664A09DE; Fri, 13 Nov 2020 11:06:27 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 31DA9C86C; Fri, 13 Nov 2020 11:06:26 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 894BE37B4 for ; Fri, 13 Nov 2020 11:06:25 +0100 (CET) IronPort-SDR: DtxaogspM1ZroGE2Ur42uoNoaDWlb9+plmdbN2H6vYp00RSX5R93G9F3ZQ1On01hNCBehbpW8h +76mWczM3oJw== X-IronPort-AV: E=McAfee;i="6000,8403,9803"; a="150302224" X-IronPort-AV: E=Sophos;i="5.77,475,1596524400"; d="scan'208";a="150302224" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Nov 2020 02:06:21 -0800 IronPort-SDR: MKTtjMcmbzEoi7Z03za6rvtj4IVyQP4TlSQkErbCytpVaK0+DwC5WdcceHc02gXZ8/Zp/9r52X 5rmGi92qSVrw== X-IronPort-AV: E=Sophos;i="5.77,475,1596524400"; d="scan'208";a="474612098" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.3.226]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 13 Nov 2020 02:06:18 -0800 Date: Fri, 13 Nov 2020 10:06:14 +0000 From: Bruce Richardson To: Honnappa Nagarahalli Cc: "dev@dpdk.org" , nd Message-ID: <20201113100614.GA53@bricha3-MOBL.ger.corp.intel.com> References: <20201112163134.1893190-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [RFC PATCH] build: allow passing extra config header to build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Nov 13, 2020 at 04:55:57AM +0000, Honnappa Nagarahalli wrote: > > > > > > To allow per-build override of some settings, without having to change > > DPDK source-code files, i.e. rte_config.h, we can add an option to > > allow the user to pass in a file containing their own defines for the > > build. > I guess, the file format should be same as any header file. One could > derive a file from rte_config.h. I think this will provide good > flexibility. If this is provided, we could deprecate options such as > max_lcores, max_numa_nodes. But it would mean, one needs to know the > exact #defines. > Yep, fully agree and I definitely think we should look to remove some options like those. However, this is just one possibility of the way we can do things, so I'd like to see other prototype suggestions also proposed here on-list (or suggested approaches just outlined in email such as proposed by David Harton). I also will add this to the techboard agenda for future discussion, so that we can do some brain-storming as to how best to improve this area, and discuss any prototypes covered on-list. /Bruce