From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6F210A09E0; Fri, 13 Nov 2020 15:24:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CD94AC86A; Fri, 13 Nov 2020 15:24:55 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id E2BF54C96 for <dev@dpdk.org>; Fri, 13 Nov 2020 15:24:53 +0100 (CET) IronPort-SDR: BG7nh0MHTH+2bKw2hXT60KJmgn+awLnlhtU/26d0ROoBBZ8szE8Lvu1kYAWA3IH9Hhsealcm1Y c3rGJmJxe2jw== X-IronPort-AV: E=McAfee;i="6000,8403,9803"; a="158254999" X-IronPort-AV: E=Sophos;i="5.77,475,1596524400"; d="scan'208";a="158254999" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Nov 2020 06:24:42 -0800 IronPort-SDR: x/j/qP7eGAsq/ot9DOHq9Vi8YPN7OIDmMO0LoYfhbL7OgoCX1oWf7HBNJ8fjSB++Ybizzho3KO M3K/qsNf/uXA== X-IronPort-AV: E=Sophos;i="5.77,475,1596524400"; d="scan'208";a="542670899" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.3.226]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 13 Nov 2020 06:24:41 -0800 Date: Fri, 13 Nov 2020 14:24:37 +0000 From: Bruce Richardson <bruce.richardson@intel.com> To: David Marchand <david.marchand@redhat.com> Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>, Luca Boccassi <bluca@debian.org> Message-ID: <20201113142437.GD53@bricha3-MOBL.ger.corp.intel.com> References: <20201110151219.4893-1-david.marchand@redhat.com> <20201113122430.25354-1-david.marchand@redhat.com> <20201113122430.25354-12-david.marchand@redhat.com> <20201113140620.GC53@bricha3-MOBL.ger.corp.intel.com> <CAJFAV8yE7W9uUsCQyxakN4913BSUWWRY7csxfx6HB+AL_FbyRQ@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <CAJFAV8yE7W9uUsCQyxakN4913BSUWWRY7csxfx6HB+AL_FbyRQ@mail.gmail.com> Subject: Re: [dpdk-dev] [PATCH v2 11/11] devtools: compile all buildable examples with pkg-config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Fri, Nov 13, 2020 at 03:14:14PM +0100, David Marchand wrote: > On Fri, Nov 13, 2020 at 3:06 PM Bruce Richardson > <bruce.richardson@intel.com> wrote: > > > > On Fri, Nov 13, 2020 at 01:24:30PM +0100, David Marchand wrote: > > > Rather than just installing all examples, we can use the build checks to > > > filter out any examples that are missing dependencies or are otherwise > > > unbuildable on the current system. > > > Introduce a new "buildable" special value for the -Dexamples= meson > > > option, this way existing behavior on installing all examples is > > > preserved. > > > > > > Select only buildable examples and test their compilation for the > > > x86-default target. > > > > > > Note for maintainers/users of the script: for existing environments, > > > the x86-default target might get broken by this patch since the script > > > now tries to build all "installed" examples and dependencies for some > > > might be unfulfilled. > > > To fix this temporary situation, you can either delete the whole > > > directory or reconfigure it: > > > $ meson configure $DPDK_BUILD_TEST_DIR/build-x86-default \ > > > -Dexamples=buildable > > > > > > Suggested-by: Bruce Richardson <bruce.richardson@intel.com> > > > Signed-off-by: David Marchand <david.marchand@redhat.com> > > > --- > > > Changelog since v1: > > > - rebased on main, > > > - introduced a new "buildable" special value for the -Dexamples option, > > > - installation of the "multi-level" examples has been fixed, so > > > corresponding exceptions have been removed, > > > - a fix for the vhost is waiting in next-virtio, I assume it will get > > > pulled before this series, > > > - the only remaining exception is for vm_power_manager which is broken, > > > > > > --- > > I'm not sure my "suggested-by" should be on this, since the idea of adding > > I was not sure how to credit my copying of the meson bits :-). > > > > an extra buildable option is not mine here. I actually think I prefer the > > previous approach based on your original suggestion of always skipping > > unbuildable examples. Two reasons for that: > > * I'm not fully sure of the value of installing examples that can't be > > built, which was the original issue you raised. > > Thomas objected that all examples have always been provided regardless > of the configuration. > The examples serve as documentation and the API/guides documentations > are all compiled anyway. > Since we are looking to start adding in checks for features into the example makefiles, I'd go with continuing the policy of just shipping them all [1]. Over time we can update the makefiles to start adding proper build error messages with explanations in cases where examples are missing dependencies. /Bruce [1] http://patches.dpdk.org/patch/83911/