From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7E3FA09E0; Sat, 14 Nov 2020 23:02:01 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E5BF8C88E; Sat, 14 Nov 2020 23:01:59 +0100 (CET) Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by dpdk.org (Postfix) with ESMTP id 350A2C882 for <dev@dpdk.org>; Sat, 14 Nov 2020 23:01:58 +0100 (CET) Received: by mail-lj1-f195.google.com with SMTP id y16so15286977ljk.1 for <dev@dpdk.org>; Sat, 14 Nov 2020 14:01:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KscEPDTCij/jhyY+39uw48ioBLKdNorJzn7vvpeNpXs=; b=bbU49Moj7Nt6jy8Omdq09iH4s27nooq47amjfP5neq8k4uJHGztLL0w7YP2joNKKRx LxAGR9koc1Z2yY5tWnvYlhcJ2MUIN9HqMROj2yCWhGL6Obel0u94puhBiRHKCaf/7eXj r6k0UMRhApF113KSERwAumbDuggOdsme2GbeMV/bRX4aMa+Wm8KWwlcpONj+xjLgFPpy Ehia4/ADiqcumEhsglO+IpDSa16vdQfJj0LbGsSZXtJmTYo85H16OVQaSysvEeCp7U3k PJ1TKB7iAGuns0PGLNJrKPKZPshgBGPneKJ9/vqhI6lomVXqjDnujMATzT3qTzu+XfDf +Gtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KscEPDTCij/jhyY+39uw48ioBLKdNorJzn7vvpeNpXs=; b=bmjt2XLWHT/sk/d4w7drv6XtyWHGFF0U8J5wQy7FEonDdlBhkODIJvKrgY8SA4UC6S mI59WSvKJr87WupUJSW8jjW9/PIkLKzPc/wNWsUlD6t9fXEoelKd/tJIyIDUaqKkoqth b1fvTm9yVcu2jN2ghOsJ8DAAnSinDtfQYMWyL+8SXmqidEBff4/g7uMqQ4nrgkpzgsR0 A2OMvUtY1Oq3urz9SzdLM8/3J2FGgJ/F9HuKvKgWe7H7ZXx5Vix85DtF1y3gFYGpiRsW IQlK5kFLz8kLJHc9elhgX4q+KGer4vzdlvLa5EhSBwY0oJ88k7VQK+CBEygDBdlfvKVh wndg== X-Gm-Message-State: AOAM532hqLHPfUdhoXiMEJFozbrG/qRvY7s1NjkPNrAl7db3JQcY5y5b fMDJp0HlECKB2Lhti3ugR5U= X-Google-Smtp-Source: ABdhPJwNfkyWxD6t2HzdxJeK81/8RRo5Hm82SPur/a1QKi1mKZJiXZ00kSonl9DaAmEX/NBAsrRZ8g== X-Received: by 2002:a2e:9244:: with SMTP id v4mr3424201ljg.438.1605391317710; Sat, 14 Nov 2020 14:01:57 -0800 (PST) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id d26sm2168055ljj.102.2020.11.14.14.01.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Nov 2020 14:01:56 -0800 (PST) Date: Sun, 15 Nov 2020 01:01:55 +0300 From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> To: Tal Shnaiderman <talshn@nvidia.com> Cc: dev@dpdk.org, thomas@monjalon.net, navasile@linux.microsoft.com, dmitrym@microsoft.com, pallavi.kadam@intel.com Message-ID: <20201115010155.06bcd0ea@sovereign> In-Reply-To: <20201114211156.17196-1-talshn@nvidia.com> References: <20201114211156.17196-1-talshn@nvidia.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal/windows: definition for ETOOMANYREFS errno X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Sat, 14 Nov 2020 23:11:56 +0200, Tal Shnaiderman wrote: > The ETOOMANYREFS errno is missing from the Windows clang build > is it used in initialization of flow error structures. "is it" -> "it is" > The commit will define it as it is done in the minGW Windows build. "The commit will" is unnecessary. "minGW" -> "MinGW" > Signed-off-by: Tal Shnaiderman <talshn@nvidia.com> > --- > lib/librte_eal/windows/include/rte_os.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_eal/windows/include/rte_os.h b/lib/librte_eal/windows/include/rte_os.h > index 569ed92d51..2a91ebf6a1 100644 > --- a/lib/librte_eal/windows/include/rte_os.h > +++ b/lib/librte_eal/windows/include/rte_os.h > @@ -90,6 +90,7 @@ eal_strerror(int code) > } > > #define strerror eal_strerror > +#define ETOOMANYREFS WSAETOOMANYREFS > > #endif /* RTE_TOOLCHAIN_GCC */ Should be #define ETOOMANYREFS 10059 /* WSAETOOMANYREFS */ for all toolchains: 1. Users of librte_ethdev, who check for ETOOMANYREFS, may not wish to include <winsock2.h> because of its defines that break librte_net headers. 2. Now that I looked closely, MinGW-w64's #define ETOOMANYREFS WSAETOOMANYREFS is under #if 0 clause (for documentation?). Apologies for earlier misinformation.