[dpdk-dev] [PATCH] examples/multi_process: add missing SPDX header to Makefile

[dpdk-dev] [PATCH] examples/multi_process: add missing SPDX header to Makefile

[Stephen Hemminger]

Make is still used for these examples, so add header to Makefile

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 examples/multi_process/Makefile                  | 3 +++
 examples/multi_process/client_server_mp/Makefile | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/examples/multi_process/Makefile b/examples/multi_process/Makefile
index f0a999745a7d..937d00faa313 100644
--- a/examples/multi_process/Makefile
+++ b/examples/multi_process/Makefile
@@ -1,3 +1,6 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2010-2014 Intel Corporation
+
 subdirs := client_server_mp hotplug_mp simple_mp symmetric_mp
 
 .PHONY: all static shared clean $(subdirs)
diff --git a/examples/multi_process/client_server_mp/Makefile b/examples/multi_process/client_server_mp/Makefile
index e8debdfd9ac7..fbe6d67a7771 100644
--- a/examples/multi_process/client_server_mp/Makefile
+++ b/examples/multi_process/client_server_mp/Makefile
@@ -1,3 +1,6 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2010-2014 Intel Corporation
+
 subdirs := mp_client mp_server
 
 .PHONY: all static shared clean $(subdirs)
-- 
2.27.0

Re: [dpdk-dev] [PATCH] examples/multi_process: add missing SPDX header to Makefile

[Bruce Richardson]

On Sun, Nov 15, 2020 at 06:23:47PM -0800, Stephen Hemminger wrote:
> Make is still used for these examples, so add header to Makefile
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  examples/multi_process/Makefile                  | 3 +++
>  examples/multi_process/client_server_mp/Makefile | 3 +++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/examples/multi_process/Makefile b/examples/multi_process/Makefile
> index f0a999745a7d..937d00faa313 100644
> --- a/examples/multi_process/Makefile
> +++ b/examples/multi_process/Makefile
> @@ -1,3 +1,6 @@
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(c) 2010-2014 Intel Corporation
> +
These two Makefiles are actually completely new, replacing the older ones,
so the year should probably be 2020 just (or else 2010-2020 if you want to
keep connection to the older ones). This is also why the old notice
disappeared, as the old file was deleted before the new was created.

/Bruce

[dpdk-dev] [PATCH v2] examples/multi_process: fix missing SPDX headers

[Bruce Richardson]

The makefiles for some of the multi_process example files were missing
SPDX license headers, so add them. These Makefiles completely replaced
the older makefiles and were written from scratch, not based on previous
versions, so add a new copyright year on them.

Fixes: 13abe17c3cd4 ("examples/multi_process: convert to pkg-config-based build")

Suggested-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
v2: adjust copyright year to reflect year of authorship
    add more detail and fixes line to commit log.
---
 examples/multi_process/Makefile                  | 3 +++
 examples/multi_process/client_server_mp/Makefile | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/examples/multi_process/Makefile b/examples/multi_process/Makefile
index f0a999745..e55204495 100644
--- a/examples/multi_process/Makefile
+++ b/examples/multi_process/Makefile
@@ -1,3 +1,6 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2020 Intel Corporation
+
 subdirs := client_server_mp hotplug_mp simple_mp symmetric_mp

 .PHONY: all static shared clean $(subdirs)
diff --git a/examples/multi_process/client_server_mp/Makefile b/examples/multi_process/client_server_mp/Makefile
index e8debdfd9..f4cab6313 100644
--- a/examples/multi_process/client_server_mp/Makefile
+++ b/examples/multi_process/client_server_mp/Makefile
@@ -1,3 +1,6 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2020 Intel Corporation
+
 subdirs := mp_client mp_server

 .PHONY: all static shared clean $(subdirs)
--
2.25.1

Re: [dpdk-dev] [PATCH v2] examples/multi_process: fix missing SPDX headers

[David Marchand]

On Mon, Nov 16, 2020 at 10:36 AM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> The makefiles for some of the multi_process example files were missing
> SPDX license headers, so add them. These Makefiles completely replaced
> the older makefiles and were written from scratch, not based on previous
> versions, so add a new copyright year on them.
>
> Fixes: 13abe17c3cd4 ("examples/multi_process: convert to pkg-config-based build")
>
> Suggested-by: Stephen Hemminger <stephen@networkplumber.org>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks.


-- 
David Marchand