From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6F817A04B5; Mon, 16 Nov 2020 16:30:41 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0086D323E; Mon, 16 Nov 2020 16:30:39 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id AF9FC31FC for <dev@dpdk.org>; Mon, 16 Nov 2020 16:30:36 +0100 (CET) IronPort-SDR: tCi3yANQTt5hZoT89EoQrGL0xhcbXJc6S8Tog49IfAJpROYRQu0a5th5YtTXoRuGAC2ekJkQP+ VC1P5tkQJ8Ig== X-IronPort-AV: E=McAfee;i="6000,8403,9807"; a="232378512" X-IronPort-AV: E=Sophos;i="5.77,482,1596524400"; d="scan'208";a="232378512" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2020 07:30:35 -0800 IronPort-SDR: fzXfr2ktRwAun06FxkgvGdUDOGdAc8tTiWdTnvCttzUTBsqrs7fOyLggwsxQE7jhhTAjEsktng JJtRozrnpsKA== X-IronPort-AV: E=Sophos;i="5.77,482,1596524400"; d="scan'208";a="329712272" Received: from bricha3-mobl.ger.corp.intel.com ([10.251.82.79]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 16 Nov 2020 07:30:34 -0800 Date: Mon, 16 Nov 2020 15:30:30 +0000 From: Bruce Richardson <bruce.richardson@intel.com> To: Thomas Monjalon <thomas@monjalon.net> Cc: David Marchand <david.marchand@redhat.com>, dev <dev@dpdk.org> Message-ID: <20201116153030.GC1469@bricha3-MOBL.ger.corp.intel.com> References: <20201112163901.1728959-1-thomas@monjalon.net> <CAJFAV8xjRKWFSrZ=Y=BU-MVecsm37qUr8f=kRahq+=xsUz-i_Q@mail.gmail.com> <5412819.EXT4iZhqdP@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5412819.EXT4iZhqdP@thomas> Subject: Re: [dpdk-dev] [PATCH 1/1] devtools: rename build test verbosity variables X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Mon, Nov 16, 2020 at 03:44:33PM +0100, Thomas Monjalon wrote: > 16/11/2020 15:27, David Marchand: > > On Thu, Nov 12, 2020 at 5:39 PM Thomas Monjalon <thomas@monjalon.net> wrote: > > > > > > For consistency with other variables which can be set from the env, > > > TEST_MESON_BUILD_VERBOSE and TEST_MESON_BUILD_VERY_VERBOSE > > > are renamed > > > DPDK_BUILD_TEST_VERBOSE and DPDK_BUILD_TEST_VERY_VERBOSE. > > > > It seems a bit odd to take inputs from both the script parameters and > > the env to control something. > > Those TEST_MESON_BUILD* vars seem internal stuff that should not be exposed. > > I have the same opinion. > I cannot find a good reason for controlling verbosity > with environment variables instead of parameters. > > Bruce is there a reason we are missing? > > See the commit 4bcb9b7686043f: > " > When running ninja, the commands are, by default, always printed on top of > each other. For those who want more detail in the output, two levels of > verbose output has been added to the test-meson-builds script. When "-v" is > passed, or the "TEST_MESON_BUILD_VERBOSE" flag is set in the environment, > then the output of ninja is passed through "cat" to prevent each line > overwriting the next. If "-vv" is passed, or > "TEST_MESON_BUILD_VERY_VERBOSE" is set in the environment, then ninja is > called with the "-v" flag to print out each command in full as it is > executing. > " No particular reason, it was just that many other things seemed to be controlled by env variables (or read from config into environment), so I added that as an option too. Feel free to just drop it in favour of the flags if you like. /Bruce