DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] usertools/devbind: fix binding for built-in kernel drivers
@ 2020-11-18  2:40 Yongxin Liu
  0 siblings, 0 replies; only message in thread
From: Yongxin Liu @ 2020-11-18  2:40 UTC (permalink / raw)
  To: dev, anatoly.burakov, thomas

In commit 681a67288 ("usertools: check if module is loaded before
binding"), script will exit if no driver is found in /sys/module/.

However, for build-in kernel driver, /sys/module/MODULENAME only
shows up if it has a version or at least one parameter. Take ixgbe
for example, after kernel commit 34a2a3b83e2c ("net/intel: remove
driver versions from Intel drivers"), and if ixgbe is built directly
into kernel, there is no ixgbe folder in /sys/module. So the devbind
script should not exit.

Signed-off-by: Yongxin Liu <yongxin.liu@windriver.com>
 usertools/dpdk-devbind.py | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
index 99112b7ab..f3c0d9814 100755
--- a/usertools/dpdk-devbind.py
+++ b/usertools/dpdk-devbind.py
@@ -530,10 +530,6 @@ def bind_all(dev_list, driver, force=False):
         # driver generated error - it's not a valid device ID, so all is well
-    # check if we're attempting to bind to a driver that isn't loaded
-    if not module_is_loaded(driver.replace('-','_')):
-        sys.exit("Error: Driver '%s' is not loaded." % driver)
         dev_list = map(dev_id_from_dev_name, dev_list)
     except ValueError as ex:

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-11-18  2:45 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-18  2:40 [dpdk-dev] [PATCH] usertools/devbind: fix binding for built-in kernel drivers Yongxin Liu

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git