From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF1CDA04E6; Wed, 18 Nov 2020 03:45:10 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 92384592C; Wed, 18 Nov 2020 03:45:08 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2076.outbound.protection.outlook.com [40.107.220.76]) by dpdk.org (Postfix) with ESMTP id 4E1F858C4 for ; Wed, 18 Nov 2020 03:45:06 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BgsxD10Wc5ErYc3pBI9NY8ciUPH0dSqqoeK7nk/N09xm+QaGGUK/7xmN9N9+DXi3umJlvL1yTBmqnSwU6uUECOCYoD10MqPBw/N0vw+virxit9T4kf9GW3E0mp0sD45+gIrVa44+NXu2D6nJhU8DwuQo3k7SdA41KVnQ2eEQShqKvRf6T9aQRLacu0ji065+2SxI3nA+BjtIVTGs6n2vcc7EM2KYE8pYk/aojAoMEQNPvztUm6Qp0RL38fWxuu8fK/6PZLnvVtmt10aYMHAvAo21/MEENKtstCS8CtkbTqzC+k3tSzfeHrLT2ljAKTKKSkr5XytBnCOAmrPynut0zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8xtAOSCRBJ1VXoa8m/pxfTnealyNQGNd5k2N48oluB0=; b=V2cyUkDZQ957mDIVkeGtbz9/EwE5Rejncrawg69s6eAltS1PUeEwTH0Ngz1fdlRU5hWTSaGdmkv30lHvxhDNptEjm0lucx94EmgyCrVacG1mBPtWb/qXmC34eh59QezWPh8tCyipU+mSxuY8KlEqj5uDaOsO1mMBqaiDr22gWc79PrQAKxiYwU4C/iZ/1ZRbnDgaY3sjOBkWtQUm119TSzr7GMNdMcnugN5rKq1v1rZRciy62I/B2FF4OvpR7l7R/MldaKgKWDJPzutUPN2USPRRlxx1qV2tOOZ+dA+rZTvAHWN4RN8WwyjPhtSqWKJJKQnbcMfB/zkHl35yBGg6lA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriversystems.onmicrosoft.com; s=selector2-windriversystems-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8xtAOSCRBJ1VXoa8m/pxfTnealyNQGNd5k2N48oluB0=; b=MCncynTJqW7FsfHlpQlNZCpiGqhO3rsZb3DvAqpHsBxpC+wbHm3hvrxIvWPJ3QB0eaz3R6s+Nsst6XCPD2pFm0iE6y5+s0VqYjM+kp8OKc5drISGDqhv/K8eK/lTbx1CZGocZtoiMmDHuQ1jaSWqnWpS3lv6Xkkvg6ijYZRXdPc= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=windriver.com; Received: from BYAPR11MB2600.namprd11.prod.outlook.com (2603:10b6:a02:c8::15) by SJ0PR11MB4815.namprd11.prod.outlook.com (2603:10b6:a03:2dd::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.28; Wed, 18 Nov 2020 02:45:03 +0000 Received: from BYAPR11MB2600.namprd11.prod.outlook.com ([fe80::9c3a:15e0:fe83:ffd9]) by BYAPR11MB2600.namprd11.prod.outlook.com ([fe80::9c3a:15e0:fe83:ffd9%7]) with mapi id 15.20.3564.028; Wed, 18 Nov 2020 02:45:03 +0000 From: Yongxin Liu To: dev@dpdk.org, anatoly.burakov@intel.com, thomas@monjalon.net Date: Wed, 18 Nov 2020 10:40:45 +0800 Message-Id: <20201118024045.32341-1-yongxin.liu@windriver.com> X-Mailer: git-send-email 2.14.4 Content-Type: text/plain X-Originating-IP: [60.247.85.82] X-ClientProxiedBy: HK2PR06CA0010.apcprd06.prod.outlook.com (2603:1096:202:2e::22) To BYAPR11MB2600.namprd11.prod.outlook.com (2603:10b6:a02:c8::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pek-lpggp6.wrs.com (60.247.85.82) by HK2PR06CA0010.apcprd06.prod.outlook.com (2603:1096:202:2e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.20 via Frontend Transport; Wed, 18 Nov 2020 02:45:02 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 95ff4a7e-1387-4820-103c-08d88b6bf339 X-MS-TrafficTypeDiagnostic: SJ0PR11MB4815: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1265; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PZXUJjD5o4fg5QcfUES6yuWYGT2+3pYa2rX6OaPeeDkXGRNwoWimKFaquwcwltmoYobE7tdaY4JXZCKHabTR2iq2wjJQIIEXwR2Xyyyhx60r1K5Ri/VaB95vbk4T76T1cB/UxE0awiv3tTQSmh2uxEo3CGbu0U0Z25zQpBOaj991Ez1Yl6V/x3/yRiZfOJr62VeeGedM/diRmH4O1d7IBpzrkizYZr55vnUGrOFnmI53RGX+UBQnoDi88je3eU7HBFGKVSpsLXvgeD422KghqiejTrmCh/9OIDZ+es4R1pILYl9NJdo1W4Z/XyICw6EmGIFAM/d4AKrkYGp/5Wuulg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB2600.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(39850400004)(366004)(136003)(396003)(16526019)(66556008)(6506007)(1076003)(186003)(6486002)(6512007)(44832011)(316002)(2616005)(478600001)(5660300002)(26005)(956004)(52116002)(66476007)(66946007)(6666004)(83380400001)(8676002)(86362001)(8936002)(2906002)(36756003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 6WMNNFpQ+KHdJkOxOhHURMBbfjoChIgqbtVkwRuZs4EbOt5Y3cC3aQTF2JEcDwpW/t+fhIWcNR346t+z3gfFuYAXWt0zwU7XuEljI9vnvgXm+hRL5c39Oo9VjlgRGn8tg4mxILWL721f0XvXowq4+BEC1wSnDipd07S5Q48w7t5cymgn+JRSlb0eT8qLKEVZfbvyGgsc0hh6RKMI0T5y7WjctDNniOUJfyjHFnghSaEydWuoVGle8U1sRnlSBbCQAld2865DGVcH42ufJkrg7kf3uAhPVD5ECwOW1GulvBTxSsXmWzIHoqfJHdbj0d/Ne1tNPWd2BN8Xw9cXgJHL5ntkyQhE9tMByTC2mbyKMHdVkRC4OraxnWNHFEgltUw7EEhV32cfyxLQR/EnetJAQI5q6tLIDjB58GQ3ZdT6hZfLlrqwWm1Dw4bP9XBoSMt/ND3i/iVKveNFHsLqJJUxJSfiijAhVvbAZGSAg51Ln9ypbvAUrZBemGL3eosHdNX1iaceoFAI5/52cQI43Qb4gM42c+nmTRJaVPJ/qxUKCiT1VZG67qaSOp8NgASJOvmxxn0a4P9DreJ4qg0NcfpDDwdaPMlYPFsMMPq8SaPsxrVl2socu4I5ZAsQN1zc/z81wTHQ/ffU7EadkzgjLG3WiQ== X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: 95ff4a7e-1387-4820-103c-08d88b6bf339 X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB2600.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2020 02:45:03.4588 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DvTRKB6rshLjm8gIpwrWSAUif3asmiVwxw9RSBggeacoiHDfJoxOR8iYzV4/7gM6UQUcVlisCnYa8TLk/ZcMhxK5bXVND72XOJpltyOE1uY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4815 Subject: [dpdk-dev] [PATCH] usertools/devbind: fix binding for built-in kernel drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In commit 681a67288 ("usertools: check if module is loaded before binding"), script will exit if no driver is found in /sys/module/. However, for build-in kernel driver, /sys/module/MODULENAME only shows up if it has a version or at least one parameter. Take ixgbe for example, after kernel commit 34a2a3b83e2c ("net/intel: remove driver versions from Intel drivers"), and if ixgbe is built directly into kernel, there is no ixgbe folder in /sys/module. So the devbind script should not exit. Signed-off-by: Yongxin Liu --- usertools/dpdk-devbind.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py index 99112b7ab..f3c0d9814 100755 --- a/usertools/dpdk-devbind.py +++ b/usertools/dpdk-devbind.py @@ -530,10 +530,6 @@ def bind_all(dev_list, driver, force=False): # driver generated error - it's not a valid device ID, so all is well pass - # check if we're attempting to bind to a driver that isn't loaded - if not module_is_loaded(driver.replace('-','_')): - sys.exit("Error: Driver '%s' is not loaded." % driver) - try: dev_list = map(dev_id_from_dev_name, dev_list) except ValueError as ex: -- 2.14.4