From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A45C3A04E6; Wed, 18 Nov 2020 04:03:35 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DACBA58C4; Wed, 18 Nov 2020 04:03:33 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2047.outbound.protection.outlook.com [40.107.94.47]) by dpdk.org (Postfix) with ESMTP id 0174E4C90 for ; Wed, 18 Nov 2020 04:03:31 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E7l24t6iavReY+UauSCs6vBB1zXCdA4waIoUgzPV5X+ykg+Q1/kz68lseyP8u5CRjU2Z+ewwJ9hCOg+l/YgGCmWDRv7gP/jsphm6N+jqwMH4xuiz0H1sxGSFbhmdWEzxj2a0zz63Mpl/0srPEOnScbGYkcovICHz24u+hVMEM3TgwK9V9CB5tMJDyxfG7QqbK1VViloFTQeBqKyFQ4WbJ9vy7Nu21i96/rkmm68db4aAF9EH2M04RSULkjH3NfTgXwvFNYOU0lMdll8hiXo07eUsFG2d7eVr8WCNdFoxALME3c8Q0w9QKOVNWMVFJpwmHnL5H1Q81dcsusfPk5V+8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w2RGS9Uxa4mGTUwpWDl8WeJVjDsNusjJ+ZkU9iokkYc=; b=kyZQJqV2Vm737z5sXAT6ovDUIPjtuiDvV9R37wyBRS9qJvt/INhnYAfSO9cWXl6UA8ldnOF2RnzCMuJz0E5LCX4w3WekFggkmNQlRXfVb/sUISvmpB0bEsKenXhUNiVtg2M9oSfMOuyINuusrSxOvQREPHZTPEgGSbzyjMVExslm34SJNVMWWbhLhmkDPX/OSunHiUVtl1Imx1iBNbTRgXnPABPl1W7DzAvqfWqkm3eeWUuBxroT36JMnv/gMDprYqkb7Gdjij5VXsWeSsM4Rg/KnYmihBOYntWINocwZ9zIvn4Q8vj2+iXQf/j3vJxm68X6+fOSB4c3W0ZAENv2hg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriversystems.onmicrosoft.com; s=selector2-windriversystems-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w2RGS9Uxa4mGTUwpWDl8WeJVjDsNusjJ+ZkU9iokkYc=; b=XFiQEG8tg9iA818bUobS8iHP6LV+kD+hhcDIk2532XLMqBYxXl7aipJyH1OaIXb+zwxjpyKA19o0hi73ayi/obGutTIbDhBO0DSdlQcTVTICgYltcoRIthJcTUvC7B4IaneRZmlj9wYnSR34m8xXGxdWZqP5hU+yOY+xbHQRn6I= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=windriver.com; Received: from BYAPR11MB2600.namprd11.prod.outlook.com (2603:10b6:a02:c8::15) by BYAPR11MB3669.namprd11.prod.outlook.com (2603:10b6:a03:f7::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.28; Wed, 18 Nov 2020 03:03:29 +0000 Received: from BYAPR11MB2600.namprd11.prod.outlook.com ([fe80::9c3a:15e0:fe83:ffd9]) by BYAPR11MB2600.namprd11.prod.outlook.com ([fe80::9c3a:15e0:fe83:ffd9%7]) with mapi id 15.20.3564.028; Wed, 18 Nov 2020 03:03:29 +0000 From: Yongxin Liu To: dev@dpdk.org, anatoly.burakov@intel.com, thomas@monjalon.net Date: Wed, 18 Nov 2020 10:58:54 +0800 Message-Id: <20201118025854.13455-1-yongxin.liu@windriver.com> X-Mailer: git-send-email 2.14.4 Content-Type: text/plain X-Originating-IP: [60.247.85.82] X-ClientProxiedBy: HK2PR0401CA0018.apcprd04.prod.outlook.com (2603:1096:202:2::28) To BYAPR11MB2600.namprd11.prod.outlook.com (2603:10b6:a02:c8::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pek-lpggp6.wrs.com (60.247.85.82) by HK2PR0401CA0018.apcprd04.prod.outlook.com (2603:1096:202:2::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.20 via Frontend Transport; Wed, 18 Nov 2020 03:03:27 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1078e4ae-1ecd-4294-12a6-08d88b6e8655 X-MS-TrafficTypeDiagnostic: BYAPR11MB3669: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1265; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kyX0KUGSydEOBtXx7u+f2Jp6YEbk0nvc0nVCoNCJ+0DAZheyX3MQM9DuM7uTaynJW+beFabn7s+nujdaKN7L1Ondi0EeWsICuqTzSseFLCMDgfgh9H8hbgcQd+AEHEo8gEsF41tBhzjPQS5v/PKqZvhMBoNA7fWJUdgBqGyqQcfq3cezp3hd/nklJEHERdUhMXfSRVdnmLltXWklbg0dHrDlAUiYMyLJgW1Z9692AMfMQwezeVIiKAeCLs+eeVO0qdG/idm/zdfUD+aRkxapkOob2276PHmV9iHS0WjYrxdBBg+/wjpFPj2KOwcQcRoEJ4RX3/zs5h6nwHBrGE4Vog== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB2600.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39830400003)(136003)(396003)(346002)(366004)(376002)(2616005)(316002)(956004)(186003)(44832011)(52116002)(6506007)(66556008)(26005)(6486002)(66946007)(16526019)(86362001)(1076003)(66476007)(8676002)(478600001)(2906002)(8936002)(83380400001)(5660300002)(36756003)(6512007)(6666004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: +IasGkNX1z7LmM2mGknM7JC1BnjO5zY5vDfQW4BgTy9oc42d2qRVfxUjS1UDb6sCPjbrMxV7LO5QL/SHW5LT2/6CAnPNLcn/G4GVP+q18RHNbAiziOSXcTEkRYRIFqC5tnLint2REkyb5XHY0qAOkPvqgq4MIfyF5ZvHEcAyHyIWqu77xU8hCCWVh8OaU2x0EyUdsPnQeXNS7vx+t6YD5xv1q7p1h0il2L/Kl/0o47TRRFj/Xel8a+T8I6UemtUGSbu37NWO0hpwWRNAxvjCyncinWnMNuvsIDiiF/Zi4J2EZwYqn9uLc/E2oAYPy5llKswDZL/dYqtGKFlgVEnhIGohItPHekXitiSd5WUln5ugGHH2wx+UQBy/ljSBTQQlPJPwy95Vs/skKS304k3dFaIpiovP2qlYiEoAnvlRHxp/rG8DH2bJUPRdLxmQXwI0qiYYwdH6+02CoFvvfZqhFC4l+XYrTn0LPETiwiVKeib3zatjdHQcjLjQV3DxcG50SwEUqa8DudOCQa23kjXEbO0F0bZei/1L79XMiWyXyrBidfjzugEEtNs16aNmGuDLP5Q6nYRpEwUa5AzTP9Vw8KXZqM2eVugZHnGUvX7L0kOtFsHBbFpfzQrTZgcKUVgvqMvsIbvqn5peigVQ5+JT1Q== X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1078e4ae-1ecd-4294-12a6-08d88b6e8655 X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB2600.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2020 03:03:29.2419 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 44QxloiyYS4X65o5xTlE6kfkp2wd11dWMuNLSpjp5Oxjqhlrp+IhyO712sKs6QzRYCzxAwwz0cjGC9Zer1kA3gHQsCj/lQ7hsjpydyq57qA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3669 Subject: [dpdk-dev] [PATCH v2] usertools/devbind: fix binding for built-in 1kernel drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In commit 681a67288655 ("usertools: check if module is loaded before binding"), script will exit if no driver is found in /sys/module/. However, for built-in kernel driver, /sys/module/MODULENAME only shows up if it has a version or at least one parameter. Take ixgbe for example, after kernel commit 34a2a3b83e2c ("net/intel: remove driver versions from Intel drivers"), and if ixgbe is built directly into kernel, there is no ixgbe folder in /sys/module. So the devbind script should not exit. Signed-off-by: Yongxin Liu --- v2: - fix git commit description style in commit log - fix typo spelling --- usertools/dpdk-devbind.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py index 99112b7ab..f3c0d9814 100755 --- a/usertools/dpdk-devbind.py +++ b/usertools/dpdk-devbind.py @@ -530,10 +530,6 @@ def bind_all(dev_list, driver, force=False): # driver generated error - it's not a valid device ID, so all is well pass - # check if we're attempting to bind to a driver that isn't loaded - if not module_is_loaded(driver.replace('-','_')): - sys.exit("Error: Driver '%s' is not loaded." % driver) - try: dev_list = map(dev_id_from_dev_name, dev_list) except ValueError as ex: -- 2.14.4