From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED8C0A04E6; Thu, 19 Nov 2020 20:01:36 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2B1E0F3E; Thu, 19 Nov 2020 20:01:35 +0100 (CET) Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by dpdk.org (Postfix) with ESMTP id E93BB98 for ; Thu, 19 Nov 2020 20:01:32 +0100 (CET) Received: by mail-pg1-f176.google.com with SMTP id m9so5076500pgb.4 for ; Thu, 19 Nov 2020 11:01:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=C1vXach0CTtp/17wCV0uTOcWprmIqgFzkUWmmqg++DA=; b=agcMWkxvyu3So0KR1FEaw67QmnZFSzL73vuP4wzuwb0ovC+eOFq0mBV7NwLxEfVudt WEwn+f8zK667ytZR+re457+LdwaH9d6NTJQe+QRYRKwFI4QzdYhiyc69W4qwf8qtjude cMUa4PX9AvImmvvQ+OCBNiAii1lGnI9Xx7DJMKDW1pmL5we4lwRfDUGvFbY2xP3CHNDa ml4/97tNJCNO0KVnbMTwiu5R449j5qmiTXAF0aNlAR/BzlMHk9iWQVpatSBYxZMd7p9q wYCOnzSaVOHfNSNQhlKWOaGlYqrDQj8QFhyQ8IFk806mO/WKWuEf+BrrCMsfG4t/GU3n foiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=C1vXach0CTtp/17wCV0uTOcWprmIqgFzkUWmmqg++DA=; b=Ukgg+trQwNatK4Ms4L6sc0dMEV9zOKi0KucDJ/pQ/eF4N1VA+tcAbBCITTTJV9xP85 tZDBTglDIgtdV8b4mAXrqRGx6FTD2Mg5ljYfbRWMEXs4lXQJsrCNs0pWtvNCfzt/7FBN xJpXytM0xD/x5ZwmnuP1XW8bseshOIefE+bAKTJhIMU97Hh5ckqopN1PmKP2a63C8yZL HkohphjCtAM2H8GYfWSUyUD+0mEgb7iQ5dpZCoEVjO8sMXFoifsRiV4b79VEgYN1ITCv M7yKDIkp1vCmea5M4DNN+JqLQ12KZy6bzITmr1U3OL3NX8lDKqTWrsKLmSdo0RLvQThD sEhw== X-Gm-Message-State: AOAM533hsj0qms7CGKShaXSLkGr/hZf1WZPKEfjaJZb19o7niYvgp2V5 wBUGh+w0hIjjOY9Uwwj7mF3CUg== X-Google-Smtp-Source: ABdhPJw4rRe2st6PgvxosofC4f7sBULIK21mH5IwQMC99wVsHQSksHsVvHP+WqVUfsyk20lUd+jG1g== X-Received: by 2002:a65:5907:: with SMTP id f7mr13702843pgu.445.1605812490905; Thu, 19 Nov 2020 11:01:30 -0800 (PST) Received: from hermes.local (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id e10sm596961pfh.38.2020.11.19.11.01.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Nov 2020 11:01:30 -0800 (PST) Date: Thu, 19 Nov 2020 11:01:14 -0800 From: Stephen Hemminger To: Ferruh Yigit Cc: Jerin Jacob , Cristian Dumitrescu , Hemant Agrawal , Sachin Saxena , Ray Kinsella , Neil Horman , Rosen Xu , Jingjing Wu , Beilei Xing , Nithin Dabilpuram , Ajit Khaparde , Raveendra Padasalagi , Vikas Gupta , Gagandeep Singh , Somalapuram Amaranath , Akhil Goyal , Jay Zhou , Timothy McDaniel , Liang Ma , Peter Mccarthy , Shepard Siegel , Ed Czeck , John Miller , Igor Russkikh , Pavel Belous , Rasesh Mody , Shahed Shaikh , Somnath Kotur , Chas Williams , "Min Hu (Connor)" , Rahul Lakkireddy , Jeff Guo , Haiyue Wang , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Igor Chauskin , Qi Zhang , Xiao Wang , Qiming Yang , Alfredo Cardigliano , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Zyta Szpak , Liron Himi , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Long Li , Heinrich Kuhn , Harman Kalra , Kiran Kumar K , Andrew Rybchenko , Jasvinder Singh , Jiawen Wu , Jian Wang , Tianfei zhang , Ori Kam , Guy Kaneti , Anatoly Burakov , Maxime Coquelin , Chenbo Xia , dev@dpdk.org Message-ID: <20201119110114.3886e2a1@hermes.local> In-Reply-To: <20201119035238.3653702-1-ferruh.yigit@intel.com> References: <20201119035238.3653702-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC] remove unused functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 19 Nov 2020 03:52:36 +0000 Ferruh Yigit wrote: > drivers/net/netvsc/hn_rndis.c | 31 - > drivers/net/netvsc/hn_rndis.h | 1 - > drivers/net/netvsc/hn_var.h | 3 - > drivers/net/netvsc/hn_vf.c | 25 - Thanks this found some real bugs. 1. The get_supported_ptypes is wrong, the driver should just not support it. 2. VF stats need to get reset 3. VX tx_queue release call needs to be added. Sent tentative patches off for testing.