From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 3E321A04DD;
	Thu, 19 Nov 2020 13:02:49 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 23B4DC96A;
	Thu, 19 Nov 2020 12:59:33 +0100 (CET)
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id BDB7CC942;
 Thu, 19 Nov 2020 12:59:26 +0100 (CET)
IronPort-SDR: BHjEe47WG4EP6kspstr0Xrzau3AIOTvUMJsRqVMSi+LfLBn2YXi1B20DFDiVbr0KccvkFoC9w8
 Da8lJujgnrkA==
X-IronPort-AV: E=McAfee;i="6000,8403,9809"; a="170494420"
X-IronPort-AV: E=Sophos;i="5.77,490,1596524400"; d="scan'208";a="170494420"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 19 Nov 2020 03:59:26 -0800
IronPort-SDR: eNEuScP3Upp5IimpSt4Rb1OXgTSJPpNDLf0eHmGi0Yi5yxofeFpYENBXTGv3y8QPadR+lOQ9xw
 Hs0GgccdarHw==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.77,490,1596524400"; d="scan'208";a="341665331"
Received: from silpixa00399752.ir.intel.com (HELO
 silpixa00399752.ger.corp.intel.com) ([10.237.222.180])
 by orsmga002.jf.intel.com with ESMTP; 19 Nov 2020 03:59:24 -0800
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: dev@dpdk.org, Steven Webster <steven.webster@windriver.com>,
 Matt Peters <matt.peters@windriver.com>,
 Vincent Jardin <vincent.jardin@6wind.com>,
 Allain Legacy <allain.legacy@windriver.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
	stable@dpdk.org
Date: Thu, 19 Nov 2020 11:59:00 +0000
Message-Id: <20201119115900.4095566-11-ferruh.yigit@intel.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20201119115900.4095566-1-ferruh.yigit@intel.com>
References: <20200824094021.2323605-1-ferruh.yigit@intel.com>
 <20201119115900.4095566-1-ferruh.yigit@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [dpdk-dev] [v21.02 v3 10/10] net/avp: remove always true condition
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

There is already a break above for the case "count >= 1", so at this
stage 'count' should be always '0'.

Fixes: 1a85922369c4 ("net/avp: add device configuration")
Cc: stable@dpdk.org

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 drivers/net/avp/avp_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c
index 5f8187b905..f531e03c02 100644
--- a/drivers/net/avp/avp_ethdev.c
+++ b/drivers/net/avp/avp_ethdev.c
@@ -267,7 +267,7 @@ avp_dev_process_request(struct avp_dev *avp, struct rte_avp_request *request)
 			break;
 		}
 
-		if ((count < 1) && (retry == 0)) {
+		if (retry == 0) {
 			PMD_DRV_LOG(ERR, "Timeout while waiting for a response for %u\n",
 				    request->req_id);
 			ret = -ETIME;
-- 
2.26.2