From: Thomas Monjalon <thomas@monjalon.net> To: dev@dpdk.org Cc: david.marchand@redhat.com, andreyv@nvidia.com, talshn@nvidia.com, dmitry.kozliuk@gmail.com, orika@nvidia.com, Matan Azrad <matan@nvidia.com>, Shahaf Shuler <shahafs@nvidia.com>, Viacheslav Ovsiienko <viacheslavo@nvidia.com>, Ferruh Yigit <ferruh.yigit@intel.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> Subject: [dpdk-dev] [PATCH 1/1] ethdev: rename a flow shared action error code Date: Fri, 20 Nov 2020 10:54:38 +0100 Message-ID: <20201120095438.2620653-1-thomas@monjalon.net> (raw) In the experimental function rte_flow_shared_action_destroy() introduced in DPDK 20.11, the errno ETOOMANYREFS was used. This errno is not always available on Windows, so it is preferred using EBUSY instead. Signed-off-by: Thomas Monjalon <thomas@monjalon.net> --- drivers/net/mlx5/mlx5_flow_dv.c | 4 ++-- lib/librte_ethdev/rte_flow.h | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index 62d9ca9ffb..51cc41face 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -11436,14 +11436,14 @@ __flow_dv_action_rss_release(struct rte_eth_dev *dev, uint32_t idx, "invalid shared action"); remaining = __flow_dv_action_rss_hrxqs_release(dev, shared_rss); if (remaining) - return rte_flow_error_set(error, ETOOMANYREFS, + return rte_flow_error_set(error, EBUSY, RTE_FLOW_ERROR_TYPE_ACTION, NULL, "shared rss hrxq has references"); if (!__atomic_compare_exchange_n(&shared_rss->refcnt, &old_refcnt, 0, 0, __ATOMIC_ACQUIRE, __ATOMIC_RELAXED)) - return rte_flow_error_set(error, ETOOMANYREFS, + return rte_flow_error_set(error, EBUSY, RTE_FLOW_ERROR_TYPE_ACTION, NULL, "shared rss has references"); diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h index 8b970ba0b7..b98334c5c4 100644 --- a/lib/librte_ethdev/rte_flow.h +++ b/lib/librte_ethdev/rte_flow.h @@ -3549,8 +3549,7 @@ rte_flow_shared_action_create(uint16_t port_id, * - (-ENOSYS) if underlying device does not support this functionality. * - (-EIO) if underlying device is removed. * - (-ENOENT) if action pointed by *action* handle was not found. - * - (-ETOOMANYREFS) if action pointed by *action* handle still used by one or - * more rules + * - (-EBUSY) if action pointed by *action* handle still used by some rules * rte_errno is also set. */ __rte_experimental -- 2.28.0
next reply other threads:[~2020-11-20 9:55 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-20 9:54 Thomas Monjalon [this message] 2020-11-20 10:54 ` Tal Shnaiderman 2020-11-20 13:10 ` Ferruh Yigit
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201120095438.2620653-1-thomas@monjalon.net \ --to=thomas@monjalon.net \ --cc=andrew.rybchenko@oktetlabs.ru \ --cc=andreyv@nvidia.com \ --cc=david.marchand@redhat.com \ --cc=dev@dpdk.org \ --cc=dmitry.kozliuk@gmail.com \ --cc=ferruh.yigit@intel.com \ --cc=matan@nvidia.com \ --cc=orika@nvidia.com \ --cc=shahafs@nvidia.com \ --cc=talshn@nvidia.com \ --cc=viacheslavo@nvidia.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git