* [dpdk-dev] [PATCH] eal/windows: revert definition of ETOOMANYREFS
@ 2020-11-19 15:43 Tal Shnaiderman
2020-11-19 16:03 ` Nick Connolly
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Tal Shnaiderman @ 2020-11-19 15:43 UTC (permalink / raw)
To: dev
Cc: thomas, dmitry.kozliuk, navasile, dmitrym, pallavi.kadam,
nick.connolly, stable
This reverts commit c917b54b0c743c7a570a4d8df8954c61d8b818c4.
The definition of ETOOMANYREFS is reverted as it breaks build of
external applications already defining it.
Fixes: c917b54b0c ("eal/windows: add definition of ETOOMANYREFS")
Cc: stable@dpdk.org
Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
---
lib/librte_eal/windows/include/rte_os.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/librte_eal/windows/include/rte_os.h b/lib/librte_eal/windows/include/rte_os.h
index 8300ea483a..569ed92d51 100644
--- a/lib/librte_eal/windows/include/rte_os.h
+++ b/lib/librte_eal/windows/include/rte_os.h
@@ -51,8 +51,6 @@ extern "C" {
/* as in <windows.h> */
typedef long long ssize_t;
-#define ETOOMANYREFS 10059 /* WSAETOOMANYREFS */
-
#ifndef RTE_TOOLCHAIN_GCC
static inline int
--
2.16.1.windows.4
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] eal/windows: revert definition of ETOOMANYREFS
2020-11-19 15:43 [dpdk-dev] [PATCH] eal/windows: revert definition of ETOOMANYREFS Tal Shnaiderman
@ 2020-11-19 16:03 ` Nick Connolly
2020-11-20 9:12 ` [dpdk-dev] [dpdk-stable] " David Marchand
2020-11-20 9:25 ` [dpdk-dev] " Dmitry Kozlyuk
2 siblings, 0 replies; 6+ messages in thread
From: Nick Connolly @ 2020-11-19 16:03 UTC (permalink / raw)
To: Tal Shnaiderman, dev
Cc: thomas, dmitry.kozliuk, navasile, dmitrym, pallavi.kadam, stable
Reviewed-by: Nick Connolly <nick.connolly@mayadata.io>
On 19/11/2020 15:43, Tal Shnaiderman wrote:
> This reverts commit c917b54b0c743c7a570a4d8df8954c61d8b818c4.
>
> The definition of ETOOMANYREFS is reverted as it breaks build of
> external applications already defining it.
>
> Fixes: c917b54b0c ("eal/windows: add definition of ETOOMANYREFS")
> Cc: stable@dpdk.org
>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> ---
> lib/librte_eal/windows/include/rte_os.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/lib/librte_eal/windows/include/rte_os.h b/lib/librte_eal/windows/include/rte_os.h
> index 8300ea483a..569ed92d51 100644
> --- a/lib/librte_eal/windows/include/rte_os.h
> +++ b/lib/librte_eal/windows/include/rte_os.h
> @@ -51,8 +51,6 @@ extern "C" {
> /* as in <windows.h> */
> typedef long long ssize_t;
>
> -#define ETOOMANYREFS 10059 /* WSAETOOMANYREFS */
> -
> #ifndef RTE_TOOLCHAIN_GCC
>
> static inline int
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH] eal/windows: revert definition of ETOOMANYREFS
2020-11-19 15:43 [dpdk-dev] [PATCH] eal/windows: revert definition of ETOOMANYREFS Tal Shnaiderman
2020-11-19 16:03 ` Nick Connolly
@ 2020-11-20 9:12 ` David Marchand
2020-11-20 9:17 ` David Marchand
2020-11-20 9:25 ` [dpdk-dev] " Dmitry Kozlyuk
2 siblings, 1 reply; 6+ messages in thread
From: David Marchand @ 2020-11-20 9:12 UTC (permalink / raw)
To: Tal Shnaiderman
Cc: dev, Thomas Monjalon, Dmitry Kozlyuk, Narcisa Ana Maria Vasile,
Dmitry Malloy (MESHCHANINOV),
Pallavi Kadam, Nick Connolly, dpdk stable
On Thu, Nov 19, 2020 at 4:43 PM Tal Shnaiderman <talshn@nvidia.com> wrote:
>
> This reverts commit c917b54b0c743c7a570a4d8df8954c61d8b818c4.
>
> The definition of ETOOMANYREFS is reverted as it breaks build of
> external applications already defining it.
>
> Fixes: c917b54b0c ("eal/windows: add definition of ETOOMANYREFS")
No need to copy stable, the reverted commit is only in the current release.
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
Reviewed-by: Nick Connolly <nick.connolly@mayadata.io>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH] eal/windows: revert definition of ETOOMANYREFS
2020-11-20 9:12 ` [dpdk-dev] [dpdk-stable] " David Marchand
@ 2020-11-20 9:17 ` David Marchand
0 siblings, 0 replies; 6+ messages in thread
From: David Marchand @ 2020-11-20 9:17 UTC (permalink / raw)
To: Dmitry Kozlyuk, Narcisa Ana Maria Vasile,
Dmitry Malloy (MESHCHANINOV),
Pallavi Kadam
Cc: dev, Nick Connolly, dpdk stable, Tal Shnaiderman, Thomas Monjalon
On Fri, Nov 20, 2020 at 10:12 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Thu, Nov 19, 2020 at 4:43 PM Tal Shnaiderman <talshn@nvidia.com> wrote:
> >
> > This reverts commit c917b54b0c743c7a570a4d8df8954c61d8b818c4.
> >
> > The definition of ETOOMANYREFS is reverted as it breaks build of
> > external applications already defining it.
> >
> > Fixes: c917b54b0c ("eal/windows: add definition of ETOOMANYREFS")
>
> No need to copy stable, the reverted commit is only in the current release.
>
> > Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> Reviewed-by: Nick Connolly <nick.connolly@mayadata.io>
>
> Applied, thanks.
Hum, pulling back on this.
I did not see any Windows maintainer opine in the discussion.
Can I get some acks please ?
--
David Marchand
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] eal/windows: revert definition of ETOOMANYREFS
2020-11-19 15:43 [dpdk-dev] [PATCH] eal/windows: revert definition of ETOOMANYREFS Tal Shnaiderman
2020-11-19 16:03 ` Nick Connolly
2020-11-20 9:12 ` [dpdk-dev] [dpdk-stable] " David Marchand
@ 2020-11-20 9:25 ` Dmitry Kozlyuk
2020-11-20 15:01 ` David Marchand
2 siblings, 1 reply; 6+ messages in thread
From: Dmitry Kozlyuk @ 2020-11-20 9:25 UTC (permalink / raw)
To: Tal Shnaiderman
Cc: dev, thomas, navasile, dmitrym, pallavi.kadam, nick.connolly
On Thu, 19 Nov 2020 17:43:10 +0200, Tal Shnaiderman wrote:
> This reverts commit c917b54b0c743c7a570a4d8df8954c61d8b818c4.
>
> The definition of ETOOMANYREFS is reverted as it breaks build of
> external applications already defining it.
>
> Fixes: c917b54b0c ("eal/windows: add definition of ETOOMANYREFS")
> Cc: stable@dpdk.org
>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> ---
Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
On Fri, Nov 20, 2020 at 10:12 AM David Marchand
> <david.marchand@redhat.com> wrote:
>
> Hum, pulling back on this.
> I did not see any Windows maintainer opine in the discussion.
> Can I get some acks please ?
Discussion thread, for the reference:
https://mails.dpdk.org/archives/dev/2020-November/192842.html
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] eal/windows: revert definition of ETOOMANYREFS
2020-11-20 9:25 ` [dpdk-dev] " Dmitry Kozlyuk
@ 2020-11-20 15:01 ` David Marchand
0 siblings, 0 replies; 6+ messages in thread
From: David Marchand @ 2020-11-20 15:01 UTC (permalink / raw)
To: Dmitry Kozlyuk, Tal Shnaiderman
Cc: dev, Thomas Monjalon, Narcisa Ana Maria Vasile,
Dmitry Malloy (MESHCHANINOV),
Pallavi Kadam, Nick Connolly
On Fri, Nov 20, 2020 at 10:26 AM Dmitry Kozlyuk
<dmitry.kozliuk@gmail.com> wrote:
>
> On Thu, 19 Nov 2020 17:43:10 +0200, Tal Shnaiderman wrote:
> > This reverts commit c917b54b0c743c7a570a4d8df8954c61d8b818c4.
> >
> > The definition of ETOOMANYREFS is reverted as it breaks build of
> > external applications already defining it.
> >
> > Fixes: c917b54b0c ("eal/windows: add definition of ETOOMANYREFS")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> > ---
>
> Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Thank you Dmitry.
Applied for real this time.
> On Fri, Nov 20, 2020 at 10:12 AM David Marchand
> > <david.marchand@redhat.com> wrote:
> >
> > Hum, pulling back on this.
> > I did not see any Windows maintainer opine in the discussion.
> > Can I get some acks please ?
>
> Discussion thread, for the reference:
> https://mails.dpdk.org/archives/dev/2020-November/192842.html
And a patch was just merged in next-net for rte_flow.h + mlx5 driver.
http://patchwork.dpdk.org/patch/84411/
--
David Marchand
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-11-20 15:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-19 15:43 [dpdk-dev] [PATCH] eal/windows: revert definition of ETOOMANYREFS Tal Shnaiderman
2020-11-19 16:03 ` Nick Connolly
2020-11-20 9:12 ` [dpdk-dev] [dpdk-stable] " David Marchand
2020-11-20 9:17 ` David Marchand
2020-11-20 9:25 ` [dpdk-dev] " Dmitry Kozlyuk
2020-11-20 15:01 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).