From: Stephen Hemminger <stephen@networkplumber.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: "Zhang, Tianfei" <tianfei.zhang@intel.com>,
Jerin Jacob <jerinj@marvell.com>,
"Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Sachin Saxena <sachin.saxena@oss.nxp.com>,
Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>,
"Xu, Rosen" <rosen.xu@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>,
Vikas Gupta <vikas.gupta@broadcom.com>,
Gagandeep Singh <g.singh@nxp.com>,
Somalapuram Amaranath <asomalap@amd.com>,
Akhil Goyal <akhil.goyal@nxp.com>,
Jay Zhou <jianjay.zhou@huawei.com>,
"McDaniel, Timothy" <timothy.mcdaniel@intel.com>,
"Ma, Liang J" <liang.j.ma@intel.com>,
"Mccarthy, Peter" <peter.mccarthy@intel.com>,
Shepard Siegel <shepard.siegel@atomicrules.com>,
Ed Czeck <ed.czeck@atomicrules.com>,
John Miller <john.miller@atomicrules.com>,
Igor Russkikh <igor.russkikh@aquantia.com>,
Pavel Belous <pavel.belous@aquantia.com>,
Rasesh Mody <rmody@marvell.com>,
Shahed Shaikh <shshaikh@marvell.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Chas Williams <chas3@att.com>,
"Min Hu (Connor)" <humin29@huawei.com>,
Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
"Guo, Jia" <jia.guo@intel.com>,
"Wang, Haiyue" <haiyue.wang@intel.com>,
Marcin Wojtas <mw@semihalf.com>,
Michal Krawczyk <mk@semihalf.com>,
Guy Tzalik <gtzalik@amazon.com>,
Evgeny Schemeilin <evgenys@amazon.com>,
Igor Chauskin <igorch@amazon.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Wang, Xiao W" <xiao.w.wang@intel.com>,
"Yang, Qiming" <qiming.yang@intel.com>,
Alfredo Cardigliano <cardigliano@ntop.org>,
Matan Azrad <matan@nvidia.com>,
Shahaf Shuler <shahafs@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Zyta Szpak <zr@semihalf.com>, Liron Himi <lironh@marvell.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Long Li <longli@microsoft.com>,
Heinrich Kuhn <heinrich.kuhn@netronome.com>,
Harman Kalra <hkalra@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
"Singh, Jasvinder" <jasvinder.singh@intel.com>,
Jiawen Wu <jiawenwu@trustnetic.com>,
Jian Wang <jianwang@trustnetic.com>, Ori Kam <orika@nvidia.com>,
Guy Kaneti <guyk@marvell.com>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
"Xia, Chenbo" <chenbo.xia@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [RFC] remove unused functions
Date: Mon, 23 Nov 2020 08:07:14 -0800 [thread overview]
Message-ID: <20201123080714.7f162723@hermes.local> (raw)
In-Reply-To: <ed4086f7-0111-6d86-05d5-6ceea6b6e6f1@intel.com>
On Mon, 23 Nov 2020 09:56:51 +0000
Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> On 11/23/2020 2:55 AM, Zhang, Tianfei wrote:
> >> drivers/raw/ifpga/base/opae_eth_group.c | 25 -
> >> drivers/raw/ifpga/base/opae_eth_group.h | 1 -
> >> drivers/raw/ifpga/base/opae_hw_api.c | 212 --
> >> drivers/raw/ifpga/base/opae_hw_api.h | 36 -
> >> drivers/raw/ifpga/base/opae_i2c.c | 12 -
> >> drivers/raw/ifpga/base/opae_i2c.h | 4 -
> >> drivers/raw/ifpga/base/opae_ifpga_hw_api.c | 99 -
> >> drivers/raw/ifpga/base/opae_ifpga_hw_api.h | 15 -
> >
> > The ifpga base code is want to provide fully functionality low level hardware support for Intel FPGA card like N3000, even though some APIs are not used by DPDK framework now，but it will useful for end-users or other customers developing their own productions , my opinion is keeping those APIs of ifpga base code in DPDK.
> >
>
> The code is hidden behind the driver code, it is not accessible to user directly.
>
> If the idea is the code can be used later, it can be added when needed.
>
> If the idea is the code can be needed in the field by users, can you please give
> example on the use case?
Dead code is buggy code. Please remove it.
Maintaining dead code increases the overall technical debt.
Dead code is guaranteed not to be tested.
If someone needs it in future they can resurrect it from earlier versions
which will always be there in git.
If Intel wants to support it in DPDK then it should provide API's and tests for it.
next prev parent reply other threads:[~2020-11-23 16:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 3:52 Ferruh Yigit
2020-11-19 7:22 ` Xu, Rosen
2020-11-19 19:01 ` Stephen Hemminger
2020-11-23 2:55 ` Zhang, Tianfei
2020-11-23 9:56 ` Ferruh Yigit
2020-11-23 16:07 ` Stephen Hemminger [this message]
2020-11-24 10:01 ` Zhang, Tianfei
2020-11-24 10:00 ` Zhang, Tianfei
2020-11-24 10:26 ` Ferruh Yigit
2020-11-24 11:01 ` Zhang, Tianfei
2020-11-24 11:31 ` Ferruh Yigit
2020-11-24 12:17 ` Zhang, Tianfei
2020-11-23 16:20 ` Maxime Coquelin
2020-11-24 3:32 ` Jiawen Wu
2021-02-11 11:29 ` Burakov, Anatoly
2023-06-14 21:59 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201123080714.7f162723@hermes.local \
--to=stephen@networkplumber.org \
--cc=ajit.khaparde@broadcom.com \
--cc=akhil.goyal@nxp.com \
--cc=anatoly.burakov@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=asomalap@amd.com \
--cc=beilei.xing@intel.com \
--cc=cardigliano@ntop.org \
--cc=chas3@att.com \
--cc=chenbo.xia@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=ed.czeck@atomicrules.com \
--cc=evgenys@amazon.com \
--cc=ferruh.yigit@intel.com \
--cc=g.singh@nxp.com \
--cc=gtzalik@amazon.com \
--cc=guyk@marvell.com \
--cc=haiyangz@microsoft.com \
--cc=haiyue.wang@intel.com \
--cc=heinrich.kuhn@netronome.com \
--cc=hemant.agrawal@nxp.com \
--cc=hkalra@marvell.com \
--cc=humin29@huawei.com \
--cc=igor.russkikh@aquantia.com \
--cc=igorch@amazon.com \
--cc=jasvinder.singh@intel.com \
--cc=jerinj@marvell.com \
--cc=jia.guo@intel.com \
--cc=jianjay.zhou@huawei.com \
--cc=jianwang@trustnetic.com \
--cc=jiawenwu@trustnetic.com \
--cc=jingjing.wu@intel.com \
--cc=john.miller@atomicrules.com \
--cc=kirankumark@marvell.com \
--cc=kys@microsoft.com \
--cc=liang.j.ma@intel.com \
--cc=lironh@marvell.com \
--cc=longli@microsoft.com \
--cc=matan@nvidia.com \
--cc=maxime.coquelin@redhat.com \
--cc=mdr@ashroe.eu \
--cc=mk@semihalf.com \
--cc=mw@semihalf.com \
--cc=ndabilpuram@marvell.com \
--cc=nhorman@tuxdriver.com \
--cc=orika@nvidia.com \
--cc=pavel.belous@aquantia.com \
--cc=peter.mccarthy@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=raveendra.padasalagi@broadcom.com \
--cc=rmody@marvell.com \
--cc=rosen.xu@intel.com \
--cc=sachin.saxena@oss.nxp.com \
--cc=shahafs@nvidia.com \
--cc=shepard.siegel@atomicrules.com \
--cc=shshaikh@marvell.com \
--cc=somnath.kotur@broadcom.com \
--cc=sthemmin@microsoft.com \
--cc=tianfei.zhang@intel.com \
--cc=timothy.mcdaniel@intel.com \
--cc=viacheslavo@nvidia.com \
--cc=vikas.gupta@broadcom.com \
--cc=xiao.w.wang@intel.com \
--cc=zr@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).