From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D10FA04B1; Mon, 23 Nov 2020 17:07:34 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ECDC2C8E6; Mon, 23 Nov 2020 17:07:32 +0100 (CET) Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by dpdk.org (Postfix) with ESMTP id 202CD160 for <dev@dpdk.org>; Mon, 23 Nov 2020 17:07:32 +0100 (CET) Received: by mail-pg1-f178.google.com with SMTP id f17so6130264pge.6 for <dev@dpdk.org>; Mon, 23 Nov 2020 08:07:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=m5ibPy/Iuf3fsVLbFxnFjv54jKQbnUBhDEc3IIqZFY4=; b=uMxtCD/XwfZ9TteRh3f2QQIGPs0nvwhYhMMSKW3P62wd+52AGv/Ng6K3KZ3Gc+1q0Q bdZxEcMxYRcOar6RVWR9qZYs6EeSdTR39qLl7g3ctOjS8glrPOn8OQWJaX1TfRxEgRGl aBTkvoG0S5m7w6NnXmD6UJv+OTxZV17/6jIWzRw26YfFsadraKZ+gjpZ7g80bKMDXSl5 H67RD9UkEelUU13SiYLjcKShn+Xo/Gu3TZ/8jMcCALL4xrD2aAYHULC0XLh7YLkOK0kL yU7coxfO0+m9WcW8Wl6gU5ae8fSKCXeo8l+LALv/X8+DTmQev7e+lnaM/3vq8ZNW3YNt CsiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=m5ibPy/Iuf3fsVLbFxnFjv54jKQbnUBhDEc3IIqZFY4=; b=L/K4yPz+ppo+2ttLHqMzGjmcv/48M5ZMyXFwoVCOrhnfxG36aSpzMmD5qWyx+nJrB3 pLd1jLWTRvHdU2OOBkMhUSrNzH/c2H6QikgilFffT620+A3LQjLvPk6Fk+omybYBnXCM lM85VMftL8HBlgHu81Ky4MiK6DZkkCWzGVZV/vsJjyr8ZBUcSouh3VP1YqpfJzZ8WhHP 6W9DYU3iNUy8LOLcm+FDyU1TdOZfWqz+oX0L9aS3DIlm3N0kD/EraspfhzQ9eKDHr1OV dgzFmS9BgEWAuq8dKSIrP38Uri7jP4+Q8W93QoZSYpOEG+faTPYibzRwd7O1goLLBf3A k/Jw== X-Gm-Message-State: AOAM5320l0vKr+Owgt+u0CKi94O9W/CuO+pBCcg58tnCX1VblZ1yCMi3 QOz2Bj9jUmrHFc6pjdkffh5HRQ== X-Google-Smtp-Source: ABdhPJx3UMDy0e564syNSl5PKt2zixIz02YaJ5kXM1HNnxAq1cL0VIGN9SlVAXfq2OkZcZ9eE13J+A== X-Received: by 2002:aa7:970a:0:b029:18b:5773:13e6 with SMTP id a10-20020aa7970a0000b029018b577313e6mr111183pfg.34.1606147650146; Mon, 23 Nov 2020 08:07:30 -0800 (PST) Received: from hermes.local (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id k4sm11175111pfa.103.2020.11.23.08.07.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Nov 2020 08:07:29 -0800 (PST) Date: Mon, 23 Nov 2020 08:07:14 -0800 From: Stephen Hemminger <stephen@networkplumber.org> To: Ferruh Yigit <ferruh.yigit@intel.com> Cc: "Zhang, Tianfei" <tianfei.zhang@intel.com>, Jerin Jacob <jerinj@marvell.com>, "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>, Hemant Agrawal <hemant.agrawal@nxp.com>, Sachin Saxena <sachin.saxena@oss.nxp.com>, Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>, "Xu, Rosen" <rosen.xu@intel.com>, "Wu, Jingjing" <jingjing.wu@intel.com>, "Xing, Beilei" <beilei.xing@intel.com>, Nithin Dabilpuram <ndabilpuram@marvell.com>, Ajit Khaparde <ajit.khaparde@broadcom.com>, Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>, Vikas Gupta <vikas.gupta@broadcom.com>, Gagandeep Singh <g.singh@nxp.com>, Somalapuram Amaranath <asomalap@amd.com>, Akhil Goyal <akhil.goyal@nxp.com>, Jay Zhou <jianjay.zhou@huawei.com>, "McDaniel, Timothy" <timothy.mcdaniel@intel.com>, "Ma, Liang J" <liang.j.ma@intel.com>, "Mccarthy, Peter" <peter.mccarthy@intel.com>, Shepard Siegel <shepard.siegel@atomicrules.com>, Ed Czeck <ed.czeck@atomicrules.com>, John Miller <john.miller@atomicrules.com>, Igor Russkikh <igor.russkikh@aquantia.com>, Pavel Belous <pavel.belous@aquantia.com>, Rasesh Mody <rmody@marvell.com>, Shahed Shaikh <shshaikh@marvell.com>, Somnath Kotur <somnath.kotur@broadcom.com>, Chas Williams <chas3@att.com>, "Min Hu (Connor)" <humin29@huawei.com>, Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>, "Guo, Jia" <jia.guo@intel.com>, "Wang, Haiyue" <haiyue.wang@intel.com>, Marcin Wojtas <mw@semihalf.com>, Michal Krawczyk <mk@semihalf.com>, Guy Tzalik <gtzalik@amazon.com>, Evgeny Schemeilin <evgenys@amazon.com>, Igor Chauskin <igorch@amazon.com>, "Zhang, Qi Z" <qi.z.zhang@intel.com>, "Wang, Xiao W" <xiao.w.wang@intel.com>, "Yang, Qiming" <qiming.yang@intel.com>, Alfredo Cardigliano <cardigliano@ntop.org>, Matan Azrad <matan@nvidia.com>, Shahaf Shuler <shahafs@nvidia.com>, Viacheslav Ovsiienko <viacheslavo@nvidia.com>, Zyta Szpak <zr@semihalf.com>, Liron Himi <lironh@marvell.com>, Stephen Hemminger <sthemmin@microsoft.com>, "K. Y. Srinivasan" <kys@microsoft.com>, Haiyang Zhang <haiyangz@microsoft.com>, Long Li <longli@microsoft.com>, Heinrich Kuhn <heinrich.kuhn@netronome.com>, Harman Kalra <hkalra@marvell.com>, Kiran Kumar K <kirankumark@marvell.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, "Singh, Jasvinder" <jasvinder.singh@intel.com>, Jiawen Wu <jiawenwu@trustnetic.com>, Jian Wang <jianwang@trustnetic.com>, Ori Kam <orika@nvidia.com>, Guy Kaneti <guyk@marvell.com>, "Burakov, Anatoly" <anatoly.burakov@intel.com>, Maxime Coquelin <maxime.coquelin@redhat.com>, "Xia, Chenbo" <chenbo.xia@intel.com>, "dev@dpdk.org" <dev@dpdk.org> Message-ID: <20201123080714.7f162723@hermes.local> In-Reply-To: <ed4086f7-0111-6d86-05d5-6ceea6b6e6f1@intel.com> References: <20201119035238.3653702-1-ferruh.yigit@intel.com> <DM6PR11MB3131A5C3D89FB5F6F3C404AFE3FC0@DM6PR11MB3131.namprd11.prod.outlook.com> <ed4086f7-0111-6d86-05d5-6ceea6b6e6f1@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [RFC] remove unused functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Mon, 23 Nov 2020 09:56:51 +0000 Ferruh Yigit <ferruh.yigit@intel.com> wrote: > On 11/23/2020 2:55 AM, Zhang, Tianfei wrote: > >> drivers/raw/ifpga/base/opae_eth_group.c | 25 - > >> drivers/raw/ifpga/base/opae_eth_group.h | 1 - > >> drivers/raw/ifpga/base/opae_hw_api.c | 212 -- > >> drivers/raw/ifpga/base/opae_hw_api.h | 36 - > >> drivers/raw/ifpga/base/opae_i2c.c | 12 - > >> drivers/raw/ifpga/base/opae_i2c.h | 4 - > >> drivers/raw/ifpga/base/opae_ifpga_hw_api.c | 99 - > >> drivers/raw/ifpga/base/opae_ifpga_hw_api.h | 15 - =20 > >=20 > > The ifpga base code is want to provide fully functionality low level ha= rdware support for Intel FPGA card like N3000, even though some APIs are no= t used by DPDK framework now=EF=BC=8Cbut it will useful for end-users or ot= her customers developing their own productions , my opinion is keeping thos= e APIs of ifpga base code in DPDK. > > =20 >=20 > The code is hidden behind the driver code, it is not accessible to user d= irectly. >=20 > If the idea is the code can be used later, it can be added when needed. >=20 > If the idea is the code can be needed in the field by users, can you plea= se give=20 > example on the use case? Dead code is buggy code. Please remove it. Maintaining dead code increases the overall technical debt. Dead code is guaranteed not to be tested. If someone needs it in future they can resurrect it from earlier versions which will always be there in git. If Intel wants to support it in DPDK then it should provide API's and tests= for it.