* [dpdk-dev] [PATCH] eal/windows: add stub for rte_intr_callback_register
@ 2020-11-26 8:06 Tal Shnaiderman
2020-12-01 16:41 ` Dmitry Kozlyuk
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Tal Shnaiderman @ 2020-11-26 8:06 UTC (permalink / raw)
To: dev
Cc: thomas, dmitry.kozliuk, navasile, dmitrym, pallavi.kadam, david.marchand
interrupt callback register is not implemented in Windows.
Add stub with -ENOTSUP return value and export the function.
Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
---
lib/librte_eal/rte_eal_exports.def | 1 +
lib/librte_eal/windows/eal_interrupts.c | 9 +++++++++
2 files changed, 10 insertions(+)
diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def
index 6a6be1cfa6..08cf25ea01 100644
--- a/lib/librte_eal/rte_eal_exports.def
+++ b/lib/librte_eal/rte_eal_exports.def
@@ -63,6 +63,7 @@ EXPORTS
rte_get_tsc_hz
rte_hexdump
rte_hypervisor_get
+ rte_intr_callback_register
rte_intr_rx_ctl
rte_lcore_count
rte_lcore_has_role
diff --git a/lib/librte_eal/windows/eal_interrupts.c b/lib/librte_eal/windows/eal_interrupts.c
index 6c64a48f34..fea338d705 100644
--- a/lib/librte_eal/windows/eal_interrupts.c
+++ b/lib/librte_eal/windows/eal_interrupts.c
@@ -105,3 +105,12 @@ eal_intr_thread_schedule(void (*func)(void *arg), void *arg)
return 0;
}
+
+int
+rte_intr_callback_register(
+ __rte_unused const struct rte_intr_handle *intr_handle,
+ __rte_unused rte_intr_callback_fn cb,
+ __rte_unused void *cb_arg)
+{
+ return -ENOTSUP;
+}
--
2.16.1.windows.4
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] eal/windows: add stub for rte_intr_callback_register
2020-11-26 8:06 [dpdk-dev] [PATCH] eal/windows: add stub for rte_intr_callback_register Tal Shnaiderman
@ 2020-12-01 16:41 ` Dmitry Kozlyuk
2020-12-05 0:56 ` Kadam, Pallavi
2020-12-05 0:57 ` Kadam, Pallavi
2 siblings, 0 replies; 5+ messages in thread
From: Dmitry Kozlyuk @ 2020-12-01 16:41 UTC (permalink / raw)
To: Tal Shnaiderman
Cc: dev, thomas, navasile, dmitrym, pallavi.kadam, david.marchand
On Thu, 26 Nov 2020 10:06:39 +0200, Tal Shnaiderman wrote:
> interrupt callback register is not implemented in Windows.
> Add stub with -ENOTSUP return value and export the function.
>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> ---
> lib/librte_eal/rte_eal_exports.def | 1 +
> lib/librte_eal/windows/eal_interrupts.c | 9 +++++++++
> 2 files changed, 10 insertions(+)
>
Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] eal/windows: add stub for rte_intr_callback_register
2020-11-26 8:06 [dpdk-dev] [PATCH] eal/windows: add stub for rte_intr_callback_register Tal Shnaiderman
2020-12-01 16:41 ` Dmitry Kozlyuk
@ 2020-12-05 0:56 ` Kadam, Pallavi
2020-12-07 20:43 ` Thomas Monjalon
2020-12-05 0:57 ` Kadam, Pallavi
2 siblings, 1 reply; 5+ messages in thread
From: Kadam, Pallavi @ 2020-12-05 0:56 UTC (permalink / raw)
To: Tal Shnaiderman, dev
Cc: thomas, dmitry.kozliuk, navasile, dmitrym, david.marchand
Hi Tal,
On 11/26/2020 12:06 AM, Tal Shnaiderman wrote:
> interrupt callback register is not implemented in Windows.
> Add stub with -ENOTSUP return value and export the function.
>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> ---
> lib/librte_eal/rte_eal_exports.def | 1 +
> lib/librte_eal/windows/eal_interrupts.c | 9 +++++++++
> 2 files changed, 10 insertions(+)
>
> diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def
> index 6a6be1cfa6..08cf25ea01 100644
> --- a/lib/librte_eal/rte_eal_exports.def
> +++ b/lib/librte_eal/rte_eal_exports.def
> @@ -63,6 +63,7 @@ EXPORTS
> rte_get_tsc_hz
> rte_hexdump
> rte_hypervisor_get
> + rte_intr_callback_register
> rte_intr_rx_ctl
> rte_lcore_count
> rte_lcore_has_role
> diff --git a/lib/librte_eal/windows/eal_interrupts.c b/lib/librte_eal/windows/eal_interrupts.c
> index 6c64a48f34..fea338d705 100644
> --- a/lib/librte_eal/windows/eal_interrupts.c
> +++ b/lib/librte_eal/windows/eal_interrupts.c
> @@ -105,3 +105,12 @@ eal_intr_thread_schedule(void (*func)(void *arg), void *arg)
>
> return 0;
> }
> +
> +int
> +rte_intr_callback_register(
> + __rte_unused const struct rte_intr_handle *intr_handle,
> + __rte_unused rte_intr_callback_fn cb,
> + __rte_unused void *cb_arg)
> +{
> + return -ENOTSUP;
> +}
We have also included the same code as it is required to compile i40e PMD.
Will remove it from our patch once this code is merged.
Thanks,
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] eal/windows: add stub for rte_intr_callback_register
2020-12-05 0:56 ` Kadam, Pallavi
@ 2020-12-07 20:43 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2020-12-07 20:43 UTC (permalink / raw)
To: Tal Shnaiderman, Kadam, Pallavi
Cc: dev, dmitry.kozliuk, navasile, dmitrym, david.marchand
05/12/2020 01:56, Kadam, Pallavi:
> Hi Tal,
>
> On 11/26/2020 12:06 AM, Tal Shnaiderman wrote:
> > interrupt callback register is not implemented in Windows.
> > Add stub with -ENOTSUP return value and export the function.
> >
> > Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> > ---
> > lib/librte_eal/rte_eal_exports.def | 1 +
> > lib/librte_eal/windows/eal_interrupts.c | 9 +++++++++
> > 2 files changed, 10 insertions(+)
> >
> > diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def
> > index 6a6be1cfa6..08cf25ea01 100644
> > --- a/lib/librte_eal/rte_eal_exports.def
> > +++ b/lib/librte_eal/rte_eal_exports.def
> > @@ -63,6 +63,7 @@ EXPORTS
> > rte_get_tsc_hz
> > rte_hexdump
> > rte_hypervisor_get
> > + rte_intr_callback_register
> > rte_intr_rx_ctl
> > rte_lcore_count
> > rte_lcore_has_role
> > diff --git a/lib/librte_eal/windows/eal_interrupts.c b/lib/librte_eal/windows/eal_interrupts.c
> > index 6c64a48f34..fea338d705 100644
> > --- a/lib/librte_eal/windows/eal_interrupts.c
> > +++ b/lib/librte_eal/windows/eal_interrupts.c
> > @@ -105,3 +105,12 @@ eal_intr_thread_schedule(void (*func)(void *arg), void *arg)
> >
> > return 0;
> > }
> > +
> > +int
> > +rte_intr_callback_register(
> > + __rte_unused const struct rte_intr_handle *intr_handle,
> > + __rte_unused rte_intr_callback_fn cb,
> > + __rte_unused void *cb_arg)
> > +{
> > + return -ENOTSUP;
> > +}
>
> We have also included the same code as it is required to compile i40e PMD.
>
> Will remove it from our patch once this code is merged.
It would make more sense to have a patch which introduces all
intr-related stubs, including epoll ones.
There are already 3 patches around, none of them is complete:
https://patches.dpdk.org/patch/84389/
https://patches.dpdk.org/patch/84567/
https://patches.dpdk.org/patch/84771/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] eal/windows: add stub for rte_intr_callback_register
2020-11-26 8:06 [dpdk-dev] [PATCH] eal/windows: add stub for rte_intr_callback_register Tal Shnaiderman
2020-12-01 16:41 ` Dmitry Kozlyuk
2020-12-05 0:56 ` Kadam, Pallavi
@ 2020-12-05 0:57 ` Kadam, Pallavi
2 siblings, 0 replies; 5+ messages in thread
From: Kadam, Pallavi @ 2020-12-05 0:57 UTC (permalink / raw)
To: Tal Shnaiderman, dev
Cc: thomas, dmitry.kozliuk, navasile, dmitrym, david.marchand
On 11/26/2020 12:06 AM, Tal Shnaiderman wrote:
> interrupt callback register is not implemented in Windows.
> Add stub with -ENOTSUP return value and export the function.
>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> ---
Acked-by: Pallavi Kadam <pallavi.kadam@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-12-07 20:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-26 8:06 [dpdk-dev] [PATCH] eal/windows: add stub for rte_intr_callback_register Tal Shnaiderman
2020-12-01 16:41 ` Dmitry Kozlyuk
2020-12-05 0:56 ` Kadam, Pallavi
2020-12-07 20:43 ` Thomas Monjalon
2020-12-05 0:57 ` Kadam, Pallavi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).