From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E08F9A052A; Thu, 26 Nov 2020 12:41:20 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E0B93C93C; Thu, 26 Nov 2020 12:41:18 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 0D5DDC93A for ; Thu, 26 Nov 2020 12:41:15 +0100 (CET) IronPort-SDR: cyXhoVArkP/VXtAZji8S9wjqCh0EyznVbRnQP4yo88V/nc7ROKJCJmXEUCL6jTejiu0L5bOIKE eBQrDZYPTdDg== X-IronPort-AV: E=McAfee;i="6000,8403,9816"; a="172372661" X-IronPort-AV: E=Sophos;i="5.78,371,1599548400"; d="scan'208";a="172372661" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Nov 2020 03:41:13 -0800 IronPort-SDR: XK0sQ+0wpssOTCyyRyMrk9kdNTNsqBrp8k4yTmOPxelXBD3j35HF1tMGHJMSBek8sOlZSTFVuS nqA4yhxXlpCw== X-IronPort-AV: E=Sophos;i="5.78,371,1599548400"; d="scan'208";a="362778559" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.21.198]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 26 Nov 2020 03:41:12 -0800 Date: Thu, 26 Nov 2020 11:41:09 +0000 From: Bruce Richardson To: Reshma Pattan Cc: dev@dpdk.org Message-ID: <20201126114109.GB1340@bricha3-MOBL.ger.corp.intel.com> References: <1594650325-151798-1-git-send-email-reshma.pattan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1594650325-151798-1-git-send-email-reshma.pattan@intel.com> Subject: Re: [dpdk-dev] [PATCH] doc: update pdump documentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jul 13, 2020 at 03:25:25PM +0100, Reshma Pattan wrote: > Update the pdump library programmers guide and Howto doc > with the use of multi process channel replacing socket > based communication. > > Signed-off-by: Reshma Pattan > --- Some minor adjustments I'd suggest below. Otherwise: Acked-by: Bruce Richardson > doc/guides/howto/packet_capture_framework.rst | 16 ++++----- > doc/guides/prog_guide/pdump_lib.rst | 49 +++++++++++---------------- > 2 files changed, 28 insertions(+), 37 deletions(-) > > diff --git a/doc/guides/howto/packet_capture_framework.rst b/doc/guides/howto/packet_capture_framework.rst > index 946a21c..c941c01 100644 > --- a/doc/guides/howto/packet_capture_framework.rst > +++ b/doc/guides/howto/packet_capture_framework.rst > @@ -19,7 +19,7 @@ Introduction > > -In DPDK the ``testpmd`` application can be used to initialize the packet > -capture framework and act as a server, and the ``dpdk-pdump`` tool acts as a > -client. To view Rx or Tx packets of ``testpmd``, the application should be > +In DPDK the ``testpmd`` application has been initialize with the packet > +capture framework and acts as primary process, and the ``dpdk-pdump`` tool acts as a > +secondary process. To view Rx or Tx packets of ``testpmd``, the application should be I think the original text was better for this block. > launched first, and then the ``dpdk-pdump`` tool. Packets from ``testpmd`` > will be sent to the tool, which then sends them on to the Pcap PMD device and > that device writes them to the Pcap file or to an external interface depending > diff --git a/doc/guides/prog_guide/pdump_lib.rst b/doc/guides/prog_guide/pdump_lib.rst > index 2a0f1f3..227eb1a 100644 > --- a/doc/guides/prog_guide/pdump_lib.rst > +++ b/doc/guides/prog_guide/pdump_lib.rst > @@ -11,8 +11,12 @@ The library does the complete copy of the Rx and Tx mbufs to a new mempool and > hence it slows down the performance of the applications, so it is recommended > to use this library for debugging purposes. > > +The library uses generic multi process channel to facilitate communication ^^a Missing word "a" in sentence. > +between primary and secondary process for enabling/disabling packet capture on > +ports. > + > The library APIs ``rte_pdump_disable()`` and ``rte_pdump_disable_by_deviceid()`` disables the packet capture. > -On each call to these APIs, the library creates a separate client socket, creates the "pdump disable" request and sends > -the request to the server. The server that is listening on the socket will take the request and disable the packet > -capture by removing the Ethernet RX and TX callbacks for the given port or device_id and queue combinations. The server > -also sends the response back to the client about the status of the request that was processed. After the response is > -received from the server, the client socket is closed. > +For the calls to these APIs from secondary process, the library creates the "pdump disable" request and sends > +the request to the primary process over the multi process channel, the primary process takes this request and disable ^^. ^^disables Split sentence as indicated and also add "s" to disable. > +the packet capture by removing the Ethernet RX and TX callbacks for the given port or device_id and queue combinations. > > The library API ``rte_pdump_uninit()``, uninitializes the packet capture framework by calling ``rte_mp_action_unregister()`` > function. > -- > 1.8.3.1 >