From: Bruce Richardson <bruce.richardson@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] doc/devbind: remove references to igb_uio
Date: Thu, 26 Nov 2020 11:48:38 +0000 [thread overview]
Message-ID: <20201126114838.GC1340@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <bbf44a3e-34e1-f70e-951b-8ac8a123517b@intel.com>
On Wed, Oct 14, 2020 at 05:43:29PM +0100, Ferruh Yigit wrote:
> On 9/24/2020 6:53 PM, Stephen Hemminger wrote:
> > We should be encouraging the use of vfio_pci for developers, not telling
> > them to use igb_uio.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> > v2 -- drop change about filename
> >
> > doc/guides/tools/devbind.rst | 18 +++++++++---------
> > 1 file changed, 9 insertions(+), 9 deletions(-)
> >
> > diff --git a/doc/guides/tools/devbind.rst b/doc/guides/tools/devbind.rst
> > index a2910e103aab..5dcaf8c207dd 100644
> > --- a/doc/guides/tools/devbind.rst
> > +++ b/doc/guides/tools/devbind.rst
> > @@ -30,11 +30,11 @@ OPTIONS
> > Print the current status of all known network interfaces.
> > For each device, it displays the PCI domain, bus, slot and function,
> > along with a text description of the device. Depending upon whether the
> > - device is being used by a kernel driver, the ``igb_uio`` driver, or no
> > + device is being used by a kernel driver, the ``vfio_pci`` driver, or no
> > driver, other relevant information will be displayed:
> > - the Linux interface name e.g. ``if=eth0``
> > - - the driver being used e.g. ``drv=igb_uio``
> > - - any suitable drivers not currently using that device e.g. ``unused=igb_uio``
> > + - the driver being used e.g. ``drv=vfio_pci``
> > + - any suitable drivers not currently using that device e.g. ``unused=vfio_pci``
> > NOTE: if this flag is passed along with a bind/unbind option, the
> > status display will always occur after the other operations have taken
> > place.
> > @@ -80,9 +80,9 @@ To display current device status::
> > dpdk-devbind --status
> > -To bind eth1 from the current driver and move to use igb_uio::
> > +To bind eth1 from the current driver and move to use vfio_pci::
> > - dpdk-devbind --bind=igb_uio eth1
> > + dpdk-devbind --bind=vfio_pci eth1
>
> Module name is 'vfio_pci' but driver name is 'vfio-pci', for this document I
> guess all instances should be 'vfio-pci'.
>
Yes, I believe all instances of vfio_pci should be replaced with the "-"ed
version. With that change:
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2020-11-26 11:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-06 3:38 [dpdk-dev] [PATCH] " Stephen Hemminger
2020-09-07 9:08 ` Bruce Richardson
2020-09-07 17:22 ` Stephen Hemminger
2020-09-24 17:53 ` [dpdk-dev] [PATCH v2] " Stephen Hemminger
2020-10-14 16:43 ` Ferruh Yigit
2020-11-26 11:48 ` Bruce Richardson [this message]
2020-11-26 16:00 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201126114838.GC1340@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).